From: Rae Moar <rmoar@google.com>
To: shuah@kernel.org, davidgow@google.com, dlatypov@google.com,
brendan.higgins@linux.dev
Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, keescook@chromium.org,
linux-hardening@vger.kernel.org, jstultz@google.com,
tglx@linutronix.de, sboyd@kernel.org, Rae Moar <rmoar@google.com>
Subject: [PATCH v1 7/9] kunit: time: Mark test as slow using test attributes
Date: Wed, 19 Jul 2023 22:23:34 +0000 [thread overview]
Message-ID: <20230719222338.259684-8-rmoar@google.com> (raw)
In-Reply-To: <20230719222338.259684-1-rmoar@google.com>
Mark the time KUnit test, time64_to_tm_test_date_range, as slow using test
attributes.
This test ran relatively much slower than most other KUnit tests.
By marking this test as slow, the test can now be filtered using the KUnit
test attribute filtering feature. Example: --filter "speed>slow". This will
run only the tests that have speeds faster than slow. The slow attribute
will also be outputted in KTAP.
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Rae Moar <rmoar@google.com>
---
Changes since RFC v2:
- No changes.
Changes since RFC v1:
- No changes.
kernel/time/time_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
index 831e8e779ace..ca058c8af6ba 100644
--- a/kernel/time/time_test.c
+++ b/kernel/time/time_test.c
@@ -86,7 +86,7 @@ static void time64_to_tm_test_date_range(struct kunit *test)
}
static struct kunit_case time_test_cases[] = {
- KUNIT_CASE(time64_to_tm_test_date_range),
+ KUNIT_CASE_SLOW(time64_to_tm_test_date_range),
{}
};
--
2.41.0.255.g8b1d071c50-goog
next prev parent reply other threads:[~2023-07-19 22:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 22:23 [PATCH v1 0/9] kunit: Add test attributes API Rae Moar
2023-07-19 22:23 ` [PATCH v1 1/9] kunit: Add test attributes API structure Rae Moar
2023-07-19 22:23 ` [PATCH v1 2/9] kunit: Add speed attribute Rae Moar
2023-07-21 4:31 ` kernel test robot
2023-07-19 22:23 ` [PATCH v1 3/9] kunit: Add module attribute Rae Moar
2023-07-19 22:23 ` [PATCH v1 4/9] kunit: Add ability to filter attributes Rae Moar
2023-07-22 2:30 ` kernel test robot
2023-07-19 22:23 ` [PATCH v1 5/9] kunit: tool: Add command line interface to filter and report attributes Rae Moar
2023-07-19 22:23 ` [PATCH v1 6/9] kunit: memcpy: Mark tests as slow using test attributes Rae Moar
2023-07-19 22:23 ` Rae Moar [this message]
2023-07-19 22:23 ` [PATCH v1 8/9] kunit: add tests for filtering attributes Rae Moar
2023-07-19 22:23 ` [PATCH v1 9/9] kunit: Add documentation of KUnit test attributes Rae Moar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230719222338.259684-8-rmoar@google.com \
--to=rmoar@google.com \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=jstultz@google.com \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).