From: kernel test robot <lkp@intel.com>
To: Rae Moar <rmoar@google.com>,
shuah@kernel.org, davidgow@google.com, dlatypov@google.com,
brendan.higgins@linux.dev
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, keescook@chromium.org,
linux-hardening@vger.kernel.org, jstultz@google.com,
tglx@linutronix.de, sboyd@kernel.org, Rae Moar <rmoar@google.com>
Subject: Re: [PATCH v1 4/9] kunit: Add ability to filter attributes
Date: Sat, 22 Jul 2023 10:30:31 +0800 [thread overview]
Message-ID: <202307221053.0LbbjwLI-lkp@intel.com> (raw)
In-Reply-To: <20230719222338.259684-5-rmoar@google.com>
Hi Rae,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 64bd4641310c41a1ecf07c13c67bc0ed61045dfd]
url: https://github.com/intel-lab-lkp/linux/commits/Rae-Moar/kunit-Add-test-attributes-API-structure/20230720-062623
base: 64bd4641310c41a1ecf07c13c67bc0ed61045dfd
patch link: https://lore.kernel.org/r/20230719222338.259684-5-rmoar%40google.com
patch subject: [PATCH v1 4/9] kunit: Add ability to filter attributes
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230722/202307221053.0LbbjwLI-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20230722/202307221053.0LbbjwLI-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307221053.0LbbjwLI-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> lib/kunit/attributes.c:109:14: warning: variable 'input_val' is used uninitialized whenever 'for' loop exits because its condition is false [-Wsometimes-uninitialized]
for (i = 0; input[i]; i++) {
^~~~~~~~
lib/kunit/attributes.c:116:7: note: uninitialized use occurs here
if (!input_val) {
^~~~~~~~~
lib/kunit/attributes.c:109:14: note: remove the condition if it is always true
for (i = 0; input[i]; i++) {
^~~~~~~~
lib/kunit/attributes.c:107:23: note: initialize the variable 'input_val' to silence this warning
const char *input_val;
^
= NULL
lib/kunit/attributes.c:215:47: error: initializer element is not a compile-time constant
static struct kunit_attr kunit_attr_list[] = {speed_attr, module_attr};
^~~~~~~~~~
1 warning and 1 error generated.
vim +109 lib/kunit/attributes.c
96
97 /*
98 * Returns whether the inputted enum value "attr" matches the filter given
99 * by the input string. Note: the str_list includes the corresponding string
100 * list to the enum values.
101 */
102 static int attr_enum_filter(void *attr, const char *input, int *err,
103 const char * const str_list[], int max)
104 {
105 int i, j, input_int;
106 long test_val = (long)attr;
107 const char *input_val;
108
> 109 for (i = 0; input[i]; i++) {
110 if (!strchr(op_list, input[i])) {
111 input_val = input + i;
112 break;
113 }
114 }
115
116 if (!input_val) {
117 *err = -EINVAL;
118 pr_err("kunit executor: filter value not found: %s\n", input);
119 return false;
120 }
121
122 for (j = 0; j <= max; j++) {
123 if (!strcmp(input_val, str_list[j]))
124 input_int = j;
125 }
126
127 if (!input_int) {
128 *err = -EINVAL;
129 pr_err("kunit executor: invalid filter input: %s\n", input);
130 return false;
131 }
132
133 return int_filter(test_val, input, input_int, err);
134 }
135
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-07-22 2:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 22:23 [PATCH v1 0/9] kunit: Add test attributes API Rae Moar
2023-07-19 22:23 ` [PATCH v1 1/9] kunit: Add test attributes API structure Rae Moar
2023-07-19 22:23 ` [PATCH v1 2/9] kunit: Add speed attribute Rae Moar
2023-07-21 4:31 ` kernel test robot
2023-07-19 22:23 ` [PATCH v1 3/9] kunit: Add module attribute Rae Moar
2023-07-19 22:23 ` [PATCH v1 4/9] kunit: Add ability to filter attributes Rae Moar
2023-07-22 2:30 ` kernel test robot [this message]
2023-07-19 22:23 ` [PATCH v1 5/9] kunit: tool: Add command line interface to filter and report attributes Rae Moar
2023-07-19 22:23 ` [PATCH v1 6/9] kunit: memcpy: Mark tests as slow using test attributes Rae Moar
2023-07-19 22:23 ` [PATCH v1 7/9] kunit: time: Mark test " Rae Moar
2023-07-19 22:23 ` [PATCH v1 8/9] kunit: add tests for filtering attributes Rae Moar
2023-07-19 22:23 ` [PATCH v1 9/9] kunit: Add documentation of KUnit test attributes Rae Moar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307221053.0LbbjwLI-lkp@intel.com \
--to=lkp@intel.com \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=jstultz@google.com \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rmoar@google.com \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).