From: Peter Hutterer <peter.hutterer@who-t.net>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Mario Limonciello" <superm1@gmail.com>,
"Filipe Laíns" <lains@archlinux.org>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Peter Hutterer" <peter.hutterer@redhat.com>,
"Richard Hughes" <hughsient@gmail.com>
Subject: Re: [PATCH] HID: logitech-dj: issue udev change event on device connection
Date: Thu, 19 Mar 2020 12:23:31 +1000 [thread overview]
Message-ID: <20200319022331.GA2384843@jelly> (raw)
In-Reply-To: <e8ea0c2e-445f-21e2-a248-3368f26bf391@redhat.com>
On Wed, Mar 18, 2020 at 06:20:03PM +0100, Hans de Goede wrote:
> Hi,
>
> On 3/18/20 6:15 PM, Mario Limonciello wrote:
> > On Wed, Mar 18, 2020 at 11:19 AM Filipe Laíns <lains@archlinux.org> wrote:
> > >
> > > As discussed in the mailing list:
> > >
> > > > Right now the hid-logitech-dj driver will export one node for each
> > > > connected device, even when the device is not connected. That causes
> > > > some trouble because in userspace we don't have have any way to know if
> > > > the device is connected or not, so when we try to communicate, if the
> > > > device is disconnected it will fail.
> > >
> > > The solution reached to solve this issue is to trigger an udev change
> > > event when the device connects, this way userspace can just wait on
> > > those connections instead of trying to ping the device.
> > >
> > > Signed-off-by: Filipe Laíns <lains@archlinux.org>
> > > ---
> > > drivers/hid/hid-logitech-dj.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> > > index 48dff5d6b605..fcd481a0be1f 100644
> > > --- a/drivers/hid/hid-logitech-dj.c
> > > +++ b/drivers/hid/hid-logitech-dj.c
> > > @@ -1464,6 +1464,8 @@ static int logi_dj_dj_event(struct hid_device *hdev,
> > > if (dj_report->report_params[CONNECTION_STATUS_PARAM_STATUS] ==
> > > STATUS_LINKLOSS) {
> > > logi_dj_recv_forward_null_report(djrcv_dev, dj_report);
> > > + } else {
> > > + kobject_uevent(&hdev->dev.kobj, KOBJ_CHANGE);
> > > }
> > > break;
> > > default:
> > > --
> > > 2.25.1
> >
> > The problem that will remain here is the transition period for
> > userspace to start to rely upon
> > this. It will have no idea whether the kernel is expected to send
> > events or not. What do you
> > think about adding a syfs attribute to indicate that events are being
> > sent? Or something similar?
>
> Then we would need to support that attribute forever. IMHO the best
> option is to just make a uname call and check the kernel version, with
> the code marked to be removed in the future when kernels older then
> $version are no longer something we want to support.
Also note that we may not have access to /sys.
Cheers,
Peter
next prev parent reply other threads:[~2020-03-19 2:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 16:19 [PATCH] HID: logitech-dj: issue udev change event on device connection Filipe Laíns
2020-03-18 17:15 ` Mario Limonciello
2020-03-18 17:20 ` Hans de Goede
2020-03-19 2:23 ` Peter Hutterer [this message]
2020-03-21 0:05 ` Jiri Kosina
[not found] ` <CA+EcB1P0qW4hdWG1YAYkD6X8jL1OaXZn4Lfu7aCmGBqwOPrJyA@mail.gmail.com>
2020-03-21 0:29 ` Peter Hutterer
2020-03-18 19:23 ` Filipe Laíns
2020-03-18 19:27 ` [PATCH v2] " Filipe Laíns
2020-03-24 10:20 ` Bastien Nocera
2020-03-24 13:46 ` Filipe Laíns
2020-03-24 14:03 ` Bastien Nocera
2020-03-24 14:10 ` Filipe Laíns
2020-03-24 14:24 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319022331.GA2384843@jelly \
--to=peter.hutterer@who-t.net \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=hughsient@gmail.com \
--cc=jikos@kernel.org \
--cc=lains@archlinux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@redhat.com \
--cc=superm1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).