From: Bastien Nocera <hadess@hadess.net>
To: "Filipe Laíns" <lains@archlinux.org>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Peter Hutterer" <peter.hutterer@redhat.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mario Limonciello" <superm1@gmail.com>,
"Richard Hughes" <hughsient@gmail.com>
Subject: Re: [PATCH v2] HID: logitech-dj: issue udev change event on device connection
Date: Tue, 24 Mar 2020 11:20:21 +0100 [thread overview]
Message-ID: <92f48f409e913299c12322d195c88792bb4e5c9c.camel@hadess.net> (raw)
In-Reply-To: <20200318192721.390630-1-lains@archlinux.org>
On Wed, 2020-03-18 at 19:27 +0000, Filipe Laíns wrote:
> As discussed in the mailing list:
>
> > Right now the hid-logitech-dj driver will export one node for each
> > connected device, even when the device is not connected. That
> > causes
> > some trouble because in userspace we don't have have any way to
> > know if
> > the device is connected or not, so when we try to communicate, if
> > the
> > device is disconnected it will fail.
Why is it a problem that user-space communication fails? Note that
sending a signal without any way to fetch the state means that it's
always going to be racy.
> The solution reached to solve this issue is to trigger an udev change
> event when the device connects, this way userspace can just wait on
> those connections instead of trying to ping the device.
>
> Signed-off-by: Filipe Laíns <lains@archlinux.org>
>
> ---
>
> v2:
> - Issue udev change event on the connected hid device, not on the
> receiver
>
> ---
> drivers/hid/hid-logitech-dj.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-
> logitech-dj.c
> index 48dff5d6b605..282e57dd467d 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -1412,6 +1412,7 @@ static int logi_dj_dj_event(struct hid_device
> *hdev,
> {
> struct dj_receiver_dev *djrcv_dev = hid_get_drvdata(hdev);
> struct dj_report *dj_report = (struct dj_report *) data;
> + struct dj_device *dj_dev;
> unsigned long flags;
>
> /*
> @@ -1447,7 +1448,9 @@ static int logi_dj_dj_event(struct hid_device
> *hdev,
>
> spin_lock_irqsave(&djrcv_dev->lock, flags);
>
> - if (!djrcv_dev->paired_dj_devices[dj_report->device_index]) {
> + dj_dev = djrcv_dev->paired_dj_devices[dj_report->device_index];
> +
> + if (!dj_dev) {
> /* received an event for an unknown device, bail out */
> logi_dj_recv_queue_notification(djrcv_dev, dj_report);
> goto out;
> @@ -1464,6 +1467,8 @@ static int logi_dj_dj_event(struct hid_device
> *hdev,
> if (dj_report-
> >report_params[CONNECTION_STATUS_PARAM_STATUS] ==
> STATUS_LINKLOSS) {
> logi_dj_recv_forward_null_report(djrcv_dev,
> dj_report);
> + } else {
> + kobject_uevent(&dj_dev->hdev->dev.kobj,
> KOBJ_CHANGE);
> }
> break;
> default:
next prev parent reply other threads:[~2020-03-24 10:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 16:19 [PATCH] HID: logitech-dj: issue udev change event on device connection Filipe Laíns
2020-03-18 17:15 ` Mario Limonciello
2020-03-18 17:20 ` Hans de Goede
2020-03-19 2:23 ` Peter Hutterer
2020-03-21 0:05 ` Jiri Kosina
[not found] ` <CA+EcB1P0qW4hdWG1YAYkD6X8jL1OaXZn4Lfu7aCmGBqwOPrJyA@mail.gmail.com>
2020-03-21 0:29 ` Peter Hutterer
2020-03-18 19:23 ` Filipe Laíns
2020-03-18 19:27 ` [PATCH v2] " Filipe Laíns
2020-03-24 10:20 ` Bastien Nocera [this message]
2020-03-24 13:46 ` Filipe Laíns
2020-03-24 14:03 ` Bastien Nocera
2020-03-24 14:10 ` Filipe Laíns
2020-03-24 14:24 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92f48f409e913299c12322d195c88792bb4e5c9c.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=hughsient@gmail.com \
--cc=jikos@kernel.org \
--cc=lains@archlinux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@redhat.com \
--cc=superm1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).