From: Peter Hutterer <peter.hutterer@who-t.net>
To: Mario Limonciello <superm1@gmail.com>
Cc: "Jiri Kosina" <jikos@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Filipe Laíns" <lains@archlinux.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
"Peter Hutterer" <peter.hutterer@redhat.com>,
"Richard Hughes" <hughsient@gmail.com>
Subject: Re: [PATCH] HID: logitech-dj: issue udev change event on device connection
Date: Sat, 21 Mar 2020 10:29:04 +1000 [thread overview]
Message-ID: <20200321002904.GA2472393@jelly> (raw)
In-Reply-To: <CA+EcB1P0qW4hdWG1YAYkD6X8jL1OaXZn4Lfu7aCmGBqwOPrJyA@mail.gmail.com>
On Fri, Mar 20, 2020 at 07:15:38PM -0500, Mario Limonciello wrote:
> On Fri, Mar 20, 2020, 19:06 Jiri Kosina <jikos@kernel.org> wrote:
>
> > On Thu, 19 Mar 2020, Peter Hutterer wrote:
> >
> > > > Then we would need to support that attribute forever. IMHO the best
> > > > option is to just make a uname call and check the kernel version, with
> > > > the code marked to be removed in the future when kernels older then
> > > > $version are no longer something we want to support.
> >
> > Oh, this doesn't work *at all* with distro kernels backporting everything
> > that passess by to kernels with major versions looking years old.
> >
> > I (as one of the "guilty ones" with my distro hat on) am not at all saying
> > it's perfect, but that's the way it is.
> >
> > --
> > Jiri Kosina
> > SUSE Lab
> >
>
> Another "solution" is to use module versioning bump as part of this patch.
> At least when distros backport then you can look at module versioning to
> tell the behavior of the driver.
tbh, if there is no good solution in the kernel to communicate this,
userspace can make do without knowing about it ahead of time.
long-term you can just assume you'll get the change event and handle the
error case just as you'd have to do now. Sure it'd be nice to know ahead of
time but it's not the only thing we don't know until we get the first event.
Cheers,
Peter
next prev parent reply other threads:[~2020-03-21 0:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 16:19 [PATCH] HID: logitech-dj: issue udev change event on device connection Filipe Laíns
2020-03-18 17:15 ` Mario Limonciello
2020-03-18 17:20 ` Hans de Goede
2020-03-19 2:23 ` Peter Hutterer
2020-03-21 0:05 ` Jiri Kosina
[not found] ` <CA+EcB1P0qW4hdWG1YAYkD6X8jL1OaXZn4Lfu7aCmGBqwOPrJyA@mail.gmail.com>
2020-03-21 0:29 ` Peter Hutterer [this message]
2020-03-18 19:23 ` Filipe Laíns
2020-03-18 19:27 ` [PATCH v2] " Filipe Laíns
2020-03-24 10:20 ` Bastien Nocera
2020-03-24 13:46 ` Filipe Laíns
2020-03-24 14:03 ` Bastien Nocera
2020-03-24 14:10 ` Filipe Laíns
2020-03-24 14:24 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321002904.GA2472393@jelly \
--to=peter.hutterer@who-t.net \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=hughsient@gmail.com \
--cc=jikos@kernel.org \
--cc=lains@archlinux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@redhat.com \
--cc=superm1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).