From: skhan at linuxfoundation.org (Shuah Khan)
Subject: [Linux-kernel-mentees] [PATCH v2 2/2] cec-compliance: add/refactor tuner control tests
Date: Tue, 24 Sep 2019 13:44:55 -0600 [thread overview]
Message-ID: <d8e866e5-fca2-eed7-5b2f-38bfca380d81@linuxfoundation.org> (raw)
In-Reply-To: <20190924192445.93575-3-c0d1n61at3@gmail.com>
On 9/24/19 1:24 PM, Jiunn Chang wrote:
> Tests added/refactored for new features added to the cec-follower.
>
> Analog tuner control tests added/refactored:
> - give analog tuner status
> - select tuner analog service
> - analog tuner step decrement
> - analog tuner step increment
>
> Signed-off-by: Jiunn Chang <c0d1n61at3 at gmail.com>
> ---
> utils/cec-compliance/cec-test.cpp | 181 +++++++++++++++++++++++-------
> 1 file changed, 140 insertions(+), 41 deletions(-)
>
> diff --git a/utils/cec-compliance/cec-test.cpp b/utils/cec-compliance/cec-test.cpp
> index aece546c..91600d39 100644
> --- a/utils/cec-compliance/cec-test.cpp
> +++ b/utils/cec-compliance/cec-test.cpp
> @@ -722,9 +722,19 @@ static struct remote_subtest deck_ctl_subtests[] = {
> TODO: These are very rudimentary tests which should be expanded.
> */
>
> -static int tuner_ctl_give_status(struct node *node, unsigned me, unsigned la, bool interactive)
> +static int tuner_ctl_analog_give_status(struct node *node, unsigned me, unsigned la, bool interactive)
> {
> struct cec_msg msg = {};
> + struct cec_op_tuner_device_info info = {};
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_select_analogue_service(&msg, CEC_OP_ANA_BCAST_TYPE_CABLE,
> + 7668, CEC_OP_BCAST_SYSTEM_PAL_BG); // 479.25 MHz analog frequency
> + fail_on_test(!transmit_timeout(node, &msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
>
> cec_msg_init(&msg, me, la);
> cec_msg_give_tuner_device_status(&msg, true, CEC_OP_STATUS_REQ_ONCE);
> @@ -737,6 +747,14 @@ static int tuner_ctl_give_status(struct node *node, unsigned me, unsigned la, bo
> if (cec_msg_status_is_abort(&msg))
> return PRESUMED_OK;
>
> + cec_ops_tuner_device_status(&msg, &info);
> + if (info.analog.ana_bcast_type != CEC_OP_ANA_BCAST_TYPE_CABLE)
> + return FAIL;
> + if (info.analog.ana_freq != 7668)
> + return FAIL;
> + if (info.analog.bcast_system != CEC_OP_BCAST_SYSTEM_PAL_BG)
> + return FAIL;
> +
Why not combine these conditionals in to one. Why do you need 3 separate
blocks?
> return 0;
> }
>
> @@ -745,23 +763,24 @@ static int tuner_ctl_sel_analog_service(struct node *node, unsigned me, unsigned
> struct cec_msg msg = {};
>
> node->remote[la].bcast_sys = ~0;
> - for (unsigned sys = 0; sys <= 8; sys++) {
> - cec_msg_init(&msg, me, la);
> - cec_msg_select_analogue_service(&msg, CEC_OP_ANA_BCAST_TYPE_CABLE,
> - 7668, sys); // 479.25 MHz analog frequency
> - fail_on_test(!transmit_timeout(node, &msg));
> - if (unrecognized_op(&msg))
> - return NOTSUPPORTED;
> - if (abort_reason(&msg) == CEC_OP_ABORT_INVALID_OP) {
> - info("Tuner supports %s, but cannot select that service.\n",
> - bcast_system2s(sys));
> + for (unsigned type = 0; type < 3; type++) {
> + for (unsigned sys = 0; sys < 9; sys++) {
> + cec_msg_init(&msg, me, la);
> + cec_msg_select_analogue_service(&msg, type, 7668, sys); // 479.25 MHz analog frequency
> + fail_on_test(!transmit_timeout(node, &msg));
Adding line here will help readability.
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
Same here.
> + if (abort_reason(&msg) == CEC_OP_ABORT_INVALID_OP) {
> + info("Tuner supports %s, but cannot select that service.\n",
> + bcast_system2s(sys));
> + node->remote[la].bcast_sys = sys;
> + continue;
> + }
same here.
> + if (cec_msg_status_is_abort(&msg))
> + continue;
> + info("Tuner supports %s\n", bcast_system2s(sys));
> node->remote[la].bcast_sys = sys;
> - continue;
> }
> - if (cec_msg_status_is_abort(&msg))
> - continue;
> - info("Tuner supports %s\n", bcast_system2s(sys));
> - node->remote[la].bcast_sys = sys;
> }
>
> if (node->remote[la].bcast_sys == (__u8)~0)
> @@ -854,43 +873,123 @@ static int tuner_ctl_tuner_dev_status(struct node *node, unsigned me, unsigned l
> return 0;
> }
>
> -static int tuner_ctl_step_dec(struct node *node, unsigned me, unsigned la, bool interactive)
> +static int tuner_ctl_analog_step_dec(struct node *node, unsigned me, unsigned la, bool interactive)
> {
> struct cec_msg msg = {};
> + struct cec_op_tuner_device_info info = {};
> + __u16 freq = 0;
> +
> + info.is_analog = true;
> + for (unsigned type = 0; type < 3; type++) {
> + for (unsigned sys = 0; sys < 9; sys++) {
> + cec_msg_init(&msg, me, la);
> + cec_msg_select_analogue_service(&msg, type, 16000, sys); // 1000 MHz analog frequency
> + fail_on_test(!transmit_timeout(node, &msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_give_tuner_device_status(&msg, true, CEC_OP_STATUS_REQ_ONCE);
> + fail_on_test(!transmit_timeout(node, &msg));
> + fail_on_test(timed_out(&msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
Add a goto NOTSUPPORTED; Makes it easier.
You can simplify this logic a lot.
> + if (refused(&msg))
> + return REFUSED;
> + cec_ops_tuner_device_status(&msg, &info);
> + freq = info.analog.ana_freq;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_tuner_step_decrement(&msg);
> + fail_on_test(!transmit_timeout(node, &msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
> + if (cec_msg_status_is_abort(&msg))
> + return PRESUMED_OK;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_give_tuner_device_status(&msg, true, CEC_OP_STATUS_REQ_ONCE);
> + fail_on_test(!transmit_timeout(node, &msg));
> + fail_on_test(timed_out(&msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
> + cec_ops_tuner_device_status(&msg, &info);
> + if (!(info.analog.ana_freq < freq))
> + return FAIL;
> + }
> + }
>
> - cec_msg_init(&msg, me, la);
> - cec_msg_tuner_step_decrement(&msg);
> - fail_on_test(!transmit_timeout(node, &msg));
> - if (unrecognized_op(&msg))
> - return NOTSUPPORTED;
> - if (refused(&msg))
> - return REFUSED;
> -
> - return PRESUMED_OK;
> + return 0;
> }
>
> -static int tuner_ctl_step_inc(struct node *node, unsigned me, unsigned la, bool interactive)
> +static int tuner_ctl_analog_step_inc(struct node *node, unsigned me, unsigned la, bool interactive)
> {
> struct cec_msg msg = {};
> + struct cec_op_tuner_device_info info = {};
> + __u16 freq = 0;
> +
> + info.is_analog = true;
> + for (unsigned type = 0; type < 3; type++) {
> + for (unsigned sys = 0; sys < 9; sys++) {
> + cec_msg_init(&msg, me, la);
> + cec_msg_select_analogue_service(&msg, type, 0, sys); // 0 MHz analog frequency
> + fail_on_test(!transmit_timeout(node, &msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_give_tuner_device_status(&msg, true, CEC_OP_STATUS_REQ_ONCE);
> + fail_on_test(!transmit_timeout(node, &msg));
> + fail_on_test(timed_out(&msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
Adding blank lines will improve readability.
> + if (refused(&msg))
> + return REFUSED;
> + cec_ops_tuner_device_status(&msg, &info);
> + freq = info.analog.ana_freq;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_tuner_step_increment(&msg);
> + fail_on_test(!transmit_timeout(node, &msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
Same here.
> + if (refused(&msg))
> + return REFUSED;
> + if (cec_msg_status_is_abort(&msg))
> + return PRESUMED_OK;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_give_tuner_device_status(&msg, true, CEC_OP_STATUS_REQ_ONCE);
> + fail_on_test(!transmit_timeout(node, &msg));
> + fail_on_test(timed_out(&msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
> + cec_ops_tuner_device_status(&msg, &info);
> + if (!(info.analog.ana_freq > freq))
> + return FAIL;
> + }
> + }
>
> - cec_msg_init(&msg, me, la);
> - cec_msg_tuner_step_increment(&msg);
> - fail_on_test(!transmit_timeout(node, &msg));
> - if (unrecognized_op(&msg))
> - return NOTSUPPORTED;
> - if (refused(&msg))
> - return REFUSED;
> -
> - return PRESUMED_OK;
> + return 0;
> }
tuner_ctl_analog_step_inc() and tuner_ctl_analog_step_dec() has lots of
common code. The only real difference is calls to
cec_msg_tuner_step_increment() vs. cec_msg_tuner_step_decrement()
Also the error logic is very hard to read.
>
> static struct remote_subtest tuner_ctl_subtests[] = {
> - { "Give Tuner Device Status", CEC_LOG_ADDR_MASK_TUNER, tuner_ctl_give_status },
> - { "Select Analogue Service", CEC_LOG_ADDR_MASK_TUNER, tuner_ctl_sel_analog_service },
> - { "Select Digital Service", CEC_LOG_ADDR_MASK_TUNER, tuner_ctl_sel_digital_service },
> + { "Give Tuner Device Status", CEC_LOG_ADDR_MASK_TUNER | CEC_LOG_ADDR_MASK_TV, tuner_ctl_analog_give_status },
> + { "Select Analogue Service", CEC_LOG_ADDR_MASK_TUNER | CEC_LOG_ADDR_MASK_TV, tuner_ctl_sel_analog_service },
> + { "Select Digital Service", CEC_LOG_ADDR_MASK_TUNER | CEC_LOG_ADDR_MASK_TV, tuner_ctl_sel_digital_service },
> { "Tuner Device Status", CEC_LOG_ADDR_MASK_ALL, tuner_ctl_tuner_dev_status },
> - { "Tuner Step Decrement", CEC_LOG_ADDR_MASK_TUNER, tuner_ctl_step_dec },
> - { "Tuner Step Increment", CEC_LOG_ADDR_MASK_TUNER, tuner_ctl_step_inc },
> + { "Tuner Analog Step Decrement", CEC_LOG_ADDR_MASK_TUNER | CEC_LOG_ADDR_MASK_TV, tuner_ctl_analog_step_dec },
> + { "Tuner Analog Step Increment", CEC_LOG_ADDR_MASK_TUNER | CEC_LOG_ADDR_MASK_TV, tuner_ctl_analog_step_inc },
> };
>
>
>
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: skhan@linuxfoundation.org (Shuah Khan)
Subject: [Linux-kernel-mentees] [PATCH v2 2/2] cec-compliance: add/refactor tuner control tests
Date: Tue, 24 Sep 2019 13:44:55 -0600 [thread overview]
Message-ID: <d8e866e5-fca2-eed7-5b2f-38bfca380d81@linuxfoundation.org> (raw)
Message-ID: <20190924194455.0OZNoJZGvOpntEUTXnRJ5AMpvyYp1Jwh5N7_PqPMLVc@z> (raw)
In-Reply-To: <20190924192445.93575-3-c0d1n61at3@gmail.com>
On 9/24/19 1:24 PM, Jiunn Chang wrote:
> Tests added/refactored for new features added to the cec-follower.
>
> Analog tuner control tests added/refactored:
> - give analog tuner status
> - select tuner analog service
> - analog tuner step decrement
> - analog tuner step increment
>
> Signed-off-by: Jiunn Chang <c0d1n61at3 at gmail.com>
> ---
> utils/cec-compliance/cec-test.cpp | 181 +++++++++++++++++++++++-------
> 1 file changed, 140 insertions(+), 41 deletions(-)
>
> diff --git a/utils/cec-compliance/cec-test.cpp b/utils/cec-compliance/cec-test.cpp
> index aece546c..91600d39 100644
> --- a/utils/cec-compliance/cec-test.cpp
> +++ b/utils/cec-compliance/cec-test.cpp
> @@ -722,9 +722,19 @@ static struct remote_subtest deck_ctl_subtests[] = {
> TODO: These are very rudimentary tests which should be expanded.
> */
>
> -static int tuner_ctl_give_status(struct node *node, unsigned me, unsigned la, bool interactive)
> +static int tuner_ctl_analog_give_status(struct node *node, unsigned me, unsigned la, bool interactive)
> {
> struct cec_msg msg = {};
> + struct cec_op_tuner_device_info info = {};
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_select_analogue_service(&msg, CEC_OP_ANA_BCAST_TYPE_CABLE,
> + 7668, CEC_OP_BCAST_SYSTEM_PAL_BG); // 479.25 MHz analog frequency
> + fail_on_test(!transmit_timeout(node, &msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
>
> cec_msg_init(&msg, me, la);
> cec_msg_give_tuner_device_status(&msg, true, CEC_OP_STATUS_REQ_ONCE);
> @@ -737,6 +747,14 @@ static int tuner_ctl_give_status(struct node *node, unsigned me, unsigned la, bo
> if (cec_msg_status_is_abort(&msg))
> return PRESUMED_OK;
>
> + cec_ops_tuner_device_status(&msg, &info);
> + if (info.analog.ana_bcast_type != CEC_OP_ANA_BCAST_TYPE_CABLE)
> + return FAIL;
> + if (info.analog.ana_freq != 7668)
> + return FAIL;
> + if (info.analog.bcast_system != CEC_OP_BCAST_SYSTEM_PAL_BG)
> + return FAIL;
> +
Why not combine these conditionals in to one. Why do you need 3 separate
blocks?
> return 0;
> }
>
> @@ -745,23 +763,24 @@ static int tuner_ctl_sel_analog_service(struct node *node, unsigned me, unsigned
> struct cec_msg msg = {};
>
> node->remote[la].bcast_sys = ~0;
> - for (unsigned sys = 0; sys <= 8; sys++) {
> - cec_msg_init(&msg, me, la);
> - cec_msg_select_analogue_service(&msg, CEC_OP_ANA_BCAST_TYPE_CABLE,
> - 7668, sys); // 479.25 MHz analog frequency
> - fail_on_test(!transmit_timeout(node, &msg));
> - if (unrecognized_op(&msg))
> - return NOTSUPPORTED;
> - if (abort_reason(&msg) == CEC_OP_ABORT_INVALID_OP) {
> - info("Tuner supports %s, but cannot select that service.\n",
> - bcast_system2s(sys));
> + for (unsigned type = 0; type < 3; type++) {
> + for (unsigned sys = 0; sys < 9; sys++) {
> + cec_msg_init(&msg, me, la);
> + cec_msg_select_analogue_service(&msg, type, 7668, sys); // 479.25 MHz analog frequency
> + fail_on_test(!transmit_timeout(node, &msg));
Adding line here will help readability.
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
Same here.
> + if (abort_reason(&msg) == CEC_OP_ABORT_INVALID_OP) {
> + info("Tuner supports %s, but cannot select that service.\n",
> + bcast_system2s(sys));
> + node->remote[la].bcast_sys = sys;
> + continue;
> + }
same here.
> + if (cec_msg_status_is_abort(&msg))
> + continue;
> + info("Tuner supports %s\n", bcast_system2s(sys));
> node->remote[la].bcast_sys = sys;
> - continue;
> }
> - if (cec_msg_status_is_abort(&msg))
> - continue;
> - info("Tuner supports %s\n", bcast_system2s(sys));
> - node->remote[la].bcast_sys = sys;
> }
>
> if (node->remote[la].bcast_sys == (__u8)~0)
> @@ -854,43 +873,123 @@ static int tuner_ctl_tuner_dev_status(struct node *node, unsigned me, unsigned l
> return 0;
> }
>
> -static int tuner_ctl_step_dec(struct node *node, unsigned me, unsigned la, bool interactive)
> +static int tuner_ctl_analog_step_dec(struct node *node, unsigned me, unsigned la, bool interactive)
> {
> struct cec_msg msg = {};
> + struct cec_op_tuner_device_info info = {};
> + __u16 freq = 0;
> +
> + info.is_analog = true;
> + for (unsigned type = 0; type < 3; type++) {
> + for (unsigned sys = 0; sys < 9; sys++) {
> + cec_msg_init(&msg, me, la);
> + cec_msg_select_analogue_service(&msg, type, 16000, sys); // 1000 MHz analog frequency
> + fail_on_test(!transmit_timeout(node, &msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_give_tuner_device_status(&msg, true, CEC_OP_STATUS_REQ_ONCE);
> + fail_on_test(!transmit_timeout(node, &msg));
> + fail_on_test(timed_out(&msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
Add a goto NOTSUPPORTED; Makes it easier.
You can simplify this logic a lot.
> + if (refused(&msg))
> + return REFUSED;
> + cec_ops_tuner_device_status(&msg, &info);
> + freq = info.analog.ana_freq;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_tuner_step_decrement(&msg);
> + fail_on_test(!transmit_timeout(node, &msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
> + if (cec_msg_status_is_abort(&msg))
> + return PRESUMED_OK;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_give_tuner_device_status(&msg, true, CEC_OP_STATUS_REQ_ONCE);
> + fail_on_test(!transmit_timeout(node, &msg));
> + fail_on_test(timed_out(&msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
> + cec_ops_tuner_device_status(&msg, &info);
> + if (!(info.analog.ana_freq < freq))
> + return FAIL;
> + }
> + }
>
> - cec_msg_init(&msg, me, la);
> - cec_msg_tuner_step_decrement(&msg);
> - fail_on_test(!transmit_timeout(node, &msg));
> - if (unrecognized_op(&msg))
> - return NOTSUPPORTED;
> - if (refused(&msg))
> - return REFUSED;
> -
> - return PRESUMED_OK;
> + return 0;
> }
>
> -static int tuner_ctl_step_inc(struct node *node, unsigned me, unsigned la, bool interactive)
> +static int tuner_ctl_analog_step_inc(struct node *node, unsigned me, unsigned la, bool interactive)
> {
> struct cec_msg msg = {};
> + struct cec_op_tuner_device_info info = {};
> + __u16 freq = 0;
> +
> + info.is_analog = true;
> + for (unsigned type = 0; type < 3; type++) {
> + for (unsigned sys = 0; sys < 9; sys++) {
> + cec_msg_init(&msg, me, la);
> + cec_msg_select_analogue_service(&msg, type, 0, sys); // 0 MHz analog frequency
> + fail_on_test(!transmit_timeout(node, &msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_give_tuner_device_status(&msg, true, CEC_OP_STATUS_REQ_ONCE);
> + fail_on_test(!transmit_timeout(node, &msg));
> + fail_on_test(timed_out(&msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
Adding blank lines will improve readability.
> + if (refused(&msg))
> + return REFUSED;
> + cec_ops_tuner_device_status(&msg, &info);
> + freq = info.analog.ana_freq;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_tuner_step_increment(&msg);
> + fail_on_test(!transmit_timeout(node, &msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
Same here.
> + if (refused(&msg))
> + return REFUSED;
> + if (cec_msg_status_is_abort(&msg))
> + return PRESUMED_OK;
> +
> + cec_msg_init(&msg, me, la);
> + cec_msg_give_tuner_device_status(&msg, true, CEC_OP_STATUS_REQ_ONCE);
> + fail_on_test(!transmit_timeout(node, &msg));
> + fail_on_test(timed_out(&msg));
> + if (unrecognized_op(&msg))
> + return NOTSUPPORTED;
> + if (refused(&msg))
> + return REFUSED;
> + cec_ops_tuner_device_status(&msg, &info);
> + if (!(info.analog.ana_freq > freq))
> + return FAIL;
> + }
> + }
>
> - cec_msg_init(&msg, me, la);
> - cec_msg_tuner_step_increment(&msg);
> - fail_on_test(!transmit_timeout(node, &msg));
> - if (unrecognized_op(&msg))
> - return NOTSUPPORTED;
> - if (refused(&msg))
> - return REFUSED;
> -
> - return PRESUMED_OK;
> + return 0;
> }
tuner_ctl_analog_step_inc() and tuner_ctl_analog_step_dec() has lots of
common code. The only real difference is calls to
cec_msg_tuner_step_increment() vs. cec_msg_tuner_step_decrement()
Also the error logic is very hard to read.
>
> static struct remote_subtest tuner_ctl_subtests[] = {
> - { "Give Tuner Device Status", CEC_LOG_ADDR_MASK_TUNER, tuner_ctl_give_status },
> - { "Select Analogue Service", CEC_LOG_ADDR_MASK_TUNER, tuner_ctl_sel_analog_service },
> - { "Select Digital Service", CEC_LOG_ADDR_MASK_TUNER, tuner_ctl_sel_digital_service },
> + { "Give Tuner Device Status", CEC_LOG_ADDR_MASK_TUNER | CEC_LOG_ADDR_MASK_TV, tuner_ctl_analog_give_status },
> + { "Select Analogue Service", CEC_LOG_ADDR_MASK_TUNER | CEC_LOG_ADDR_MASK_TV, tuner_ctl_sel_analog_service },
> + { "Select Digital Service", CEC_LOG_ADDR_MASK_TUNER | CEC_LOG_ADDR_MASK_TV, tuner_ctl_sel_digital_service },
> { "Tuner Device Status", CEC_LOG_ADDR_MASK_ALL, tuner_ctl_tuner_dev_status },
> - { "Tuner Step Decrement", CEC_LOG_ADDR_MASK_TUNER, tuner_ctl_step_dec },
> - { "Tuner Step Increment", CEC_LOG_ADDR_MASK_TUNER, tuner_ctl_step_inc },
> + { "Tuner Analog Step Decrement", CEC_LOG_ADDR_MASK_TUNER | CEC_LOG_ADDR_MASK_TV, tuner_ctl_analog_step_dec },
> + { "Tuner Analog Step Increment", CEC_LOG_ADDR_MASK_TUNER | CEC_LOG_ADDR_MASK_TV, tuner_ctl_analog_step_inc },
> };
>
>
>
thanks,
-- Shuah
next prev parent reply other threads:[~2019-09-24 19:44 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 14:17 [Linux-kernel-mentees] [PATCH 0/2] cec-compliance: tuner control c0d1n61at3
2019-09-24 14:17 ` Jiunn Chang
2019-09-24 14:17 ` [Linux-kernel-mentees] [PATCH 1/2] cec-follower: add tuner step increment/decrement c0d1n61at3
2019-09-24 14:17 ` Jiunn Chang
2019-09-24 15:20 ` hverkuil
2019-09-24 15:20 ` Hans Verkuil
2019-09-24 14:17 ` [Linux-kernel-mentees] [PATCH 2/2] cec-compliance: add/refactor tuner control tests c0d1n61at3
2019-09-24 14:17 ` Jiunn Chang
2019-09-24 19:24 ` [Linux-kernel-mentees] [PATCH v2 0/2] cec-compliance: tuner control c0d1n61at3
2019-09-24 19:24 ` Jiunn Chang
2019-09-30 4:30 ` [Linux-kernel-mentees] [PATCH v3 0/3] " c0d1n61at3
2019-09-30 4:30 ` Jiunn Chang
2019-10-01 3:18 ` [Linux-kernel-mentees] [PATCH v4 " c0d1n61at3
2019-10-01 3:18 ` Jiunn Chang
2019-10-03 3:18 ` [Linux-kernel-mentees] [PATCH v5 0/2] " c0d1n61at3
2019-10-03 3:18 ` Jiunn Chang
2019-10-04 4:05 ` [Linux-kernel-mentees] [PATCH v6 0/1] " c0d1n61at3
2019-10-04 4:05 ` Jiunn Chang
2019-10-04 4:05 ` [Linux-kernel-mentees] [PATCH v6 1/1] Add test for new features in cec-follower c0d1n61at3
2019-10-04 4:05 ` Jiunn Chang
2019-10-03 3:18 ` [Linux-kernel-mentees] [PATCH v5 1/2] cec-follower: add tuner step increment/decrement c0d1n61at3
2019-10-03 3:18 ` Jiunn Chang
2019-10-03 3:18 ` [Linux-kernel-mentees] [PATCH v5 2/2] Add test for new features in cec-follower c0d1n61at3
2019-10-03 3:18 ` Jiunn Chang
2019-10-03 6:51 ` hverkuil
2019-10-03 6:51 ` Hans Verkuil
2019-10-01 3:18 ` [Linux-kernel-mentees] [PATCH v4 1/3] cec-follower: fix bugs for tuner emulation c0d1n61at3
2019-10-01 3:18 ` Jiunn Chang
2019-10-01 3:18 ` [Linux-kernel-mentees] [PATCH v4 2/3] cec-follower: add tuner step increment/decrement c0d1n61at3
2019-10-01 3:18 ` Jiunn Chang
2019-10-01 7:12 ` hverkuil
2019-10-01 7:12 ` Hans Verkuil
2019-10-01 3:18 ` [Linux-kernel-mentees] [PATCH v4 3/3] cec-compliance: add tuner control test c0d1n61at3
2019-10-01 3:18 ` Jiunn Chang
2019-10-01 7:51 ` hverkuil
2019-10-01 7:51 ` Hans Verkuil
2019-09-30 4:30 ` [Linux-kernel-mentees] [PATCH v3 1/3] cec-follower: fix bugs for tuner emulation c0d1n61at3
2019-09-30 4:30 ` Jiunn Chang
2019-09-30 9:12 ` hverkuil
2019-09-30 9:12 ` Hans Verkuil
2019-09-30 4:30 ` [Linux-kernel-mentees] [PATCH v3 2/3] cec-follower: add tuner step increment/decrement c0d1n61at3
2019-09-30 4:30 ` Jiunn Chang
2019-09-30 9:35 ` hverkuil
2019-09-30 9:35 ` Hans Verkuil
2019-09-30 4:30 ` [Linux-kernel-mentees] [PATCH v3 3/3] cec-compliance: refactor tuner control tests c0d1n61at3
2019-09-30 4:30 ` Jiunn Chang
2019-09-30 9:43 ` hverkuil
2019-09-30 9:43 ` Hans Verkuil
2019-09-24 19:24 ` [Linux-kernel-mentees] [PATCH v2 1/2] cec-follower: add tuner step increment/decrement c0d1n61at3
2019-09-24 19:24 ` Jiunn Chang
2019-09-24 19:31 ` skhan
2019-09-24 19:31 ` Shuah Khan
2019-09-25 6:54 ` hverkuil
2019-09-25 6:54 ` Hans Verkuil
2019-09-25 7:12 ` hverkuil
2019-09-25 7:12 ` Hans Verkuil
2019-09-24 19:24 ` [Linux-kernel-mentees] [PATCH v2 2/2] cec-compliance: add/refactor tuner control tests c0d1n61at3
2019-09-24 19:24 ` Jiunn Chang
2019-09-24 19:44 ` skhan [this message]
2019-09-24 19:44 ` Shuah Khan
2019-09-25 7:22 ` hverkuil
2019-09-25 7:22 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8e866e5-fca2-eed7-5b2f-38bfca380d81@linuxfoundation.org \
--to=linux-kernel-mentees@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).