From: huw at codeweavers.com (Huw Davies)
Subject: [PATCH v6 01/19] kernel: Standardize vdso_datapage
Date: Mon, 10 Jun 2019 18:47:46 +0100 [thread overview]
Message-ID: <20190610174746.GA13224@merlot.physics.ox.ac.uk> (raw)
In-Reply-To: <bb5253b2-623c-c927-27a2-1d3a2990d20f@arm.com>
On Tue, Jun 04, 2019 at 01:05:40PM +0100, Vincenzo Frascino wrote:
> On 31/05/2019 09:16, Arnd Bergmann wrote:
> > On Thu, May 30, 2019 at 4:15 PM Vincenzo Frascino
> > <vincenzo.frascino at arm.com> wrote:
> >
> >> + * vdso_data will be accessed by 64 bit and compat code at the same time
> >> + * so we should be careful before modifying this structure.
> >> + */
> >> +struct vdso_data {
> >> + u32 seq;
> >> +
> >> + s32 clock_mode;
> >> + u64 cycle_last;
> >> + u64 mask;
> >> + u32 mult;
> >> + u32 shift;
> >> +
> >> + struct vdso_timestamp basetime[VDSO_BASES];
> >> +
> >> + s32 tz_minuteswest;
> >> + s32 tz_dsttime;
> >> + u32 hrtimer_res;
> >> +};
> >
> > The structure contains four padding bytes at the end, which is
> > something we try to avoid, at least if this ends up being used as
> > an ABI. Maybe add "u32 __unused" at the end?
> >
>
> Agreed, I will fix this in v7.
Note that this is also necessary to ensure that CLOCK_MONOTONIC_RAW
works in the 32-bit vDSO on x86_64 kernels.
Huw.
WARNING: multiple messages have this Message-ID (diff)
From: huw@codeweavers.com (Huw Davies)
Subject: [PATCH v6 01/19] kernel: Standardize vdso_datapage
Date: Mon, 10 Jun 2019 18:47:46 +0100 [thread overview]
Message-ID: <20190610174746.GA13224@merlot.physics.ox.ac.uk> (raw)
Message-ID: <20190610174746.CaTeJU0LXxFgXeqLJLCTOw7Ui1vLWzVYh4benVENBIU@z> (raw)
In-Reply-To: <bb5253b2-623c-c927-27a2-1d3a2990d20f@arm.com>
On Tue, Jun 04, 2019@01:05:40PM +0100, Vincenzo Frascino wrote:
> On 31/05/2019 09:16, Arnd Bergmann wrote:
> > On Thu, May 30, 2019 at 4:15 PM Vincenzo Frascino
> > <vincenzo.frascino@arm.com> wrote:
> >
> >> + * vdso_data will be accessed by 64 bit and compat code at the same time
> >> + * so we should be careful before modifying this structure.
> >> + */
> >> +struct vdso_data {
> >> + u32 seq;
> >> +
> >> + s32 clock_mode;
> >> + u64 cycle_last;
> >> + u64 mask;
> >> + u32 mult;
> >> + u32 shift;
> >> +
> >> + struct vdso_timestamp basetime[VDSO_BASES];
> >> +
> >> + s32 tz_minuteswest;
> >> + s32 tz_dsttime;
> >> + u32 hrtimer_res;
> >> +};
> >
> > The structure contains four padding bytes at the end, which is
> > something we try to avoid, at least if this ends up being used as
> > an ABI. Maybe add "u32 __unused" at the end?
> >
>
> Agreed, I will fix this in v7.
Note that this is also necessary to ensure that CLOCK_MONOTONIC_RAW
works in the 32-bit vDSO on x86_64 kernels.
Huw.
WARNING: multiple messages have this Message-ID (diff)
From: Huw Davies <huw@codeweavers.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch <linux-arch@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mips@vger.kernel.org,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Russell King <linux@armlinux.org.uk>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mark Salyzyn <salyzyn@android.com>,
Peter Collingbourne <pcc@google.com>,
Shuah Khan <shuah@kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v6 01/19] kernel: Standardize vdso_datapage
Date: Mon, 10 Jun 2019 18:47:46 +0100 [thread overview]
Message-ID: <20190610174746.GA13224@merlot.physics.ox.ac.uk> (raw)
Message-ID: <20190610174746.1hrFXAm-lwY3eo7hgcXR3fhNwlCZPMTWWGCbol-tTK0@z> (raw)
In-Reply-To: <bb5253b2-623c-c927-27a2-1d3a2990d20f@arm.com>
On Tue, Jun 04, 2019 at 01:05:40PM +0100, Vincenzo Frascino wrote:
> On 31/05/2019 09:16, Arnd Bergmann wrote:
> > On Thu, May 30, 2019 at 4:15 PM Vincenzo Frascino
> > <vincenzo.frascino@arm.com> wrote:
> >
> >> + * vdso_data will be accessed by 64 bit and compat code at the same time
> >> + * so we should be careful before modifying this structure.
> >> + */
> >> +struct vdso_data {
> >> + u32 seq;
> >> +
> >> + s32 clock_mode;
> >> + u64 cycle_last;
> >> + u64 mask;
> >> + u32 mult;
> >> + u32 shift;
> >> +
> >> + struct vdso_timestamp basetime[VDSO_BASES];
> >> +
> >> + s32 tz_minuteswest;
> >> + s32 tz_dsttime;
> >> + u32 hrtimer_res;
> >> +};
> >
> > The structure contains four padding bytes at the end, which is
> > something we try to avoid, at least if this ends up being used as
> > an ABI. Maybe add "u32 __unused" at the end?
> >
>
> Agreed, I will fix this in v7.
Note that this is also necessary to ensure that CLOCK_MONOTONIC_RAW
works in the 32-bit vDSO on x86_64 kernels.
Huw.
next prev parent reply other threads:[~2019-06-10 17:47 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 14:15 [PATCH v6 00/19] Unify vDSOs across more architectures vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 01/19] kernel: Standardize vdso_datapage vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-31 8:16 ` arnd
2019-05-31 8:16 ` Arnd Bergmann
2019-06-04 12:05 ` vincenzo.frascino
2019-06-04 12:05 ` Vincenzo Frascino
2019-06-10 17:47 ` huw [this message]
2019-06-10 17:47 ` Huw Davies
2019-06-10 17:47 ` Huw Davies
2019-06-10 9:27 ` huw
2019-06-10 9:27 ` Huw Davies
2019-06-10 9:27 ` Huw Davies
2019-06-10 10:17 ` vincenzo.frascino
2019-06-10 10:17 ` Vincenzo Frascino
2019-06-10 10:17 ` Vincenzo Frascino
2019-06-10 10:31 ` huw
2019-06-10 10:31 ` Huw Davies
2019-06-10 10:31 ` Huw Davies
2019-06-10 11:07 ` vincenzo.frascino
2019-06-10 11:07 ` Vincenzo Frascino
2019-06-10 11:07 ` Vincenzo Frascino
2019-06-10 11:37 ` huw
2019-06-10 11:37 ` Huw Davies
2019-06-10 11:37 ` Huw Davies
2019-05-30 14:15 ` [PATCH v6 02/19] kernel: Define gettimeofday vdso common code vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-31 8:19 ` arnd
2019-05-31 8:19 ` Arnd Bergmann
2019-06-04 12:08 ` vincenzo.frascino
2019-06-04 12:08 ` Vincenzo Frascino
2019-06-10 9:31 ` huw
2019-06-10 9:31 ` Huw Davies
2019-06-10 9:31 ` Huw Davies
2019-06-10 10:18 ` vincenzo.frascino
2019-06-10 10:18 ` Vincenzo Frascino
2019-06-10 10:18 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 03/19] kernel: Unify update_vsyscall implementation vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-06-10 9:34 ` huw
2019-06-10 9:34 ` Huw Davies
2019-06-10 9:34 ` Huw Davies
2019-06-10 10:19 ` vincenzo.frascino
2019-06-10 10:19 ` Vincenzo Frascino
2019-06-10 10:19 ` Vincenzo Frascino
2019-06-14 11:10 ` Thomas Gleixner
2019-06-14 12:15 ` Vincenzo Frascino
2019-06-14 12:19 ` Thomas Gleixner
2019-06-14 12:25 ` Vincenzo Frascino
2019-06-14 13:07 ` Thomas Gleixner
2019-05-30 14:15 ` [PATCH v6 04/19] arm64: Substitute gettimeofday with C implementation vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 05/19] arm64: Build vDSO with -ffixed-x18 vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 06/19] arm64: compat: Add missing syscall numbers vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 07/19] arm64: compat: Expose signal related structures vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 08/19] arm64: compat: Generate asm offsets for signals vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 09/19] lib: vdso: Add compat support vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 10/19] arm64: compat: Add vDSO vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 11/19] arm64: Refactor vDSO code vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 12/19] arm64: compat: vDSO setup for compat layer vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 13/19] arm64: elf: vDSO code page discovery vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 14/19] arm64: compat: Get sigreturn trampolines from vDSO vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 15/19] arm64: Add vDSO compat support vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-06-01 9:38 ` catalin.marinas
2019-06-01 9:38 ` Catalin Marinas
2019-06-04 12:10 ` vincenzo.frascino
2019-06-04 12:10 ` Vincenzo Frascino
2019-05-30 14:15 ` [PATCH v6 16/19] arm: Add support for generic vDSO vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-31 8:32 ` arnd
2019-05-31 8:32 ` Arnd Bergmann
2019-05-30 14:15 ` [PATCH v6 17/19] mips: " vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-31 8:34 ` arnd
2019-05-31 8:34 ` Arnd Bergmann
2019-06-03 14:54 ` salyzyn
2019-06-03 14:54 ` Mark Salyzyn
2019-06-03 17:07 ` arnd
2019-06-03 17:07 ` Arnd Bergmann
2019-05-30 14:15 ` [PATCH v6 18/19] x86: " vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-30 15:41 ` mikelley
2019-05-30 15:41 ` Michael Kelley
2019-06-04 12:13 ` vincenzo.frascino
2019-06-04 12:13 ` Vincenzo Frascino
2019-06-14 11:15 ` Thomas Gleixner
2019-06-14 21:17 ` Sasha Levin
2019-06-22 14:46 ` Thomas Gleixner
2019-06-23 19:09 ` Sasha Levin
2019-06-23 21:58 ` Stephen Rothwell
2019-06-24 0:24 ` Sasha Levin
2019-06-24 1:20 ` Stephen Rothwell
2019-06-23 22:12 ` Thomas Gleixner
2019-06-24 0:04 ` Michael Kelley
2019-06-24 0:25 ` Thomas Gleixner
2019-06-28 18:40 ` Michael Kelley
2019-05-30 14:15 ` [PATCH v6 19/19] kselftest: Extend vDSO selftest vincenzo.frascino
2019-05-30 14:15 ` Vincenzo Frascino
2019-05-31 8:53 ` arnd
2019-05-31 8:53 ` Arnd Bergmann
2019-05-31 8:46 ` [PATCH v6 00/19] Unify vDSOs across more architectures arnd
2019-05-31 8:46 ` Arnd Bergmann
2019-06-04 12:04 ` vincenzo.frascino
2019-06-04 12:04 ` Vincenzo Frascino
2019-06-04 12:12 ` arnd
2019-06-04 12:12 ` Arnd Bergmann
2019-06-05 14:32 ` vincenzo.frascino
2019-06-05 14:32 ` Vincenzo Frascino
2019-06-14 12:16 ` Thomas Gleixner
2019-06-14 12:19 ` Vincenzo Frascino
2019-06-20 6:17 ` Shijith Thotton
2019-06-20 8:55 ` Vincenzo Frascino
2019-06-20 16:27 ` Andre Przywara
2019-06-21 9:11 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610174746.GA13224@merlot.physics.ox.ac.uk \
--to=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).