From: arnd at arndb.de (Arnd Bergmann) Subject: [PATCH v6 16/19] arm: Add support for generic vDSO Date: Fri, 31 May 2019 10:32:22 +0200 [thread overview] Message-ID: <CAK8P3a0gKJX0fAdizNoO3r-UzAoN0Nf=gkMmw++wuryjHy3-8w@mail.gmail.com> (raw) In-Reply-To: <20190530141531.43462-17-vincenzo.frascino@arm.com> On Thu, May 30, 2019 at 4:16 PM Vincenzo Frascino <vincenzo.frascino at arm.com> wrote: > diff --git a/arch/arm/include/asm/vdso/gettimeofday.h b/arch/arm/include/asm/vdso/gettimeofday.h > new file mode 100644 > index 000000000000..eeeb319840ba > --- /dev/null > +++ b/arch/arm/include/asm/vdso/gettimeofday.h > @@ -0,0 +1,96 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2018 ARM Limited > + */ > +#ifndef __ASM_VDSO_GETTIMEOFDAY_H > +#define __ASM_VDSO_GETTIMEOFDAY_H > + > +#ifndef __ASSEMBLY__ > + > +#include <asm/barrier.h> > +#include <asm/cp15.h> > +#include <asm/unistd.h> > +#include <uapi/linux/time.h> > + > +#ifndef CONFIG_AEABI > +#error This code depends on AEABI system call conventions > +#endif Instead of an #error here, I would use a Kconfig conditional and make it 'select HAVE_GENERIC_VDSO if AEABI' > diff --git a/arch/arm/vdso/vdso.lds.S b/arch/arm/vdso/vdso.lds.S > index 89ca89f12d23..05581140fd12 100644 > --- a/arch/arm/vdso/vdso.lds.S > +++ b/arch/arm/vdso/vdso.lds.S > @@ -82,6 +82,8 @@ VERSION > global: > __vdso_clock_gettime; > __vdso_gettimeofday; > + __vdso_clock_getres; > + __vdso_clock_gettime64; > local: *; > }; Why are you adding __vdso_clock_getres here? I would probably leave the addition of the new entry point(s) for a separate patch at the end, adding __vdso_clock_gettime64 to all 32-bit ABIs at once, since while that part is a trivial change, it's also user visible and deserves its own changelog text. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann) Subject: [PATCH v6 16/19] arm: Add support for generic vDSO Date: Fri, 31 May 2019 10:32:22 +0200 [thread overview] Message-ID: <CAK8P3a0gKJX0fAdizNoO3r-UzAoN0Nf=gkMmw++wuryjHy3-8w@mail.gmail.com> (raw) Message-ID: <20190531083222.-XRFBZBsUE9syXLgY5jobZI9KE1oEy2MTmSSFCQTTdo@z> (raw) In-Reply-To: <20190530141531.43462-17-vincenzo.frascino@arm.com> On Thu, May 30, 2019 at 4:16 PM Vincenzo Frascino <vincenzo.frascino@arm.com> wrote: > diff --git a/arch/arm/include/asm/vdso/gettimeofday.h b/arch/arm/include/asm/vdso/gettimeofday.h > new file mode 100644 > index 000000000000..eeeb319840ba > --- /dev/null > +++ b/arch/arm/include/asm/vdso/gettimeofday.h > @@ -0,0 +1,96 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2018 ARM Limited > + */ > +#ifndef __ASM_VDSO_GETTIMEOFDAY_H > +#define __ASM_VDSO_GETTIMEOFDAY_H > + > +#ifndef __ASSEMBLY__ > + > +#include <asm/barrier.h> > +#include <asm/cp15.h> > +#include <asm/unistd.h> > +#include <uapi/linux/time.h> > + > +#ifndef CONFIG_AEABI > +#error This code depends on AEABI system call conventions > +#endif Instead of an #error here, I would use a Kconfig conditional and make it 'select HAVE_GENERIC_VDSO if AEABI' > diff --git a/arch/arm/vdso/vdso.lds.S b/arch/arm/vdso/vdso.lds.S > index 89ca89f12d23..05581140fd12 100644 > --- a/arch/arm/vdso/vdso.lds.S > +++ b/arch/arm/vdso/vdso.lds.S > @@ -82,6 +82,8 @@ VERSION > global: > __vdso_clock_gettime; > __vdso_gettimeofday; > + __vdso_clock_getres; > + __vdso_clock_gettime64; > local: *; > }; Why are you adding __vdso_clock_getres here? I would probably leave the addition of the new entry point(s) for a separate patch at the end, adding __vdso_clock_gettime64 to all 32-bit ABIs at once, since while that part is a trivial change, it's also user visible and deserves its own changelog text. Arnd
next prev parent reply other threads:[~2019-05-31 8:32 UTC|newest] Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-30 14:15 [PATCH v6 00/19] Unify vDSOs across more architectures vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 01/19] kernel: Standardize vdso_datapage vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-31 8:16 ` arnd 2019-05-31 8:16 ` Arnd Bergmann 2019-06-04 12:05 ` vincenzo.frascino 2019-06-04 12:05 ` Vincenzo Frascino 2019-06-10 17:47 ` huw 2019-06-10 17:47 ` Huw Davies 2019-06-10 17:47 ` Huw Davies 2019-06-10 9:27 ` huw 2019-06-10 9:27 ` Huw Davies 2019-06-10 9:27 ` Huw Davies 2019-06-10 10:17 ` vincenzo.frascino 2019-06-10 10:17 ` Vincenzo Frascino 2019-06-10 10:17 ` Vincenzo Frascino 2019-06-10 10:31 ` huw 2019-06-10 10:31 ` Huw Davies 2019-06-10 10:31 ` Huw Davies 2019-06-10 11:07 ` vincenzo.frascino 2019-06-10 11:07 ` Vincenzo Frascino 2019-06-10 11:07 ` Vincenzo Frascino 2019-06-10 11:37 ` huw 2019-06-10 11:37 ` Huw Davies 2019-06-10 11:37 ` Huw Davies 2019-05-30 14:15 ` [PATCH v6 02/19] kernel: Define gettimeofday vdso common code vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-31 8:19 ` arnd 2019-05-31 8:19 ` Arnd Bergmann 2019-06-04 12:08 ` vincenzo.frascino 2019-06-04 12:08 ` Vincenzo Frascino 2019-06-10 9:31 ` huw 2019-06-10 9:31 ` Huw Davies 2019-06-10 9:31 ` Huw Davies 2019-06-10 10:18 ` vincenzo.frascino 2019-06-10 10:18 ` Vincenzo Frascino 2019-06-10 10:18 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 03/19] kernel: Unify update_vsyscall implementation vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-06-10 9:34 ` huw 2019-06-10 9:34 ` Huw Davies 2019-06-10 9:34 ` Huw Davies 2019-06-10 10:19 ` vincenzo.frascino 2019-06-10 10:19 ` Vincenzo Frascino 2019-06-10 10:19 ` Vincenzo Frascino 2019-06-14 11:10 ` Thomas Gleixner 2019-06-14 12:15 ` Vincenzo Frascino 2019-06-14 12:19 ` Thomas Gleixner 2019-06-14 12:25 ` Vincenzo Frascino 2019-06-14 13:07 ` Thomas Gleixner 2019-05-30 14:15 ` [PATCH v6 04/19] arm64: Substitute gettimeofday with C implementation vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 05/19] arm64: Build vDSO with -ffixed-x18 vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 06/19] arm64: compat: Add missing syscall numbers vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 07/19] arm64: compat: Expose signal related structures vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 08/19] arm64: compat: Generate asm offsets for signals vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 09/19] lib: vdso: Add compat support vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 10/19] arm64: compat: Add vDSO vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 11/19] arm64: Refactor vDSO code vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 12/19] arm64: compat: vDSO setup for compat layer vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 13/19] arm64: elf: vDSO code page discovery vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 14/19] arm64: compat: Get sigreturn trampolines from vDSO vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 15/19] arm64: Add vDSO compat support vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-06-01 9:38 ` catalin.marinas 2019-06-01 9:38 ` Catalin Marinas 2019-06-04 12:10 ` vincenzo.frascino 2019-06-04 12:10 ` Vincenzo Frascino 2019-05-30 14:15 ` [PATCH v6 16/19] arm: Add support for generic vDSO vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-31 8:32 ` arnd [this message] 2019-05-31 8:32 ` Arnd Bergmann 2019-05-30 14:15 ` [PATCH v6 17/19] mips: " vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-31 8:34 ` arnd 2019-05-31 8:34 ` Arnd Bergmann 2019-06-03 14:54 ` salyzyn 2019-06-03 14:54 ` Mark Salyzyn 2019-06-03 17:07 ` arnd 2019-06-03 17:07 ` Arnd Bergmann 2019-05-30 14:15 ` [PATCH v6 18/19] x86: " vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-30 15:41 ` mikelley 2019-05-30 15:41 ` Michael Kelley 2019-06-04 12:13 ` vincenzo.frascino 2019-06-04 12:13 ` Vincenzo Frascino 2019-06-14 11:15 ` Thomas Gleixner 2019-06-14 21:17 ` Sasha Levin 2019-06-22 14:46 ` Thomas Gleixner 2019-06-23 19:09 ` Sasha Levin 2019-06-23 21:58 ` Stephen Rothwell 2019-06-24 0:24 ` Sasha Levin 2019-06-24 1:20 ` Stephen Rothwell 2019-06-23 22:12 ` Thomas Gleixner 2019-06-24 0:04 ` Michael Kelley 2019-06-24 0:25 ` Thomas Gleixner 2019-06-28 18:40 ` Michael Kelley 2019-05-30 14:15 ` [PATCH v6 19/19] kselftest: Extend vDSO selftest vincenzo.frascino 2019-05-30 14:15 ` Vincenzo Frascino 2019-05-31 8:53 ` arnd 2019-05-31 8:53 ` Arnd Bergmann 2019-05-31 8:46 ` [PATCH v6 00/19] Unify vDSOs across more architectures arnd 2019-05-31 8:46 ` Arnd Bergmann 2019-06-04 12:04 ` vincenzo.frascino 2019-06-04 12:04 ` Vincenzo Frascino 2019-06-04 12:12 ` arnd 2019-06-04 12:12 ` Arnd Bergmann 2019-06-05 14:32 ` vincenzo.frascino 2019-06-05 14:32 ` Vincenzo Frascino 2019-06-14 12:16 ` Thomas Gleixner 2019-06-14 12:19 ` Vincenzo Frascino 2019-06-20 6:17 ` Shijith Thotton 2019-06-20 8:55 ` Vincenzo Frascino 2019-06-20 16:27 ` Andre Przywara 2019-06-21 9:11 ` Vincenzo Frascino
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK8P3a0gKJX0fAdizNoO3r-UzAoN0Nf=gkMmw++wuryjHy3-8w@mail.gmail.com' \ --to=linux-kselftest@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).