From: Jean-Jacques Hiblot <jjhiblot@ti.com> To: jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, tomi.valkeinen@ti.com, Jean-Jacques Hiblot <jjhiblot@ti.com> Subject: [PATCH v2 2/2] leds: tlc591xx: Use the OF version of the LED registration function Date: Mon, 8 Jul 2019 12:06:20 +0200 [thread overview] Message-ID: <20190708100620.22388-3-jjhiblot@ti.com> (raw) In-Reply-To: <20190708100620.22388-1-jjhiblot@ti.com> The driver parses the device-tree to identify which LED should be handled. Since the information about the device node is known at this time, we can provide the LED core with it. It may be useful later. Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com> Acked-by: Pavel Machek <pavel@ucw.cz> --- drivers/leds/leds-tlc591xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c index 3d5a4b92f016..10764a62cb71 100644 --- a/drivers/leds/leds-tlc591xx.c +++ b/drivers/leds/leds-tlc591xx.c @@ -207,7 +207,7 @@ tlc591xx_probe(struct i2c_client *client, led->led_no = reg; led->ldev.brightness_set_blocking = tlc591xx_brightness_set; led->ldev.max_brightness = LED_FULL; - err = devm_led_classdev_register(dev, &led->ldev); + err = devm_of_led_classdev_register(dev, child, &led->ldev); if (err < 0) { dev_err(dev, "couldn't register LED %s\n", led->ldev.name); -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Jacques Hiblot <jjhiblot@ti.com> To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>, <dmurphy@ti.com> Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <tomi.valkeinen@ti.com>, Jean-Jacques Hiblot <jjhiblot@ti.com> Subject: [PATCH v2 2/2] leds: tlc591xx: Use the OF version of the LED registration function Date: Mon, 8 Jul 2019 12:06:20 +0200 [thread overview] Message-ID: <20190708100620.22388-3-jjhiblot@ti.com> (raw) Message-ID: <20190708100620.XFkcrFq0ldwBpTNSogZhqGRawWPCwrSy5kQGWLuZCP4@z> (raw) In-Reply-To: <20190708100620.22388-1-jjhiblot@ti.com> The driver parses the device-tree to identify which LED should be handled. Since the information about the device node is known at this time, we can provide the LED core with it. It may be useful later. Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com> Acked-by: Pavel Machek <pavel@ucw.cz> --- drivers/leds/leds-tlc591xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c index 3d5a4b92f016..10764a62cb71 100644 --- a/drivers/leds/leds-tlc591xx.c +++ b/drivers/leds/leds-tlc591xx.c @@ -207,7 +207,7 @@ tlc591xx_probe(struct i2c_client *client, led->led_no = reg; led->ldev.brightness_set_blocking = tlc591xx_brightness_set; led->ldev.max_brightness = LED_FULL; - err = devm_led_classdev_register(dev, &led->ldev); + err = devm_of_led_classdev_register(dev, child, &led->ldev); if (err < 0) { dev_err(dev, "couldn't register LED %s\n", led->ldev.name); -- 2.17.1
next prev parent reply other threads:[~2019-07-08 10:06 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-08 10:06 [PATCH v2 0/2] leds: tlc591xx: switch to OF and managed API Jean-Jacques Hiblot 2019-07-08 10:06 ` Jean-Jacques Hiblot 2019-07-08 10:06 ` [PATCH v2 1/2] leds: tlc591xx: simplify driver by using the managed led API Jean-Jacques Hiblot 2019-07-08 10:06 ` Jean-Jacques Hiblot 2019-07-08 18:08 ` Dan Murphy 2019-07-08 18:08 ` Dan Murphy 2019-07-10 7:44 ` Jean-Jacques Hiblot 2019-07-10 7:44 ` Jean-Jacques Hiblot 2019-07-08 10:06 ` Jean-Jacques Hiblot [this message] 2019-07-08 10:06 ` [PATCH v2 2/2] leds: tlc591xx: Use the OF version of the LED registration function Jean-Jacques Hiblot 2019-07-31 13:14 ` [PATCH v2 0/2] leds: tlc591xx: switch to OF and managed API Tomi Valkeinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190708100620.22388-3-jjhiblot@ti.com \ --to=jjhiblot@ti.com \ --cc=dmurphy@ti.com \ --cc=jacek.anaszewski@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=pavel@ucw.cz \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).