Re: Applied "regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators" to the regulator tree

["Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>]

Hello Mark,

On Tue, 2019-12-17 at 12:39 +0000, Mark Brown wrote:
> The patch
> 
>    regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators
> 
> has been applied to the regulator tree at

I think you missed the [PATCH v6 08/15] regulator: bd718x7: Split
driver to common and bd718x7 specific parts

which took the functions parsing few rohm specific DT entries out of
bd718x7 driver and exported them for shared use. (Eg, currently the
bd718x7 and this bd71828 driver use same properties and sharing the
property parsing code seems better than dublicating it).

Anyways, this patch breaks the compilation w/o PATCH v6 08/15.

> 
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 74eb5af7295f..56512748a47d 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -194,6 +194,18 @@ config REGULATOR_BD70528
>  	  This driver can also be built as a module. If so, the module
>  	  will be called bd70528-regulator.
>  
> +config REGULATOR_BD71828
> +	tristate "ROHM BD71828 Power Regulator"
> +	depends on MFD_ROHM_BD71828
> +	select REGULATOR_ROHM

I think this was introduced in [PATCH v6 08/15]

> +	help
> +	  This driver supports voltage regulators on ROHM BD71828 PMIC.
> +	  This will enable support for the software controllable buck
> +	  and LDO regulators.

//snip

> diff --git a/drivers/regulator/bd71828-regulator.c
> b/drivers/regulator/bd71828-regulator.c

//snip

> +
> +static int buck_set_hw_dvs_levels(struct device_node *np,
> +				  const struct regulator_desc *desc,
> +				  struct regulator_config *cfg)
> +{
> +	struct bd71828_regulator_data *data;
> +
> +	data = container_of(desc, struct bd71828_regulator_data, desc);
> +
> +	return rohm_regulator_set_dvs_levels(&data->dvs, np, desc, cfg-
> >regmap);

So was this.

Do you think you could also apply the [PATCH v6 08/15] or perhaps drop
this one to avoid breaking the compilation when MFD_ROHM_BD71828 config
option is introduced?


Br,
	Matti