From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"phil.edworthy@renesas.com" <phil.edworthy@renesas.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"dmurphy@ti.com" <dmurphy@ti.com>,
"wsa+renesas@sang-engineering.com"
<wsa+renesas@sang-engineering.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"jacek.anaszewski@gmail.com" <jacek.anaszewski@gmail.com>,
"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"noralf@tronnes.org" <noralf@tronnes.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"sboyd@kernel.org" <sboyd@kernel.org>
Subject: Re: [PATCH v6 09/15] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators
Date: Tue, 17 Dec 2019 09:15:48 +0000 [thread overview]
Message-ID: <f56acdc65ab341f9c4ec0709fbfcc32b9f16d6ae.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20191216145528.GE4161@sirena.org.uk>
Hello Mark,
On Mon, 2019-12-16 at 14:55 +0000, Mark Brown wrote:
> On Wed, Dec 11, 2019 at 11:46:11AM +0200, Matti Vaittinen wrote:
>
> > +static int bd71828_ldo6_get_voltage(struct regulator_dev *rdev)
> > +{
> > + return BD71828_LDO_6_VOLTAGE;
> > +}
> > +
> > +static const struct regulator_ops bd71828_ldo6_ops = {
> > + .enable = regulator_enable_regmap,
> > + .disable = regulator_disable_regmap,
> > + .get_voltage = bd71828_ldo6_get_voltage,
>
> You can just set fixed_uV in the regulator_desc, you don't need a
> get_voltage() operation here. Otherwise this looks good, I'll apply
> it
> and please send an incremental fix for this.
Just to confirm - are you also taking in the
[PATCH v6 08/15] regulator: bd718x7: Split driver to common and bd718x7
specific parts
I think there is a dependency. (I am preparing next version of the
series so I'll drop the already applied patches.)
Br,
Matti Vaittinen
next prev parent reply other threads:[~2019-12-17 9:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 9:33 [PATCH v6 00/15] Support ROHM BD71828 PMIC Matti Vaittinen
2019-12-11 9:35 ` [PATCH v6 01/15] dt-bindings: regulator: Document ROHM BD71282 regulator bindings Matti Vaittinen
2019-12-17 12:39 ` Applied "dt-bindings: regulator: Document ROHM BD71282 regulator bindings" to the regulator tree Mark Brown
2019-12-11 9:36 ` [PATCH v6 02/15] dt-bindings: leds: ROHM BD71282 PMIC LED driver Matti Vaittinen
2019-12-18 18:07 ` Rob Herring
2019-12-11 9:37 ` [PATCH v6 03/15] dt-bindings: mfd: Document ROHM BD71828 bindings Matti Vaittinen
2019-12-18 18:08 ` Rob Herring
2019-12-11 9:39 ` [PATCH v6 04/15] mfd: rohm PMICs - use platform_device_id to match MFD sub-devices Matti Vaittinen
2019-12-16 16:41 ` Lee Jones
2019-12-11 9:42 ` [PATCH v6 05/15] mfd: bd71828: Support ROHM BD71828 PMIC - core Matti Vaittinen
2019-12-16 16:46 ` Lee Jones
2019-12-17 9:39 ` Vaittinen, Matti
2019-12-17 13:54 ` Lee Jones
2019-12-17 14:08 ` gregkh
2019-12-17 14:25 ` Lee Jones
2019-12-11 9:43 ` [PATCH v6 06/15] mfd: input: bd71828: Add power-key support Matti Vaittinen
2019-12-11 9:43 ` [PATCH v6 07/15] clk: bd718x7: Support ROHM BD71828 clk block Matti Vaittinen
2019-12-16 16:47 ` Lee Jones
2019-12-11 9:44 ` [PATCH v6 08/15] regulator: bd718x7: Split driver to common and bd718x7 specific parts Matti Vaittinen
2019-12-18 13:12 ` Mark Brown
2019-12-18 17:27 ` Mark Brown
2019-12-11 9:46 ` [PATCH v6 09/15] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators Matti Vaittinen
2019-12-16 14:55 ` Mark Brown
2019-12-17 6:56 ` Vaittinen, Matti
2019-12-17 9:15 ` Vaittinen, Matti [this message]
2019-12-17 12:39 ` Applied "regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators" to the regulator tree Mark Brown
2019-12-18 8:06 ` Vaittinen, Matti
2019-12-18 13:17 ` Mark Brown
2019-12-18 13:33 ` Vaittinen, Matti
2019-12-18 14:01 ` Vaittinen, Matti
2019-12-18 17:24 ` Mark Brown
2019-12-11 9:47 ` [PATCH v6 10/15] gpio: devres: Add devm_gpiod_get_parent_array Matti Vaittinen
2019-12-16 8:29 ` Linus Walleij
2019-12-16 8:59 ` Vaittinen, Matti
2019-12-16 12:21 ` Linus Walleij
2019-12-11 9:47 ` [PATCH v6 11/15] docs: driver-model: Add missing managed GPIO array get functions Matti Vaittinen
2019-12-16 8:31 ` Linus Walleij
2019-12-11 9:48 ` [PATCH v6 12/15] rtc: bd70528 add BD71828 support Matti Vaittinen
2019-12-11 11:38 ` Alexandre Belloni
2019-12-11 11:48 ` Vaittinen, Matti
2019-12-11 9:49 ` [PATCH v6 13/15] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs Matti Vaittinen
2019-12-16 8:32 ` Linus Walleij
2019-12-11 10:00 ` [PATCH v6 14/15] leds: Add common LED binding parsing support to LED class/core Matti Vaittinen
2019-12-11 10:02 ` [PATCH v6 15/15] led: bd71828: Support LED outputs on ROHM BD71828 PMIC Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f56acdc65ab341f9c4ec0709fbfcc32b9f16d6ae.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=mturquette@baylibre.com \
--cc=noralf@tronnes.org \
--cc=pavel@ucw.cz \
--cc=phil.edworthy@renesas.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).