From: <Eugen.Hristev@microchip.com>
To: <KSloat@aampglobal.com>
Cc: <mchehab@kernel.org>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] media: atmel-isc: Update device tree binding documentation
Date: Fri, 18 Jan 2019 14:39:53 +0000 [thread overview]
Message-ID: <0c000df0-94ec-e8bf-e6b1-1a8a94170181@microchip.com> (raw)
In-Reply-To: <20190118142803.70160-2-ksloat@aampglobal.com>
On 18.01.2019 16:28, Ken Sloat wrote:
> From: Ken Sloat <ksloat@aampglobal.com>
>
> Update device tree binding documentation specifying how to
> enable BT656 with CRC decoding.
>
> Signed-off-by: Ken Sloat <ksloat@aampglobal.com>
> ---
> Changes in v2:
> -Use correct media "bus-type" dt property.
>
> Documentation/devicetree/bindings/media/atmel-isc.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/atmel-isc.txt b/Documentation/devicetree/bindings/media/atmel-isc.txt
> index bbe0e87c6188..2d4378dfd6c8 100644
> --- a/Documentation/devicetree/bindings/media/atmel-isc.txt
> +++ b/Documentation/devicetree/bindings/media/atmel-isc.txt
> @@ -21,6 +21,11 @@ Required properties for ISC:
> - pinctrl-names, pinctrl-0
> Please refer to pinctrl-bindings.txt.
>
> +Optional properties for ISC:
> +- bus-type
> + When set to 6, Bt.656 decoding (embedded sync) with CRC decoding
> + is enabled.
> +
I don't think this patch is required at all actually, the binding
complies to the video-interfaces bus specification which includes the
parallel and bt.656.
Would be worth mentioning below explicitly that parallel and bt.656 are
supported, or added above that also plain parallel bus is supported ?
> ISC supports a single port node with parallel bus. It should contain one
here inside the previous line
> 'port' child node with child 'endpoint' node. Please refer to the bindings
> defined in Documentation/devicetree/bindings/media/video-interfaces.txt.
>
next prev parent reply other threads:[~2019-01-18 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 14:28 [PATCH v2 1/2] media: atmel-isc: Add support for BT656 with CRC decoding Ken Sloat
2019-01-18 14:28 ` [PATCH v2 2/2] media: atmel-isc: Update device tree binding documentation Ken Sloat
2019-01-18 14:39 ` Eugen.Hristev [this message]
2019-01-18 18:05 ` Ken Sloat
2019-01-21 7:43 ` Eugen.Hristev
2019-01-23 12:45 ` Sakari Ailus
2019-01-29 20:22 ` Ken Sloat
2019-01-30 10:51 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c000df0-94ec-e8bf-e6b1-1a8a94170181@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=KSloat@aampglobal.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).