From: Ken Sloat <KSloat@aampglobal.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: "Eugen.Hristev@microchip.com" <Eugen.Hristev@microchip.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"Nicolas.Ferre@microchip.com" <Nicolas.Ferre@microchip.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"Ludovic.Desroches@microchip.com"
<Ludovic.Desroches@microchip.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Ken Sloat <KSloat@aampglobal.com>
Subject: RE: [PATCH v2 2/2] media: atmel-isc: Update device tree binding documentation
Date: Tue, 29 Jan 2019 20:22:48 +0000 [thread overview]
Message-ID: <BL0PR07MB4115CF2CA5F69C3963AC58BBAD970@BL0PR07MB4115.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20190123124538.5vfxhsyl2npy4jnp@valkosipuli.retiisi.org.uk>
> -----Original Message-----
> From: Sakari Ailus <sakari.ailus@iki.fi>
> Sent: Wednesday, January 23, 2019 7:46 AM
> Cc: Eugen.Hristev@microchip.com; mchehab@kernel.org;
> Nicolas.Ferre@microchip.com; alexandre.belloni@bootlin.com;
> Ludovic.Desroches@microchip.com; linux-media@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH v2 2/2] media: atmel-isc: Update device tree binding
> documentation
>
> On Fri, Jan 18, 2019 at 06:05:23PM +0000, Ken Sloat wrote:
> > > -----Original Message-----
> > > From: Eugen.Hristev@xxxxxxxxxxxxx <Eugen.Hristev@xxxxxxxxxxxxx>
> > > Sent: Friday, January 18, 2019 9:40 AM
> > > To: Ken Sloat <KSloat@xxxxxxxxxxxxxx>
> > > Cc: mchehab@xxxxxxxxxx; Nicolas.Ferre@xxxxxxxxxxxxx;
> > > alexandre.belloni@xxxxxxxxxxx; Ludovic.Desroches@xxxxxxxxxxxxx;
> > > linux- media@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> > > Subject: Re: [PATCH v2 2/2] media: atmel-isc: Update device tree
> > > binding documentation
> > >
> > >
> > >
> > > On 18.01.2019 16:28, Ken Sloat wrote:
> > > > From: Ken Sloat <ksloat@xxxxxxxxxxxxxx>
> > > >
> > > > Update device tree binding documentation specifying how to enable
> > > > BT656 with CRC decoding.
> > > >
> > > > Signed-off-by: Ken Sloat <ksloat@xxxxxxxxxxxxxx>
> > > > ---
> > > > Changes in v2:
> > > > -Use correct media "bus-type" dt property.
> > > >
> > > > Documentation/devicetree/bindings/media/atmel-isc.txt | 5 +++++
> > > > 1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/media/atmel-isc.txt
> > > > b/Documentation/devicetree/bindings/media/atmel-isc.txt
> > > > index bbe0e87c6188..2d4378dfd6c8 100644
> > > > --- a/Documentation/devicetree/bindings/media/atmel-isc.txt
> > > > +++ b/Documentation/devicetree/bindings/media/atmel-isc.txt
> > > > @@ -21,6 +21,11 @@ Required properties for ISC:
> > > > - pinctrl-names, pinctrl-0
> > > > Please refer to pinctrl-bindings.txt.
> > > >
> > > > +Optional properties for ISC:
> > > > +- bus-type
> > > > + When set to 6, Bt.656 decoding (embedded sync) with CRC decoding
> > > > + is enabled.
> > > > +
> > >
> > > I don't think this patch is required at all actually, the binding
> > > complies to the video-interfaces bus specification which includes the
> parallel and bt.656.
> > >
> > > Would be worth mentioning below explicitly that parallel and bt.656
> > > are supported, or added above that also plain parallel bus is supported ?
> > >
> > > > ISC supports a single port node with parallel bus. It should
> > > > contain one
> > >
> > > here inside the previous line
> > Hi Eugen,
> >
> > Yes it's true adding new documentation here may be overkill, but yes
> > it should say something (as a user I always find it helpful if the docs are
> more verbose than not).
> >
> > So per your suggestion, how about the simplified:
> > "ISC supports a single port node with parallel bus and optionally Bt.656
> support."
> >
> > and I'll remit the other statements.
>
> Please still include the name of the property, as well as the valid values for it
> (numeric as well as human-readable). The rest of the documentation should
> stay in video-interfaces.txt IMO --- this is documentation for the hardware
> only.
>
> --
> Regards,
>
> Sakari Ailus
Thanks Sakari for the feedback. So my original patch here would be valid as is correct?
Thanks,
Ken Sloat
next prev parent reply other threads:[~2019-01-29 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 14:28 [PATCH v2 1/2] media: atmel-isc: Add support for BT656 with CRC decoding Ken Sloat
2019-01-18 14:28 ` [PATCH v2 2/2] media: atmel-isc: Update device tree binding documentation Ken Sloat
2019-01-18 14:39 ` Eugen.Hristev
2019-01-18 18:05 ` Ken Sloat
2019-01-21 7:43 ` Eugen.Hristev
2019-01-23 12:45 ` Sakari Ailus
2019-01-29 20:22 ` Ken Sloat [this message]
2019-01-30 10:51 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR07MB4115CF2CA5F69C3963AC58BBAD970@BL0PR07MB4115.namprd07.prod.outlook.com \
--to=ksloat@aampglobal.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).