* [PATCH] soc: mediatek: pm-domains: Don't print an error if child domain is deferred
@ 2021-01-13 21:30 Enric Balletbo i Serra
2021-01-14 4:00 ` Hsin-Yi Wang
2021-01-31 14:59 ` Matthias Brugger
0 siblings, 2 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2021-01-13 21:30 UTC (permalink / raw)
To: linux-kernel
Cc: drinkcat, linux-mediatek, hsinyi, matthias.bgg,
Collabora Kernel ML, linux-arm-kernel
Child domains can be deferred by the core because one of its resources
is not available yet, in such case, it will print an error, but
later it will succeed to probe. Fix that using the dev_err_probe()
function so it only prints an error on a real error.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/soc/mediatek/mtk-pm-domains.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c
index ae255aa7b1a9..8055fb019ba6 100644
--- a/drivers/soc/mediatek/mtk-pm-domains.c
+++ b/drivers/soc/mediatek/mtk-pm-domains.c
@@ -480,8 +480,8 @@ static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *paren
child_pd = scpsys_add_one_domain(scpsys, child);
if (IS_ERR(child_pd)) {
- ret = PTR_ERR(child_pd);
- dev_err(scpsys->dev, "%pOF: failed to get child domain id\n", child);
+ dev_err_probe(scpsys->dev, PTR_ERR(child_pd),
+ "%pOF: failed to get child domain id\n", child);
goto err_put_node;
}
--
2.29.2
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: pm-domains: Don't print an error if child domain is deferred
2021-01-13 21:30 [PATCH] soc: mediatek: pm-domains: Don't print an error if child domain is deferred Enric Balletbo i Serra
@ 2021-01-14 4:00 ` Hsin-Yi Wang
2021-01-31 14:59 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Hsin-Yi Wang @ 2021-01-14 4:00 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Nicolas Boichat, lkml, moderated list:ARM/Mediatek SoC support,
Matthias Brugger, Collabora Kernel ML,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Thu, Jan 14, 2021 at 5:30 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Child domains can be deferred by the core because one of its resources
> is not available yet, in such case, it will print an error, but
> later it will succeed to probe. Fix that using the dev_err_probe()
> function so it only prints an error on a real error.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
>
> drivers/soc/mediatek/mtk-pm-domains.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c
> index ae255aa7b1a9..8055fb019ba6 100644
> --- a/drivers/soc/mediatek/mtk-pm-domains.c
> +++ b/drivers/soc/mediatek/mtk-pm-domains.c
> @@ -480,8 +480,8 @@ static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *paren
>
> child_pd = scpsys_add_one_domain(scpsys, child);
> if (IS_ERR(child_pd)) {
> - ret = PTR_ERR(child_pd);
> - dev_err(scpsys->dev, "%pOF: failed to get child domain id\n", child);
> + dev_err_probe(scpsys->dev, PTR_ERR(child_pd),
> + "%pOF: failed to get child domain id\n", child);
> goto err_put_node;
> }
>
> --
> 2.29.2
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: pm-domains: Don't print an error if child domain is deferred
2021-01-13 21:30 [PATCH] soc: mediatek: pm-domains: Don't print an error if child domain is deferred Enric Balletbo i Serra
2021-01-14 4:00 ` Hsin-Yi Wang
@ 2021-01-31 14:59 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2021-01-31 14:59 UTC (permalink / raw)
To: Enric Balletbo i Serra, linux-kernel
Cc: drinkcat, Collabora Kernel ML, linux-mediatek, linux-arm-kernel, hsinyi
On 13/01/2021 22:30, Enric Balletbo i Serra wrote:
> Child domains can be deferred by the core because one of its resources
> is not available yet, in such case, it will print an error, but
> later it will succeed to probe. Fix that using the dev_err_probe()
> function so it only prints an error on a real error.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Applied to v5.11-next/soc
Thanks
> ---
>
> drivers/soc/mediatek/mtk-pm-domains.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c
> index ae255aa7b1a9..8055fb019ba6 100644
> --- a/drivers/soc/mediatek/mtk-pm-domains.c
> +++ b/drivers/soc/mediatek/mtk-pm-domains.c
> @@ -480,8 +480,8 @@ static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *paren
>
> child_pd = scpsys_add_one_domain(scpsys, child);
> if (IS_ERR(child_pd)) {
> - ret = PTR_ERR(child_pd);
> - dev_err(scpsys->dev, "%pOF: failed to get child domain id\n", child);
> + dev_err_probe(scpsys->dev, PTR_ERR(child_pd),
> + "%pOF: failed to get child domain id\n", child);
> goto err_put_node;
> }
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-31 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 21:30 [PATCH] soc: mediatek: pm-domains: Don't print an error if child domain is deferred Enric Balletbo i Serra
2021-01-14 4:00 ` Hsin-Yi Wang
2021-01-31 14:59 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).