From: Uladzislau Rezki <urezki@gmail.com>
To: Baoquan He <bhe@redhat.com>
Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Lorenzo Stoakes <lstoakes@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Dave Chinner <david@fromorbit.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 3/9] mm: vmalloc: Move vmap_init_free_space() down in vmalloc.c
Date: Wed, 6 Sep 2023 18:29:28 +0200 [thread overview]
Message-ID: <ZPio6FIIcqxDMdQq@pc636> (raw)
In-Reply-To: <ZPgTiCoJIjYpN+ak@MiWiFi-R3L-srv>
On Wed, Sep 06, 2023 at 01:52:08PM +0800, Baoquan He wrote:
> On 08/29/23 at 10:11am, Uladzislau Rezki (Sony) wrote:
> > A vmap_init_free_space() is a function that setups a vmap space
> > and is considered as part of initialization phase. Since a main
> > entry which is vmalloc_init(), has been moved down in vmalloc.c
> > it makes sense to follow the pattern.
> >
> > There is no a functional change as a result of this patch.
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> > ---
> > mm/vmalloc.c | 82 ++++++++++++++++++++++++++--------------------------
> > 1 file changed, 41 insertions(+), 41 deletions(-)
> >
> > diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> > index 09e315f8ea34..b7deacca1483 100644
> > --- a/mm/vmalloc.c
> > +++ b/mm/vmalloc.c
> > @@ -2512,47 +2512,6 @@ void __init vm_area_register_early(struct vm_struct *vm, size_t align)
> > kasan_populate_early_vm_area_shadow(vm->addr, vm->size);
> > }
> >
> > -static void vmap_init_free_space(void)
> > -{
> > - unsigned long vmap_start = 1;
> > - const unsigned long vmap_end = ULONG_MAX;
> > - struct vmap_area *busy, *free;
> > -
> > - /*
> > - * B F B B B F
> > - * -|-----|.....|-----|-----|-----|.....|-
> > - * | The KVA space |
> > - * |<--------------------------------->|
> > - */
> > - list_for_each_entry(busy, &vmap_area_list, list) {
> > - if (busy->va_start - vmap_start > 0) {
> > - free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT);
> > - if (!WARN_ON_ONCE(!free)) {
> > - free->va_start = vmap_start;
> > - free->va_end = busy->va_start;
> > -
> > - insert_vmap_area_augment(free, NULL,
> > - &free_vmap_area_root,
> > - &free_vmap_area_list);
> > - }
> > - }
> > -
> > - vmap_start = busy->va_end;
> > - }
> > -
> > - if (vmap_end - vmap_start > 0) {
> > - free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT);
> > - if (!WARN_ON_ONCE(!free)) {
> > - free->va_start = vmap_start;
> > - free->va_end = vmap_end;
> > -
> > - insert_vmap_area_augment(free, NULL,
> > - &free_vmap_area_root,
> > - &free_vmap_area_list);
> > - }
> > - }
> > -}
> > -
> > static inline void setup_vmalloc_vm_locked(struct vm_struct *vm,
> > struct vmap_area *va, unsigned long flags, const void *caller)
> > {
> > @@ -4443,6 +4402,47 @@ module_init(proc_vmalloc_init);
> >
> > #endif
> >
> > +static void vmap_init_free_space(void)
> > +{
> > + unsigned long vmap_start = 1;
> > + const unsigned long vmap_end = ULONG_MAX;
> > + struct vmap_area *busy, *free;
> > +
> > + /*
> > + * B F B B B F
> > + * -|-----|.....|-----|-----|-----|.....|-
> > + * | The KVA space |
> > + * |<--------------------------------->|
> > + */
> > + list_for_each_entry(busy, &vmap_area_list, list) {
> > + if (busy->va_start - vmap_start > 0) {
> > + free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT);
> > + if (!WARN_ON_ONCE(!free)) {
> > + free->va_start = vmap_start;
> > + free->va_end = busy->va_start;
> > +
> > + insert_vmap_area_augment(free, NULL,
> > + &free_vmap_area_root,
> > + &free_vmap_area_list);
> > + }
> > + }
> > +
> > + vmap_start = busy->va_end;
> > + }
> > +
> > + if (vmap_end - vmap_start > 0) {
> > + free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT);
> > + if (!WARN_ON_ONCE(!free)) {
> > + free->va_start = vmap_start;
> > + free->va_end = vmap_end;
> > +
> > + insert_vmap_area_augment(free, NULL,
> > + &free_vmap_area_root,
> > + &free_vmap_area_list);
> > + }
> > + }
> > +}
> > +
> > void __init vmalloc_init(void)
> > {
> > struct vmap_area *va;
> > --
> > 2.30.2
> >
>
> Reviewed-by: Baoquan He <bhe@redhat.com>
>
Thanks!
--
Uladzislau Rezki
next prev parent reply other threads:[~2023-09-06 16:29 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 8:11 [PATCH v2 0/9] Mitigate a vmap lock contention v2 Uladzislau Rezki (Sony)
2023-08-29 8:11 ` [PATCH v2 1/9] mm: vmalloc: Add va_alloc() helper Uladzislau Rezki (Sony)
2023-09-06 5:51 ` Baoquan He
2023-09-06 15:06 ` Uladzislau Rezki
2023-08-29 8:11 ` [PATCH v2 2/9] mm: vmalloc: Rename adjust_va_to_fit_type() function Uladzislau Rezki (Sony)
2023-09-06 5:51 ` Baoquan He
2023-09-06 16:27 ` Uladzislau Rezki
2023-08-29 8:11 ` [PATCH v2 3/9] mm: vmalloc: Move vmap_init_free_space() down in vmalloc.c Uladzislau Rezki (Sony)
2023-09-06 5:52 ` Baoquan He
2023-09-06 16:29 ` Uladzislau Rezki [this message]
2023-08-29 8:11 ` [PATCH v2 4/9] mm: vmalloc: Remove global vmap_area_root rb-tree Uladzislau Rezki (Sony)
2023-08-29 14:30 ` kernel test robot
2023-08-30 14:48 ` Uladzislau Rezki
2023-09-07 2:17 ` Baoquan He
2023-09-07 9:38 ` Baoquan He
2023-09-07 9:40 ` Uladzislau Rezki
2023-09-07 9:39 ` Uladzislau Rezki
2023-09-07 9:58 ` Baoquan He
2023-09-08 1:51 ` HAGIO KAZUHITO(萩尾 一仁)
2023-09-08 4:43 ` Baoquan He
2023-09-08 5:01 ` HAGIO KAZUHITO(萩尾 一仁)
2023-09-08 6:44 ` Baoquan He
2023-09-08 11:25 ` Uladzislau Rezki
2023-09-08 11:38 ` Baoquan He
2023-09-08 13:23 ` Uladzislau Rezki
2023-09-11 2:38 ` Baoquan He
2023-09-11 16:53 ` Uladzislau Rezki
2023-09-12 13:19 ` Baoquan He
2023-08-29 8:11 ` [PATCH v2 5/9] mm: vmalloc: Remove global purge_vmap_area_root rb-tree Uladzislau Rezki (Sony)
2023-09-11 2:57 ` Baoquan He
2023-09-11 17:00 ` Uladzislau Rezki
2023-08-29 8:11 ` [PATCH v2 6/9] mm: vmalloc: Offload free_vmap_area_lock lock Uladzislau Rezki (Sony)
2023-09-06 6:04 ` Baoquan He
2023-09-06 19:16 ` Uladzislau Rezki
2023-09-07 0:06 ` Baoquan He
2023-09-07 9:33 ` Uladzislau Rezki
2023-09-11 3:25 ` Baoquan He
2023-09-11 17:10 ` Uladzislau Rezki
2023-09-12 13:21 ` Baoquan He
2023-08-29 8:11 ` [PATCH v2 7/9] mm: vmalloc: Support multiple nodes in vread_iter Uladzislau Rezki (Sony)
2023-09-11 3:58 ` Baoquan He
2023-09-11 18:16 ` Uladzislau Rezki
2023-09-12 13:42 ` Baoquan He
2023-09-13 15:42 ` Uladzislau Rezki
2023-09-14 3:02 ` Baoquan He
2023-09-14 3:36 ` Baoquan He
2023-09-14 3:38 ` Baoquan He
2023-09-13 10:59 ` Baoquan He
2023-09-13 15:38 ` Uladzislau Rezki
2023-08-29 8:11 ` [PATCH v2 8/9] mm: vmalloc: Support multiple nodes in vmallocinfo Uladzislau Rezki (Sony)
2023-09-15 13:02 ` Baoquan He
2023-09-15 18:32 ` Uladzislau Rezki
2023-08-29 8:11 ` [PATCH v2 9/9] mm: vmalloc: Set nr_nodes/node_size based on CPU-cores Uladzislau Rezki (Sony)
2023-09-15 13:03 ` Baoquan He
2023-09-15 18:31 ` Uladzislau Rezki
2023-08-31 1:15 ` [PATCH v2 0/9] Mitigate a vmap lock contention v2 Baoquan He
2023-08-31 16:26 ` Uladzislau Rezki
2023-09-04 14:55 ` Uladzislau Rezki
2023-09-04 19:53 ` Andrew Morton
2023-09-05 6:53 ` Uladzislau Rezki
2023-09-06 20:04 ` Lorenzo Stoakes
2023-09-07 9:15 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPio6FIIcqxDMdQq@pc636 \
--to=urezki@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=oleksiy.avramchenko@sony.com \
--cc=paulmck@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).