* linux-next: build warning after merge of the netfilter-next tree
@ 2018-01-02 1:14 Stephen Rothwell
2018-01-02 15:30 ` Pablo Neira Ayuso
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2018-01-02 1:14 UTC (permalink / raw)
To: Pablo Neira Ayuso, NetFilter
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi all,
After merging the netfilter-next tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from net/ipv6/af_inet6.c:45:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/route.c:87:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/ip6_input.c:34:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_input.c:145:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_fragment.c:50:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/ip6_output.c:44:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_forward.c:37:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/ndisc.c:74:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_output.c:79:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/raw.c:32:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/xfrm6_state.c:18:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/mcast.c:51:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/xfrm6_input.c:16:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/xfrm6_output.c:17:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/xfrm4_output.c:15:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/raw.c:79:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/xfrm4_input.c:17:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_tunnel_core.c:30:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/sit.c:36:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/icmp.c:78:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/xfrm4_state.c:15:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/igmp.c:102:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/af_inet.c:89:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/ip_tunnel.c:37:0:
include/linux/netfilter_ipv4.h:29:53: warning: 'struct nf_queue_entry' declared inside parameter list
int nf_ip_reroute(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv4.h:29:53: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/ip6_tunnel.c:40:0:
include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
^
include/linux/netfilter_ipv6.h:38:51: warning: its scope is only this definition or declaration, which is probably not what you want
Introduced by commit
9faa679ee7ec ("netfilter: move reroute indirection to struct nf_ipv6_ops")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build warning after merge of the netfilter-next tree
2018-01-02 1:14 linux-next: build warning after merge of the netfilter-next tree Stephen Rothwell
@ 2018-01-02 15:30 ` Pablo Neira Ayuso
0 siblings, 0 replies; 17+ messages in thread
From: Pablo Neira Ayuso @ 2018-01-02 15:30 UTC (permalink / raw)
To: Stephen Rothwell
Cc: NetFilter, Linux-Next Mailing List, Linux Kernel Mailing List
Hi Stephen,
On Tue, Jan 02, 2018 at 12:14:51PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the netfilter-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from net/ipv6/af_inet6.c:45:0:
> include/linux/netfilter_ipv6.h:38:51: warning: 'struct nf_queue_entry' declared inside parameter list
> int (*reroute)(struct sk_buff *skb, const struct nf_queue_entry *entry);
> ^
Arnd sent a fix for this, thanks for reporting!
https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build warning after merge of the netfilter-next tree
@ 2020-03-30 0:26 Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2020-03-30 0:26 UTC (permalink / raw)
To: Pablo Neira Ayuso, NetFilter
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Haishuang Yan
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
Hi all,
After merging the netfilter-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
In file included from net/netfilter/ipvs/ip_vs_core.c:52:
net/netfilter/ipvs/ip_vs_core.c: In function 'ip_vs_in_icmp':
include/net/ip_vs.h:233:4: warning: 'outer_proto' may be used uninitialized in this function [-Wmaybe-uninitialized]
233 | printk(KERN_DEBUG pr_fmt(msg), ##__VA_ARGS__); \
| ^~~~~~
net/netfilter/ipvs/ip_vs_core.c:1666:8: note: 'outer_proto' was declared here
1666 | char *outer_proto;
| ^~~~~~~~~~~
Introduced by commit
73348fed35d0 ("ipvs: optimize tunnel dumps for icmp errors")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build warning after merge of the netfilter-next tree
@ 2018-05-07 0:55 Stephen Rothwell
2018-05-08 0:21 ` Stephen Rothwell
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2018-05-07 0:55 UTC (permalink / raw)
To: Pablo Neira Ayuso, NetFilter
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
Fernando Fernandez Mancera
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
Hi all,
After merging the netfilter-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
./usr/include/linux/netfilter/nf_osf.h:25: found __[us]{8,16,32,64} type without #include <linux/types.h>
Introduced by commit
bfb15f2a95cb ("netfilter: extract Passive OS fingerprint infrastructure from xt_osf")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build warning after merge of the netfilter-next tree
2018-05-07 0:55 Stephen Rothwell
@ 2018-05-08 0:21 ` Stephen Rothwell
2018-05-08 7:17 ` Florian Westphal
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2018-05-08 0:21 UTC (permalink / raw)
To: David Miller
Cc: Pablo Neira Ayuso, NetFilter, Linux-Next Mailing List,
Linux Kernel Mailing List, Fernando Fernandez Mancera
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
Hi all,
On Mon, 7 May 2018 10:55:19 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the netfilter-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> ./usr/include/linux/netfilter/nf_osf.h:25: found __[us]{8,16,32,64} type without #include <linux/types.h>
>
> Introduced by commit
>
> bfb15f2a95cb ("netfilter: extract Passive OS fingerprint infrastructure from xt_osf")
This warning now occurs after the merge of the net-next tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build warning after merge of the netfilter-next tree
2018-05-08 0:21 ` Stephen Rothwell
@ 2018-05-08 7:17 ` Florian Westphal
2018-05-15 10:54 ` Geert Uytterhoeven
0 siblings, 1 reply; 17+ messages in thread
From: Florian Westphal @ 2018-05-08 7:17 UTC (permalink / raw)
To: Stephen Rothwell
Cc: David Miller, Pablo Neira Ayuso, NetFilter,
Linux-Next Mailing List, Linux Kernel Mailing List,
Fernando Fernandez Mancera
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Mon, 7 May 2018 10:55:19 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the netfilter-next tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > ./usr/include/linux/netfilter/nf_osf.h:25: found __[us]{8,16,32,64} type without #include <linux/types.h>
>
> > Introduced by commit
> >
> > bfb15f2a95cb ("netfilter: extract Passive OS fingerprint infrastructure from xt_osf")
I'll send a fix for this, thanks for reporting.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build warning after merge of the netfilter-next tree
2018-05-08 7:17 ` Florian Westphal
@ 2018-05-15 10:54 ` Geert Uytterhoeven
2018-05-15 17:51 ` Florian Westphal
0 siblings, 1 reply; 17+ messages in thread
From: Geert Uytterhoeven @ 2018-05-15 10:54 UTC (permalink / raw)
To: Florian Westphal
Cc: Stephen Rothwell, David Miller, Pablo Neira Ayuso, NetFilter,
Linux-Next Mailing List, Linux Kernel Mailing List,
Fernando Fernandez Mancera
Hi Florian,
On Tue, May 8, 2018 at 9:17 AM, Florian Westphal <fw@strlen.de> wrote:
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> On Mon, 7 May 2018 10:55:19 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> >
>> > After merging the netfilter-next tree, today's linux-next build (x86_64
>> > allmodconfig) produced this warning:
>> >
>> > ./usr/include/linux/netfilter/nf_osf.h:25: found __[us]{8,16,32,64} type without #include <linux/types.h>
>>
>> > Introduced by commit
>> >
>> > bfb15f2a95cb ("netfilter: extract Passive OS fingerprint infrastructure from xt_osf")
>
> I'll send a fix for this, thanks for reporting.
+config NF_OSF
+ tristate 'Passive OS fingerprint infrastructure'
"There is no help available for this option."
Is this meant to be a user-visible symbol?
I noticed it is selected by NETFILTER_XT_MATCH_OSF.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build warning after merge of the netfilter-next tree
2018-05-15 10:54 ` Geert Uytterhoeven
@ 2018-05-15 17:51 ` Florian Westphal
0 siblings, 0 replies; 17+ messages in thread
From: Florian Westphal @ 2018-05-15 17:51 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Florian Westphal, Stephen Rothwell, David Miller,
Pablo Neira Ayuso, NetFilter, Linux-Next Mailing List,
Linux Kernel Mailing List, Fernando Fernandez Mancera
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, May 8, 2018 at 9:17 AM, Florian Westphal <fw@strlen.de> wrote:
> > Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >> On Mon, 7 May 2018 10:55:19 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >> >
> >> > After merging the netfilter-next tree, today's linux-next build (x86_64
> >> > allmodconfig) produced this warning:
> >> >
> >> > ./usr/include/linux/netfilter/nf_osf.h:25: found __[us]{8,16,32,64} type without #include <linux/types.h>
> >>
> >> > Introduced by commit
> >> >
> >> > bfb15f2a95cb ("netfilter: extract Passive OS fingerprint infrastructure from xt_osf")
> >
> > I'll send a fix for this, thanks for reporting.
>
> +config NF_OSF
> + tristate 'Passive OS fingerprint infrastructure'
>
> "There is no help available for this option."
>
> Is this meant to be a user-visible symbol?
No, its not. I can send a patch in case you're too busy, let me know.
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build warning after merge of the netfilter-next tree
@ 2017-11-07 0:02 Stephen Rothwell
2017-11-08 8:00 ` Stephen Rothwell
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2017-11-07 0:02 UTC (permalink / raw)
To: Pablo Neira Ayuso, NetFilter
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Florian Westphal
Hi all,
After merging the netfilter-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
net/netfilter/nf_conntrack_netlink.c:536:15: warning: 'ctnetlink_proto_size' defined but not used [-Wunused-function]
static size_t ctnetlink_proto_size(const struct nf_conn *ct)
^
Introduced by commit
5caaed151a68 ("netfilter: conntrack: don't cache nlattr_tuple_size result in nla_size")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build warning after merge of the netfilter-next tree
2017-11-07 0:02 Stephen Rothwell
@ 2017-11-08 8:00 ` Stephen Rothwell
2017-11-08 23:40 ` Pablo Neira Ayuso
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2017-11-08 8:00 UTC (permalink / raw)
To: David Miller, Networking
Cc: Pablo Neira Ayuso, NetFilter, Linux-Next Mailing List,
Linux Kernel Mailing List, Florian Westphal
Hi Dave,
On Tue, 7 Nov 2017 11:02:48 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the netfilter-next tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> net/netfilter/nf_conntrack_netlink.c:536:15: warning: 'ctnetlink_proto_size' defined but not used [-Wunused-function]
> static size_t ctnetlink_proto_size(const struct nf_conn *ct)
> ^
>
> Introduced by commit
>
> 5caaed151a68 ("netfilter: conntrack: don't cache nlattr_tuple_size result in nla_size")
I assume that this warning will now be in the net-next tree ...
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build warning after merge of the netfilter-next tree
2017-11-08 8:00 ` Stephen Rothwell
@ 2017-11-08 23:40 ` Pablo Neira Ayuso
2017-11-15 22:46 ` Stephen Rothwell
0 siblings, 1 reply; 17+ messages in thread
From: Pablo Neira Ayuso @ 2017-11-08 23:40 UTC (permalink / raw)
To: Stephen Rothwell
Cc: David Miller, Networking, NetFilter, Linux-Next Mailing List,
Linux Kernel Mailing List, Florian Westphal
On Wed, Nov 08, 2017 at 07:00:52PM +1100, Stephen Rothwell wrote:
> Hi Dave,
>
> On Tue, 7 Nov 2017 11:02:48 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the netfilter-next tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > net/netfilter/nf_conntrack_netlink.c:536:15: warning: 'ctnetlink_proto_size' defined but not used [-Wunused-function]
> > static size_t ctnetlink_proto_size(const struct nf_conn *ct)
> > ^
> >
> > Introduced by commit
> >
> > 5caaed151a68 ("netfilter: conntrack: don't cache nlattr_tuple_size result in nla_size")
>
> I assume that this warning will now be in the net-next tree ...
It's my fault, I'll fix this in my next batch, sorry for the inconvenience.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build warning after merge of the netfilter-next tree
2017-11-08 23:40 ` Pablo Neira Ayuso
@ 2017-11-15 22:46 ` Stephen Rothwell
2017-11-16 14:18 ` Pablo Neira Ayuso
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2017-11-15 22:46 UTC (permalink / raw)
To: Pablo Neira Ayuso
Cc: David Miller, Networking, NetFilter, Linux-Next Mailing List,
Linux Kernel Mailing List, Florian Westphal
Hi Pablo,
On Thu, 9 Nov 2017 00:40:14 +0100 Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> On Wed, Nov 08, 2017 at 07:00:52PM +1100, Stephen Rothwell wrote:
> >
> > On Tue, 7 Nov 2017 11:02:48 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > After merging the netfilter-next tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced this warning:
> > >
> > > net/netfilter/nf_conntrack_netlink.c:536:15: warning: 'ctnetlink_proto_size' defined but not used [-Wunused-function]
> > > static size_t ctnetlink_proto_size(const struct nf_conn *ct)
> > > ^
> > >
> > > Introduced by commit
> > >
> > > 5caaed151a68 ("netfilter: conntrack: don't cache nlattr_tuple_size result in nla_size")
> >
> > I assume that this warning will now be in the net-next tree ...
>
> It's my fault, I'll fix this in my next batch, sorry for the inconvenience.
This has now made it into Linus' tree :-(
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build warning after merge of the netfilter-next tree
2017-11-15 22:46 ` Stephen Rothwell
@ 2017-11-16 14:18 ` Pablo Neira Ayuso
2017-11-16 20:46 ` Stephen Rothwell
0 siblings, 1 reply; 17+ messages in thread
From: Pablo Neira Ayuso @ 2017-11-16 14:18 UTC (permalink / raw)
To: Stephen Rothwell
Cc: David Miller, Networking, NetFilter, Linux-Next Mailing List,
Linux Kernel Mailing List, Florian Westphal
On Thu, Nov 16, 2017 at 09:46:17AM +1100, Stephen Rothwell wrote:
> Hi Pablo,
>
> On Thu, 9 Nov 2017 00:40:14 +0100 Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> >
> > On Wed, Nov 08, 2017 at 07:00:52PM +1100, Stephen Rothwell wrote:
> > >
> > > On Tue, 7 Nov 2017 11:02:48 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > >
> > > > After merging the netfilter-next tree, today's linux-next build (powerpc
> > > > ppc64_defconfig) produced this warning:
> > > >
> > > > net/netfilter/nf_conntrack_netlink.c:536:15: warning: 'ctnetlink_proto_size' defined but not used [-Wunused-function]
> > > > static size_t ctnetlink_proto_size(const struct nf_conn *ct)
> > > > ^
> > > >
> > > > Introduced by commit
> > > >
> > > > 5caaed151a68 ("netfilter: conntrack: don't cache nlattr_tuple_size result in nla_size")
> > >
> > > I assume that this warning will now be in the net-next tree ...
> >
> > It's my fault, I'll fix this in my next batch, sorry for the inconvenience.
>
> This has now made it into Linus' tree :-(
The patch is already at davem's tree. It's flying there.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build warning after merge of the netfilter-next tree
2017-11-16 14:18 ` Pablo Neira Ayuso
@ 2017-11-16 20:46 ` Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2017-11-16 20:46 UTC (permalink / raw)
To: Pablo Neira Ayuso
Cc: David Miller, Networking, NetFilter, Linux-Next Mailing List,
Linux Kernel Mailing List, Florian Westphal
Hi Pablo,
On Thu, 16 Nov 2017 15:18:00 +0100 Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>
> The patch is already at davem's tree. It's flying there.
Excellent, thanks.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 17+ messages in thread
* linux-next: build warning after merge of the netfilter-next tree
@ 2017-03-20 0:12 Stephen Rothwell
2017-03-20 7:00 ` Reshetova, Elena
0 siblings, 1 reply; 17+ messages in thread
From: Stephen Rothwell @ 2017-03-20 0:12 UTC (permalink / raw)
To: Pablo Neira Ayuso, NetFilter
Cc: linux-next, linux-kernel, Elena Reshetova, Hans Liljestrand,
Kees Cook, David Windsor
Hi all,
After merging the netfilter-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
net/netfilter/nfnetlink_acct.c: In function 'nfnl_acct_try_del':
net/netfilter/nfnetlink_acct.c:329:15: warning: unused variable 'refcount' [-Wunused-variable]
unsigned int refcount;
^
Introduced by commit
b54ab92b84b6 ("netfilter: refcounter conversions")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: linux-next: build warning after merge of the netfilter-next tree
2017-03-20 0:12 Stephen Rothwell
@ 2017-03-20 7:00 ` Reshetova, Elena
2017-03-20 8:44 ` Stephen Rothwell
0 siblings, 1 reply; 17+ messages in thread
From: Reshetova, Elena @ 2017-03-20 7:00 UTC (permalink / raw)
To: Stephen Rothwell, Pablo Neira Ayuso, NetFilter
Cc: linux-next, linux-kernel, Hans Liljestrand, Kees Cook, David Windsor
> Hi all,
>
> After merging the netfilter-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> net/netfilter/nfnetlink_acct.c: In function 'nfnl_acct_try_del':
> net/netfilter/nfnetlink_acct.c:329:15: warning: unused variable 'refcount' [-
> Wunused-variable]
> unsigned int refcount;
> ^
>
> Introduced by commit
Ups, sorry about this, slipped through. Should I submit a fix or how do you want to handle this?
Best Regards,
Elena.
>
> b54ab92b84b6 ("netfilter: refcounter conversions")
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: linux-next: build warning after merge of the netfilter-next tree
2017-03-20 7:00 ` Reshetova, Elena
@ 2017-03-20 8:44 ` Stephen Rothwell
0 siblings, 0 replies; 17+ messages in thread
From: Stephen Rothwell @ 2017-03-20 8:44 UTC (permalink / raw)
To: Reshetova, Elena
Cc: Pablo Neira Ayuso, NetFilter, linux-next, linux-kernel,
Hans Liljestrand, Kees Cook, David Windsor
Hi Elena,
On Mon, 20 Mar 2017 07:00:13 +0000 "Reshetova, Elena" <elena.reshetova@intel.com> wrote:
>
> > After merging the netfilter-next tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > net/netfilter/nfnetlink_acct.c: In function 'nfnl_acct_try_del':
> > net/netfilter/nfnetlink_acct.c:329:15: warning: unused variable 'refcount' [-
> > Wunused-variable]
> > unsigned int refcount;
> > ^
> >
> > Introduced by commit
>
> Ups, sorry about this, slipped through. Should I submit a fix or how do you want to handle this?
That's up to Pablo, but presumably you should send him a followup patch.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2020-03-30 0:26 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-02 1:14 linux-next: build warning after merge of the netfilter-next tree Stephen Rothwell
2018-01-02 15:30 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2020-03-30 0:26 Stephen Rothwell
2018-05-07 0:55 Stephen Rothwell
2018-05-08 0:21 ` Stephen Rothwell
2018-05-08 7:17 ` Florian Westphal
2018-05-15 10:54 ` Geert Uytterhoeven
2018-05-15 17:51 ` Florian Westphal
2017-11-07 0:02 Stephen Rothwell
2017-11-08 8:00 ` Stephen Rothwell
2017-11-08 23:40 ` Pablo Neira Ayuso
2017-11-15 22:46 ` Stephen Rothwell
2017-11-16 14:18 ` Pablo Neira Ayuso
2017-11-16 20:46 ` Stephen Rothwell
2017-03-20 0:12 Stephen Rothwell
2017-03-20 7:00 ` Reshetova, Elena
2017-03-20 8:44 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).