From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "kishon@ti.com" <kishon@ti.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"vkoul@kernel.org" <vkoul@kernel.org>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"tharvey@gateworks.com" <tharvey@gateworks.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hongxing.zhu@nxp.com" <hongxing.zhu@nxp.com>
Subject: Re: linux-next: build failure after merge of the phy-next tree
Date: Wed, 15 Dec 2021 14:14:30 +0000 [thread overview]
Message-ID: <82dcdd84d9111dcde3fb43504ffec5592e2c8356.camel@toradex.com> (raw)
In-Reply-To: <20211215134915.3622957-1-broonie@kernel.org>
On Wed, 2021-12-15 at 13:49 +0000, broonie@kernel.org wrote:
> Hi all,
>
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
I admit I never tried building any of this as a module. I assume neither did Richard (now on CC) or anybody
else.
> /tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c: In function 'imx8_pcie_phy_init':
> /tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit declaration of function
> 'FIELD_PREP' [-Werror=implicit-function-declaration]
Hm, that should come from include/linux/bitfield.h. However, that seems not explicitly included. Likely, in the
module case it no longer finds it. That's a problem.
> 41 | #define IMX8MM_GPR_PCIE_REF_CLK_EXT FIELD_PREP(IMX8MM_GPR_PCIE_REF_CLK_SEL, 0x2)
> | ^~~~~~~~~~
> /tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c:85:7: note: in expansion of macro
> 'IMX8MM_GPR_PCIE_REF_CLK_EXT'
> 85 | IMX8MM_GPR_PCIE_REF_CLK_EXT :
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 1aa97b002258a190d77 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver")
>
> I have used the phy-next tree from yesterday.
Yes, I also noticed it having been applied there now.
Anyway, let me cook up a fix for this. Thanks for reporting.
next prev parent reply other threads:[~2021-12-15 14:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 13:49 linux-next: build failure after merge of the phy-next tree broonie
2021-12-15 14:14 ` Marcel Ziswiler [this message]
2021-12-15 15:20 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2023-08-18 5:40 Stephen Rothwell
2023-08-22 14:00 ` Vinod Koul
2023-02-13 2:55 Stephen Rothwell
2023-02-13 5:17 ` Vinod Koul
2022-07-07 5:39 Stephen Rothwell
2022-07-07 5:53 ` Vinod Koul
2021-12-24 3:03 Stephen Rothwell
2021-12-24 4:37 ` Vinod Koul
2020-12-01 6:07 Stephen Rothwell
2020-12-01 6:45 ` Sergio Paracuellos
2020-12-01 10:39 ` Vinod Koul
2020-11-17 2:40 Stephen Rothwell
2020-11-17 10:00 ` Vinod Koul
2020-11-18 2:56 ` Stephen Rothwell
2020-11-18 4:23 ` Vinod Koul
2019-08-27 5:50 Stephen Rothwell
2017-03-30 3:47 Stephen Rothwell
2017-03-30 5:39 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82dcdd84d9111dcde3fb43504ffec5592e2c8356.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=broonie@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=tharvey@gateworks.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).