linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the phy-next tree
Date: Tue, 1 Dec 2020 07:45:57 +0100	[thread overview]
Message-ID: <CAMhs-H83LKBgSQ6qGxFFtM2zm4d1KCXzGHrZ8J7w=JGGx=Q3wQ@mail.gmail.com> (raw)
In-Reply-To: <20201201170731.4c93b812@canb.auug.org.au>

Hi Stephen,

On Tue, Dec 1, 2020 at 7:07 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
>    17 | #include <mt7621.h>
>       |          ^~~~~~~~~~
>
> Caused by commit
>
>   d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")

This driver has two includes which are in
"arch/mips/include/asm/mach-ralink" and are directly included in the
driver:
* mt7621.h
* ralink_regs.h

This is because this path is directly included in
arch/mips/ralink/Platform for "ralink":

#
# Ralink SoC common stuff
#
cflags-$(CONFIG_RALINK)     += -I$(srctree)/arch/mips/include/asm/mach-ralink

and this driver directly depends on RALINK or COMPILE_TEST (which
might be the problem here):


and this driver directly depends
on RALINK or COMPILE_TEST:

config PHY_MT7621_PCI
    tristate "MediaTek MT7621 PCI PHY Driver"
    depends on (RALINK || COMPILE_TEST) && OF
    select GENERIC_PHY
    select REGMAP_MMIO
    help
      Say 'Y' here to add support for MediaTek MT7621 PCI PHY driver

>
> I have reverted that commit for today.

What is the correct way of fixing this? Include complete path for both
of them like this?

index db79088d5362..cebd53f5a797 100644
--- a/drivers/phy/ralink/phy-mt7621-pci.c
+++ b/drivers/phy/ralink/phy-mt7621-pci.c
@@ -14,8 +14,8 @@
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/sys_soc.h>
-#include <mt7621.h>
-#include <ralink_regs.h>
+#include <asm/mach-ralink/mt7621.h>
+#include <asm/mach-ralink/ralink_regs.h>

Vinod, please let me know if you want me to send anything for fixing this.

>
> --
> Cheers,
> Stephen Rothwell

Best regards,
    Sergio Paracuellos

  reply	other threads:[~2020-12-01  6:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  6:07 linux-next: build failure after merge of the phy-next tree Stephen Rothwell
2020-12-01  6:45 ` Sergio Paracuellos [this message]
2020-12-01 10:39   ` Vinod Koul
  -- strict thread matches above, loose matches on Subject: below --
2023-08-18  5:40 Stephen Rothwell
2023-08-22 14:00 ` Vinod Koul
2023-02-13  2:55 Stephen Rothwell
2023-02-13  5:17 ` Vinod Koul
2022-07-07  5:39 Stephen Rothwell
2022-07-07  5:53 ` Vinod Koul
2021-12-24  3:03 Stephen Rothwell
2021-12-24  4:37 ` Vinod Koul
2021-12-15 13:49 broonie
2021-12-15 14:14 ` Marcel Ziswiler
2021-12-15 15:20   ` Vinod Koul
2020-11-17  2:40 Stephen Rothwell
2020-11-17 10:00 ` Vinod Koul
2020-11-18  2:56   ` Stephen Rothwell
2020-11-18  4:23     ` Vinod Koul
2019-08-27  5:50 Stephen Rothwell
2017-03-30  3:47 Stephen Rothwell
2017-03-30  5:39 ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMhs-H83LKBgSQ6qGxFFtM2zm4d1KCXzGHrZ8J7w=JGGx=Q3wQ@mail.gmail.com' \
    --to=sergio.paracuellos@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).