From: Vinod Koul <vkoul@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Abel Vesa <abel.vesa@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
kernel test robot <lkp@intel.com>,
Linux Phy <linux-phy@lists.infradead.org>
Subject: Re: linux-next: build failure after merge of the phy-next tree
Date: Mon, 13 Feb 2023 10:47:05 +0530 [thread overview]
Message-ID: <Y+nH0enRX0OO4UtQ@matsya> (raw)
In-Reply-To: <20230213135521.6ebc410b@canb.auug.org.au>
On 13-02-23, 13:55, Stephen Rothwell wrote:
> Hi all,
>
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c: In function 'qcom_snps_eusb2_hsphy_write_mask':
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:147:15: error: implicit declaration of function 'readl_relaxed' [-Werror=implicit-function-declaration]
> 147 | reg = readl_relaxed(base + offset);
> | ^~~~~~~~~~~~~
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:150:9: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
> 150 | writel_relaxed(reg, base + offset);
> | ^~~~~~~~~~~~~~
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c: In function 'qcom_eusb2_default_parameters':
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:161:42: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
> 161 | FIELD_PREP(PHY_CFG_TX_PREEMP_TUNE_MASK, 0));
> | ^~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver")
Thanks Stephen for the report, I have fixed it up by adding the missing
headers:
-- >8 --
From: Vinod Koul <vkoul@kernel.org>
Date: Mon, 13 Feb 2023 10:39:26 +0530
Subject: [PATCH] phy: qcom: snps-eusb2: Add missing headers
The driver was missing to include couple of headers explictly which
causes build to fail on other archs
Fix this by adding bitfield.h and iopoll.h explictly
Fixes: 80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
index 40a421cf3dd9..64e835b7ef53 100644
--- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
@@ -3,8 +3,10 @@
* Copyright (c) 2023, Linaro Limited
*/
+#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/delay.h>
+#include <linux/iopoll.h>
#include <linux/phy/phy.h>
#include <linux/platform_device.h>
#include <linux/regulator/consumer.h>
--
2.39.0
--
~Vinod
next prev parent reply other threads:[~2023-02-13 5:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 2:55 linux-next: build failure after merge of the phy-next tree Stephen Rothwell
2023-02-13 5:17 ` Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-18 5:40 Stephen Rothwell
2023-08-22 14:00 ` Vinod Koul
2022-07-07 5:39 Stephen Rothwell
2022-07-07 5:53 ` Vinod Koul
2021-12-24 3:03 Stephen Rothwell
2021-12-24 4:37 ` Vinod Koul
2021-12-15 13:49 broonie
2021-12-15 14:14 ` Marcel Ziswiler
2021-12-15 15:20 ` Vinod Koul
2020-12-01 6:07 Stephen Rothwell
2020-12-01 6:45 ` Sergio Paracuellos
2020-12-01 10:39 ` Vinod Koul
2020-11-17 2:40 Stephen Rothwell
2020-11-17 10:00 ` Vinod Koul
2020-11-18 2:56 ` Stephen Rothwell
2020-11-18 4:23 ` Vinod Koul
2019-08-27 5:50 Stephen Rothwell
2017-03-30 3:47 Stephen Rothwell
2017-03-30 5:39 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+nH0enRX0OO4UtQ@matsya \
--to=vkoul@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lkp@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).