From: Bjorn Helgaas <helgaas@kernel.org>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org,
broonie@kernel.org, lorenzo.pieralisi@arm.com,
jingoohan1@gmail.com, festevam@gmail.com,
francesco.dolcini@toradex.com, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-imx@nxp.com
Subject: Re: [PATCH v9 2/8] PCI: imx6: Add the error propagation from host_init
Date: Wed, 8 Jun 2022 13:53:13 -0500 [thread overview]
Message-ID: <20220608185313.GA410761@bhelgaas> (raw)
In-Reply-To: <1651801629-30223-3-git-send-email-hongxing.zhu@nxp.com>
On Fri, May 06, 2022 at 09:47:03AM +0800, Richard Zhu wrote:
> Since there is error return check of the host_init callback, add error
> check to imx6_pcie_deassert_core_reset() function, and change the
> function type accordingly.
> @@ -878,11 +879,18 @@ static int imx6_pcie_start_link(struct dw_pcie *pci)
> static int imx6_pcie_host_init(struct pcie_port *pp)
> {
> struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> + struct device *dev = pci->dev;
> struct imx6_pcie *imx6_pcie = to_imx6_pcie(pci);
> + int ret;
>
> imx6_pcie_assert_core_reset(imx6_pcie);
> imx6_pcie_init_phy(imx6_pcie);
> - imx6_pcie_deassert_core_reset(imx6_pcie);
> + ret = imx6_pcie_deassert_core_reset(imx6_pcie);
> + if (ret < 0) {
> + dev_err(dev, "pcie host init failed: %d.\n", ret);
Other messages from this driver do not include a trailing period.
next prev parent reply other threads:[~2022-06-08 18:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 1:47 [PATCH v9 0/8] PCI: imx6: refine codes and add compliance tests mode support Richard Zhu
2022-05-06 1:47 ` [PATCH v9 1/8] PCI: imx6: Encapsulate the clock enable into one standalone function Richard Zhu
2022-06-08 18:51 ` Bjorn Helgaas
2022-06-09 6:18 ` Hongxing Zhu
2022-05-06 1:47 ` [PATCH v9 2/8] PCI: imx6: Add the error propagation from host_init Richard Zhu
2022-06-08 18:53 ` Bjorn Helgaas [this message]
2022-06-09 6:19 ` Hongxing Zhu
2022-05-06 1:47 ` [PATCH v9 3/8] PCI: imx6: Move imx6_pcie_clk_disable() earlier Richard Zhu
2022-06-08 7:14 ` Lucas Stach
2022-05-06 1:47 ` [PATCH v9 4/8] PCI: imx6: Disable iMX6QDL PCIe REF clock when disable PCIe clocks Richard Zhu
2022-06-08 7:18 ` Lucas Stach
2022-05-06 1:47 ` [PATCH v9 5/8] PCI: imx6: Refine the regulator usage Richard Zhu
2022-06-08 7:26 ` Lucas Stach
2022-06-09 6:17 ` Hongxing Zhu
2022-06-09 7:47 ` Lucas Stach
2022-06-09 7:54 ` Hongxing Zhu
2022-06-08 18:54 ` Bjorn Helgaas
2022-06-09 6:19 ` Hongxing Zhu
2022-06-09 17:20 ` Bjorn Helgaas
2022-06-10 7:09 ` Hongxing Zhu
2022-05-06 1:47 ` [PATCH v9 6/8] PCI: imx6: Disable clocks and regulators after link is down Richard Zhu
2022-06-08 7:35 ` Lucas Stach
2022-06-09 6:17 ` Hongxing Zhu
2022-06-09 7:53 ` Francesco Dolcini
2022-06-09 8:36 ` Hongxing Zhu
2022-06-09 7:55 ` Lucas Stach
2022-06-09 8:30 ` Hongxing Zhu
2022-05-06 1:47 ` [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the proper places Richard Zhu
2022-06-08 7:44 ` Lucas Stach
2022-06-09 6:18 ` Hongxing Zhu
2022-06-08 18:57 ` Bjorn Helgaas
2022-06-09 6:20 ` Hongxing Zhu
2022-06-09 16:25 ` Bjorn Helgaas
2022-06-10 6:51 ` Hongxing Zhu
2022-05-06 1:47 ` [PATCH v9 8/8] PCI: imx6: Add compliance tests mode support Richard Zhu
2022-06-08 7:48 ` Lucas Stach
2022-06-09 6:18 ` Hongxing Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608185313.GA410761@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).