linux-pwm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Yash Shah <yash.shah@sifive.com>
Cc: linux-spi@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-pwm@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	broonie@kernel.org, gregkh@linuxfoundation.org,
	aou@eecs.berkeley.edu, lee.jones@linaro.org,
	u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com,
	andrew@lunn.ch, peter@korsgaard.com, paul.walmsley@sifive.com,
	palmer@dabbelt.com, bgolaszewski@baylibre.com,
	linus.walleij@linaro.org
Subject: Re: [PATCH v2 3/9] dt-bindings: pwm: Update DT binding docs to support SiFive FU740 SoC
Date: Wed, 9 Dec 2020 21:56:45 -0600	[thread overview]
Message-ID: <20201210035645.GA1633151@robh.at.kernel.org> (raw)
In-Reply-To: <1607403341-57214-4-git-send-email-yash.shah@sifive.com>

On Tue, Dec 08, 2020 at 10:25:35AM +0530, Yash Shah wrote:
> Add new compatible strings to the DT binding documents to support SiFive
> FU740-C000.
> 
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
> ---
>  Documentation/devicetree/bindings/pwm/pwm-sifive.yaml | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
> index 5ac2527..84e6691 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
> @@ -25,12 +25,15 @@ description:
>  properties:
>    compatible:
>      items:
> -      - const: sifive,fu540-c000-pwm
> +      - enum:
> +          - sifive,fu540-c000-pwm
> +          - sifive,fu740-c000-pwm
>        - const: sifive,pwm0
>      description:
>        Should be "sifive,<chip>-pwm" and "sifive,pwm<version>". Supported
> -      compatible strings are "sifive,fu540-c000-pwm" for the SiFive PWM v0
> -      as integrated onto the SiFive FU540 chip, and "sifive,pwm0" for the
> +      compatible strings are "sifive,fu540-c000-pwm" and
> +      "sifive,fu740-c000-pwm" for the SiFive PWM v0 as integrated onto the
> +      SiFive FU540 and FU740 chip respectively, and "sifive,pwm0" for the

Better if you reword this so we don't have to update it for every new 
compatible.

>        SiFive PWM v0 IP block with no chip integration tweaks.
>        Please refer to sifive-blocks-ip-versioning.txt for details.
>  
> -- 
> 2.7.4
> 

  reply	other threads:[~2020-12-10  4:08 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08  4:55 [PATCH v2 0/9] arch: riscv: add board and SoC DT file support Yash Shah
2020-12-08  4:55 ` [PATCH v2 1/9] dt-bindings: riscv: Update DT binding docs to support SiFive FU740 SoC Yash Shah
2020-12-10  3:55   ` Rob Herring
2020-12-10 13:34   ` Bin Meng
2020-12-08  4:55 ` [PATCH v2 2/9] dt-bindings: spi: " Yash Shah
2020-12-08  4:55 ` [PATCH v2 3/9] dt-bindings: pwm: " Yash Shah
2020-12-10  3:56   ` Rob Herring [this message]
2020-12-08  4:55 ` [PATCH v2 4/9] dt-bindings: serial: " Yash Shah
2020-12-10  3:56   ` Rob Herring
2020-12-08  4:55 ` [PATCH v2 5/9] dt-bindings: gpio: " Yash Shah
2020-12-10  3:57   ` Rob Herring
2020-12-08  4:55 ` [PATCH v2 6/9] dt-bindings: i2c: " Yash Shah
2020-12-10  3:59   ` Rob Herring
2020-12-22  3:23   ` Palmer Dabbelt
2020-12-08  4:55 ` [PATCH v2 7/9] riscv: dts: add initial support for the SiFive FU740-C000 SoC Yash Shah
2020-12-10 13:34   ` Bin Meng
2020-12-16  5:24     ` Yash Shah
2020-12-16  6:06       ` Bin Meng
2020-12-16  6:12         ` Yash Shah
2020-12-08  4:55 ` [PATCH v2 8/9] dt-bindings: riscv: Update YAML doc to support SiFive HiFive Unmatched board Yash Shah
2020-12-10  3:59   ` Rob Herring
2020-12-10 13:34   ` Bin Meng
2020-12-08  4:55 ` [PATCH v2 9/9] riscv: dts: add initial board data for the SiFive HiFive Unmatched Yash Shah
2020-12-10 13:34   ` Bin Meng
2020-12-08 17:11 ` (subset) [PATCH v2 0/9] arch: riscv: add board and SoC DT file support Mark Brown
2020-12-22  4:38 ` Palmer Dabbelt
2021-01-08  3:12 ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210035645.GA1633151@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=aou@eecs.berkeley.edu \
    --cc=bgolaszewski@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=peter@korsgaard.com \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=yash.shah@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).