From: Jason Gunthorpe <jgg@nvidia.com>
To: Chesnokov Gleb <Chesnokov.G@raidix.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
"lanevdenoche@gmail.com" <lanevdenoche@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>
Subject: Re: [PATCH 1/1] iser-target: Fix handling of RDMA_CV_EVENT_ADDR_CHANGE
Date: Wed, 1 Sep 2021 08:56:09 -0300 [thread overview]
Message-ID: <20210901115609.GF1721383@nvidia.com> (raw)
In-Reply-To: <c6827ac071364d488a3115d2cdcbff6e@raidix.com>
On Wed, Sep 01, 2021 at 11:43:34AM +0000, Chesnokov Gleb wrote:
> b) listener cm_id does not need to be recreated,
> that is, RDMA_CM_EVENT_ADDR_CHANGE is informative for it.
I depends on what is in sa = (struct sockaddr *)&np->np_sockaddr;
If that is not a wildcard then the listen is only good so long as that
address the one assigned to the interface.
I'm not sure why isert would use a non-wildcard listen?
In any event if the isert_setup_np() was called with a specific
address:
static int
isert_setup_np(struct iscsi_np *np,
struct sockaddr_storage *ksockaddr)
Then the np should operate on that address, and only that address, and
not quitely change to some other address during operation. So again I
think the original proposal is not right - though I don't know enough
about iscsi insides to suggest what is wrong here.
Jason
prev parent reply other threads:[~2021-09-01 11:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 18:26 [PATCH 1/1] iser-target: Fix handling of RDMA_CV_EVENT_ADDR_CHANGE lanevdenoche
2021-07-18 8:50 ` Leon Romanovsky
[not found] ` <9e97e113abb64952a22430462310ca83@raidix.com>
2021-07-19 6:40 ` Leon Romanovsky
2021-07-19 12:13 ` Jason Gunthorpe
2021-07-19 16:07 ` Chesnokov Gleb
2021-07-19 17:09 ` Jason Gunthorpe
2021-07-19 18:27 ` Sagi Grimberg
2021-07-19 18:29 ` Sagi Grimberg
2021-07-19 20:47 ` Chesnokov Gleb
2021-07-22 14:23 ` Jason Gunthorpe
2021-07-22 19:54 ` Sagi Grimberg
2021-07-27 17:37 ` Jason Gunthorpe
2021-08-06 20:14 ` Sagi Grimberg
2021-08-17 8:30 ` Chesnokov Gleb
2021-08-17 21:27 ` Sagi Grimberg
2021-09-01 11:43 ` Chesnokov Gleb
2021-09-01 11:56 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210901115609.GF1721383@nvidia.com \
--to=jgg@nvidia.com \
--cc=Chesnokov.G@raidix.com \
--cc=dledford@redhat.com \
--cc=lanevdenoche@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).