linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Jason Gunthorpe <jgg@nvidia.com>,
	Chesnokov Gleb <Chesnokov.G@raidix.com>
Cc: "lanevdenoche@gmail.com" <lanevdenoche@gmail.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"dledford@redhat.com" <dledford@redhat.com>
Subject: Re: [PATCH 1/1] iser-target: Fix handling of RDMA_CV_EVENT_ADDR_CHANGE
Date: Mon, 19 Jul 2021 11:27:11 -0700	[thread overview]
Message-ID: <e5e62cc4-500a-6e7b-8bea-9f86bd9c4d77@grimberg.me> (raw)
In-Reply-To: <20210719170911.GS543781@nvidia.com>


>> The iSCSI socket address does not change.  But the cma_id at the IB
>> layer, which is bound to the iSCSI socket, will change.  The problem
>> is that the new cma_id is trying to bind to a socket address that is
>> still bound to the old cma_id.  That is, before you bind a new
>> cma_id to a socket, you must first delete the old one.
> 
> So why is iser trying to rebind a listening socket to the same
> address? Isn't that the bug here? Just don't do that.

Hey Json,

Yes it is broken, IIRC it was meant to try and handle cases
where the address was restroed, but that needs to do is a periodic
attempt to repair (as bind is expected to fail). Similar to how
nvmet-rdma does this.

(I also have some vague memory that some bonding events mapped to this
cma event although the address was still available but that was a long
time ago so I'm not sure, and the change log says nothing about it...)

  reply	other threads:[~2021-07-19 20:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 18:26 [PATCH 1/1] iser-target: Fix handling of RDMA_CV_EVENT_ADDR_CHANGE lanevdenoche
2021-07-18  8:50 ` Leon Romanovsky
     [not found]   ` <9e97e113abb64952a22430462310ca83@raidix.com>
2021-07-19  6:40     ` Leon Romanovsky
2021-07-19 12:13 ` Jason Gunthorpe
2021-07-19 16:07   ` Chesnokov Gleb
2021-07-19 17:09     ` Jason Gunthorpe
2021-07-19 18:27       ` Sagi Grimberg [this message]
2021-07-19 18:29     ` Sagi Grimberg
2021-07-19 20:47       ` Chesnokov Gleb
2021-07-22 14:23       ` Jason Gunthorpe
2021-07-22 19:54         ` Sagi Grimberg
2021-07-27 17:37           ` Jason Gunthorpe
2021-08-06 20:14             ` Sagi Grimberg
2021-08-17  8:30               ` Chesnokov Gleb
2021-08-17 21:27                 ` Sagi Grimberg
2021-09-01 11:43                   ` Chesnokov Gleb
2021-09-01 11:56                     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5e62cc4-500a-6e7b-8bea-9f86bd9c4d77@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=Chesnokov.G@raidix.com \
    --cc=dledford@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=lanevdenoche@gmail.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).