From: Sagi Grimberg <sagi@grimberg.me>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Chesnokov Gleb <Chesnokov.G@raidix.com>,
"lanevdenoche@gmail.com" <lanevdenoche@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>
Subject: Re: [PATCH 1/1] iser-target: Fix handling of RDMA_CV_EVENT_ADDR_CHANGE
Date: Fri, 6 Aug 2021 13:14:35 -0700 [thread overview]
Message-ID: <4e31b660-822a-5bc9-26e3-76046049695a@grimberg.me> (raw)
In-Reply-To: <20210727173709.GH1721383@nvidia.com>
>>>>>> What is this trying to do anyhow? If the addr has truely changed why
>>>>>> does the bind fail?
>>>>>
>>>>> When the active physical link member of bonding interface in active-standby
>>>>> mode gets faulty, the standby link will represent the assigned addresses on
>>>>> behalf of the active link.
>>>>> Therefore, RDMA communication manager will notify iSER target with
>>>>> RDMA_CM_EVENT_ADDR_CHANGE.
>>>>
>>>> Ah, here is my recollection...
>>>>
>>>> However I think that if we move that into a work, we should do it
>>>> periodically until we succeed or until the endpoint is torn down so
>>>> we can handle address removed and restore use-cases.
>>>
>>> That soudns better, but still I would say this shouldn't even happen
>>> in the first place, check the address and don't initiate rebinding if
>>> it hasn't changed.
>>
>> But don't you need to setup a new cm_id for the this notification? It
>> will remain active?
>
> AFAIK the existing listening ID remains, the notification is
> informative, it doesn't indicate any CM state has changed.
Gleb, can you confirm that?
>> Also it's a bit cumbersome to match addresses in some cases like multi
>> address interfaces. Almost seems easier to setup a new one...
>
> How so? There is only one address passed to bind. If you create
> multiple CM ids to cover all addresses then you need to run a set
> algorithm to figure out what cm_ids to destroy and which to
> create.
There is one address passed to bind, but I need to check that this
address belongs to the interface, which is what bind does anyways..
next prev parent reply other threads:[~2021-08-06 20:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 18:26 [PATCH 1/1] iser-target: Fix handling of RDMA_CV_EVENT_ADDR_CHANGE lanevdenoche
2021-07-18 8:50 ` Leon Romanovsky
[not found] ` <9e97e113abb64952a22430462310ca83@raidix.com>
2021-07-19 6:40 ` Leon Romanovsky
2021-07-19 12:13 ` Jason Gunthorpe
2021-07-19 16:07 ` Chesnokov Gleb
2021-07-19 17:09 ` Jason Gunthorpe
2021-07-19 18:27 ` Sagi Grimberg
2021-07-19 18:29 ` Sagi Grimberg
2021-07-19 20:47 ` Chesnokov Gleb
2021-07-22 14:23 ` Jason Gunthorpe
2021-07-22 19:54 ` Sagi Grimberg
2021-07-27 17:37 ` Jason Gunthorpe
2021-08-06 20:14 ` Sagi Grimberg [this message]
2021-08-17 8:30 ` Chesnokov Gleb
2021-08-17 21:27 ` Sagi Grimberg
2021-09-01 11:43 ` Chesnokov Gleb
2021-09-01 11:56 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e31b660-822a-5bc9-26e3-76046049695a@grimberg.me \
--to=sagi@grimberg.me \
--cc=Chesnokov.G@raidix.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=lanevdenoche@gmail.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).