From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Siddharth Gupta <sidgup@codeaurora.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org, ohad@wizery.com,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tsoni@codeaurora.org,
psodagud@codeaurora.org, rishabhb@codeaurora.org
Subject: Re: [PATCH v2 2/6] remoteproc: sysmon: Add notifications for events
Date: Wed, 15 Apr 2020 11:03:51 -0600 [thread overview]
Message-ID: <20200415170351.GB16583@xps15> (raw)
Message-ID: <20200415170351.usnKdOOv-9P59P1gzmQuN7ef5u6Hyy2xX-908F7ugxg@z> (raw)
In-Reply-To: <1586389003-26675-3-git-send-email-sidgup@codeaurora.org>
On Wed, Apr 08, 2020 at 04:36:39PM -0700, Siddharth Gupta wrote:
> Add notification for other stages of remoteproc boot and shutdown. This
> includes adding callback functions for the prepare and unprepare events,
> and fleshing out the callback function for start.
>
> Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> drivers/remoteproc/qcom_sysmon.c | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
> index 1366050..851664e 100644
> --- a/drivers/remoteproc/qcom_sysmon.c
> +++ b/drivers/remoteproc/qcom_sysmon.c
> @@ -439,8 +439,31 @@ static const struct qmi_ops ssctl_ops = {
> .del_server = ssctl_del_server,
> };
>
> +static int sysmon_prepare(struct rproc_subdev *subdev)
> +{
> + struct qcom_sysmon *sysmon = container_of(subdev, struct qcom_sysmon,
> + subdev);
> + struct sysmon_event event = {
> + .subsys_name = sysmon->name,
> + .ssr_event = SSCTL_SSR_EVENT_BEFORE_POWERUP
> + };
> +
> + blocking_notifier_call_chain(&sysmon_notifiers, 0, (void *)&event);
> +
> + return 0;
> +}
> +
> static int sysmon_start(struct rproc_subdev *subdev)
> {
> + struct qcom_sysmon *sysmon = container_of(subdev, struct qcom_sysmon,
> + subdev);
> + struct sysmon_event event = {
> + .subsys_name = sysmon->name,
> + .ssr_event = SSCTL_SSR_EVENT_AFTER_POWERUP
> + };
> +
> + blocking_notifier_call_chain(&sysmon_notifiers, 0, (void *)&event);
> +
> return 0;
> }
>
> @@ -464,6 +487,18 @@ static void sysmon_stop(struct rproc_subdev *subdev, bool crashed)
> sysmon_request_shutdown(sysmon);
> }
>
> +static void sysmon_unprepare(struct rproc_subdev *subdev)
> +{
> + struct qcom_sysmon *sysmon = container_of(subdev, struct qcom_sysmon,
> + subdev);
> + struct sysmon_event event = {
> + .subsys_name = sysmon->name,
> + .ssr_event = SSCTL_SSR_EVENT_AFTER_SHUTDOWN
> + };
> +
> + blocking_notifier_call_chain(&sysmon_notifiers, 0, (void *)&event);
> +}
> +
> /**
> * sysmon_notify() - notify sysmon target of another's SSR
> * @nb: notifier_block associated with sysmon instance
> @@ -563,8 +598,10 @@ struct qcom_sysmon *qcom_add_sysmon_subdev(struct rproc *rproc,
>
> qmi_add_lookup(&sysmon->qmi, 43, 0, 0);
>
> + sysmon->subdev.prepare = sysmon_prepare;
> sysmon->subdev.start = sysmon_start;
> sysmon->subdev.stop = sysmon_stop;
> + sysmon->subdev.unprepare = sysmon_unprepare;
>
> rproc_add_subdev(rproc, &sysmon->subdev);
>
> --
> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-04-15 17:03 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 23:36 [PATCH v2 0/6] remoteproc: qcom: Add callbacks for remoteproc events Siddharth Gupta
2020-04-08 23:36 ` Siddharth Gupta
2020-04-08 23:36 ` [PATCH v2 1/6] remoteproc: sysmon: Add ability to send type of notification Siddharth Gupta
2020-04-15 17:03 ` Mathieu Poirier
2020-04-15 17:03 ` Mathieu Poirier
2020-04-20 7:05 ` Bjorn Andersson
2020-04-20 7:05 ` Bjorn Andersson
2020-04-08 23:36 ` [PATCH v2 2/6] remoteproc: sysmon: Add notifications for events Siddharth Gupta
2020-04-08 23:36 ` Siddharth Gupta
2020-04-15 17:03 ` Mathieu Poirier [this message]
2020-04-15 17:03 ` Mathieu Poirier
2020-04-20 7:05 ` Bjorn Andersson
2020-04-20 7:05 ` Bjorn Andersson
2020-04-08 23:36 ` [PATCH v2 3/6] remoteproc: sysmon: Inform current rproc about all active rprocs Siddharth Gupta
2020-04-08 23:36 ` Siddharth Gupta
2020-04-15 17:16 ` Mathieu Poirier
2020-04-15 17:16 ` Mathieu Poirier
2020-04-20 7:09 ` Bjorn Andersson
2020-04-20 7:09 ` Bjorn Andersson
2020-04-08 23:36 ` [PATCH v2 4/6] remoteproc: qcom: Add name field for every subdevice Siddharth Gupta
2020-04-08 23:36 ` Siddharth Gupta
2020-04-15 18:11 ` Mathieu Poirier
2020-04-15 18:11 ` Mathieu Poirier
2020-04-23 0:54 ` Bjorn Andersson
2020-04-23 0:54 ` Bjorn Andersson
2020-04-08 23:36 ` [PATCH v2 5/6] remoteproc: qcom: Add per subsystem SSR notification Siddharth Gupta
2020-04-08 23:36 ` Siddharth Gupta
2020-04-15 18:07 ` Mathieu Poirier
2020-04-15 18:07 ` Mathieu Poirier
2020-04-23 0:53 ` Bjorn Andersson
2020-04-23 0:53 ` Bjorn Andersson
2020-04-08 23:36 ` [PATCH v2 6/6] remoteproc: qcom: Add notification types to SSR Siddharth Gupta
2020-04-08 23:36 ` Siddharth Gupta
2020-04-15 18:10 ` Mathieu Poirier
2020-04-15 18:10 ` Mathieu Poirier
2020-04-23 0:58 ` Bjorn Andersson
2020-04-23 0:58 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415170351.GB16583@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=psodagud@codeaurora.org \
--cc=rishabhb@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).