From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 08/15] dt-bindings: remoteproc: qcom,sm8150-pas: split into separate file
Date: Tue, 6 Dec 2022 08:58:40 +0100 [thread overview]
Message-ID: <26091130-1572-6a86-8590-7f3ec7654100@linaro.org> (raw)
In-Reply-To: <20221205194934.GA2476927-robh@kernel.org>
On 05/12/2022 20:49, Rob Herring wrote:
Hi Rob,
>> + clocks:
>> + items:
>> + - description: XO clock
>> +
>> + clock-names:
>> + items:
>> + - const: xo
>> +
>> + qcom,qmp:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description: Reference to the AOSS side-channel message RAM.
>
> Not ideal that we are defining the type here multiple times.
I was thinking to add it to the common file (qcom,pas-common.yaml,
created in patch 6/15) and just disallow it for other variants,
but that does not work that good:
Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml: properties:qcom,qmp: False is not of type 'object'
hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml: properties:qcom,qmp: More than one condition true in oneOf schema:
{'description': 'Vendor specific properties must have a type and '
'description unless they have a defined, common '
'suffix.',
qcom,qcs404-pas.yaml has "com,qmp: false" and it references
"qcom,pas-common.yaml" which has the definition of the property.
However it seems it is treated as new bool property.
----------------------------
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
index 007349ef51ed..62126e96d2f5 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
@@ -39,6 +39,7 @@ properties:
power-domains: false
power-domain-names: false
+ qcom,qmp: false
smd-edge: false
required:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
index 1d5e01c8d8bc..72cdcc2b157d 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
@@ -60,6 +60,10 @@ properties:
maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
+ qcom,qmp:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Reference to the AOSS side-channel message RAM.
+
qcom,smem-states:
$ref: /schemas/types.yaml#/definitions/phandle-array
description: States used by the AP to signal the Hexagon core
----------------------------
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-06 7:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 18:43 [PATCH v3 00/15] dt-bindings: remoteproc: qcom: split and reorganize PAS/PIL Krzysztof Kozlowski
2022-11-24 18:43 ` [PATCH v3 01/15] arm64: dts: qcom: msm8996: drop address/size cells from smd-edge Krzysztof Kozlowski
2022-11-24 18:43 ` [PATCH v3 02/15] arm64: dts: qcom: qcs404: align CDSP PAS node with bindings Krzysztof Kozlowski
2022-11-24 18:43 ` [PATCH v3 03/15] arm64: dts: qcom: sc7180: align MPSS " Krzysztof Kozlowski
2022-11-24 18:43 ` [PATCH v3 04/15] arm64: dts: qcom: sc7280: " Krzysztof Kozlowski
2022-11-24 18:43 ` [PATCH v3 05/15] dt-bindings: remoteproc: qcom,adsp: drop resets and qcom,halt-regs Krzysztof Kozlowski
2022-12-05 19:44 ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 06/15] dt-bindings: remoteproc: qcom,adsp: split common part Krzysztof Kozlowski
2022-12-05 19:44 ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 07/15] dt-bindings: remoteproc: qcom,sm8350-pas: split into separate file Krzysztof Kozlowski
2022-12-05 19:45 ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 08/15] dt-bindings: remoteproc: qcom,sm8150-pas: " Krzysztof Kozlowski
2022-12-05 19:46 ` Rob Herring
2022-12-05 19:49 ` Rob Herring
2022-12-06 7:58 ` Krzysztof Kozlowski [this message]
2022-11-24 18:43 ` [PATCH v3 09/15] dt-bindings: remoteproc: qcom,sm6350-pas: " Krzysztof Kozlowski
2022-12-05 19:50 ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 10/15] dt-bindings: remoteproc: qcom,sc8280xp-pas: " Krzysztof Kozlowski
2022-12-05 19:50 ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 11/15] dt-bindings: remoteproc: qcom,sc8180x-pas: " Krzysztof Kozlowski
2022-12-05 19:51 ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 12/15] dt-bindings: remoteproc: qcom,sdx55-pas: " Krzysztof Kozlowski
2022-12-05 19:51 ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 13/15] dt-bindings: remoteproc: qcom,qcs404-pas: " Krzysztof Kozlowski
2022-12-05 19:52 ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 14/15] dt-bindings: remoteproc: qcom,sc7180-pas: " Krzysztof Kozlowski
2022-12-05 19:52 ` Rob Herring
2022-11-24 18:43 ` [PATCH v3 15/15] dt-bindings: remoteproc: qcom,adsp: correct msm8996-slpi-pil clocks Krzysztof Kozlowski
2022-12-05 19:53 ` Rob Herring
2022-12-27 18:08 ` (subset) [PATCH v3 00/15] dt-bindings: remoteproc: qcom: split and reorganize PAS/PIL Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26091130-1572-6a86-8590-7f3ec7654100@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).