From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: John Watts <contact@jookia.org>,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
linux-can@vger.kernel.org, linux-riscv@lists.infradead.org,
Fabien Poussin <fabien.poussin@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH 3/4] can: sun4i_can: Add send support for the Allwinner D1
Date: Mon, 17 Jul 2023 09:12:36 +0200 [thread overview]
Message-ID: <07aa464d-c9d8-4fe0-2063-98562a3480d6@kernel.org> (raw)
In-Reply-To: <20230717-aluminum-driven-a008473620ca-mkl@pengutronix.de>
On 17/07/2023 09:03, Marc Kleine-Budde wrote:
> On 17.07.2023 08:41:07, Krzysztof Kozlowski wrote:
>> On 16/07/2023 18:52, John Watts wrote:
>>> Hello,
>>>
>>> On Sun, Jul 16, 2023 at 06:36:03PM +0200, Krzysztof Kozlowski wrote:
>>>>> +static const struct sun4ican_quirks sun4ican_quirks_d1 = {
>>>>> + .has_reset = true,
>>>>> +};
>>>>
>>>> Isn't this the same as previous?
>>>
>>> Yes, but I wanted to split up the new quirk in to its own patch.
>>
>> I don't understand why you need this new, duplicated entry. Aren't
>> devices compatible?
>
> According to patch 4/4 the devices are not compatible.
Ah, ok, I didn't go so far because it is not obvious to add support for
a device in patch 3 which is already not correct and needs fix/followup
in patch 4.
Thanks.
>
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-07-17 7:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 11:25 [PATCH 0/4] Add support for Allwinner D1 CAN controllers Jookia
2023-07-15 11:25 ` [PATCH 1/4] dt-bindings: net: can: Add support for Allwinner D1 CAN controller Jookia
2023-07-15 11:25 ` [PATCH 2/4] riscv: dts: allwinner: d1: Add CAN controller nodes Jookia
2023-07-16 16:35 ` Krzysztof Kozlowski
2023-07-16 16:50 ` John Watts
2023-07-17 6:39 ` Krzysztof Kozlowski
2023-07-17 8:26 ` John Watts
2023-07-15 11:25 ` [PATCH 3/4] can: sun4i_can: Add send support for the Allwinner D1 Jookia
2023-07-16 16:36 ` Krzysztof Kozlowski
2023-07-16 16:52 ` John Watts
2023-07-17 6:41 ` Krzysztof Kozlowski
2023-07-17 7:03 ` Marc Kleine-Budde
2023-07-17 7:12 ` Krzysztof Kozlowski [this message]
2023-07-17 8:28 ` John Watts
2023-07-15 11:25 ` [PATCH 4/4] can: sun4i_can: Correctly set acceptance registers on the D1 Jookia
2023-07-16 16:45 ` Jernej Škrabec
2023-07-16 16:52 ` John Watts
2023-07-17 8:00 ` [PATCH 0/4] Add support for Allwinner D1 CAN controllers Ben Dooks
2023-07-17 8:27 ` John Watts
2023-07-18 22:15 ` Rob Herring
2023-07-18 22:38 ` Conor Dooley
2023-07-19 6:52 ` John Watts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07aa464d-c9d8-4fe0-2063-98562a3480d6@kernel.org \
--to=krzk@kernel.org \
--cc=contact@jookia.org \
--cc=devicetree@vger.kernel.org \
--cc=fabien.poussin@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mkl@pengutronix.de \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).