From: Christoph Hellwig <hch@infradead.org>
To: Anup Patel <anup@brainfault.org>
Cc: Palmer Dabbelt <palmer@sifive.com>,
Anup Patel <Anup.Patel@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Paul Walmsley <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v3 4/4] RISC-V: Allow booting kernel from any 4KB aligned address
Date: Mon, 25 Mar 2019 07:55:43 -0700 [thread overview]
Message-ID: <20190325145543.GA14826@infradead.org> (raw)
In-Reply-To: <CAAhSdy3MZFayMDTiEEV7WseUsxgcWT_um=nbPgXUBFik19OYuQ@mail.gmail.com>
On Mon, Mar 25, 2019 at 06:12:28PM +0530, Anup Patel wrote:
> It uses new code for 2M mappings as well.
That seems to be an odd view - yes some code is shared, but we still
have two different ways using ifdefs.
> The code is lot better, readable and flexible.
better is in the eye of the beholder. It very much is not easier
readable with the spurious indirect calls at least. And it is a lot
bigger.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-03-25 14:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 9:22 [PATCH v3 0/4] Boot RISC-V kernel from any 4KB aligned address Anup Patel
2019-03-25 9:23 ` [PATCH v3 1/4] RISC-V: Add separate defconfig for 32bit systems Anup Patel
2019-03-25 9:23 ` [PATCH v3 2/4] RISC-V: Fix memory reservation in setup_bootmem() Anup Patel
2019-03-25 11:38 ` Christoph Hellwig
2019-03-25 16:13 ` Mike Rapoport
2019-04-24 21:06 ` Palmer Dabbelt
2019-03-25 9:23 ` [PATCH v3 3/4] RISC-V: Remove redundant trampoline page table Anup Patel
2019-03-25 11:38 ` Christoph Hellwig
2019-03-25 9:23 ` [PATCH v3 4/4] RISC-V: Allow booting kernel from any 4KB aligned address Anup Patel
2019-03-25 11:39 ` Christoph Hellwig
2019-03-25 12:42 ` Anup Patel
2019-03-25 14:55 ` Christoph Hellwig [this message]
2019-03-25 12:48 ` Anup Patel
2019-03-25 14:59 ` Christoph Hellwig
2019-03-25 16:16 ` Anup Patel
2019-03-25 17:35 ` Gary Guo
2019-03-26 9:43 ` Anup Patel
2019-03-27 7:54 ` Christoph Hellwig
2019-03-28 7:55 ` Mike Rapoport
2019-03-28 9:52 ` Anup Patel
2019-03-28 10:24 ` Anup Patel
2019-03-28 15:35 Anthony Coulter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325145543.GA14826@infradead.org \
--to=hch@infradead.org \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).