From: Palmer Dabbelt <palmer@sifive.com>
To: Anup.Patel@wdc.com
Cc: aou@eecs.berkeley.edu, Anup.Patel@wdc.com,
linux-kernel@vger.kernel.org, rppt@linux.ibm.com,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 2/4] RISC-V: Fix memory reservation in setup_bootmem()
Date: Wed, 24 Apr 2019 14:06:47 -0700 (PDT) [thread overview]
Message-ID: <mhng-8cf03f23-1af7-48f0-8be8-60654bc09559@palmer-si-x1e> (raw)
In-Reply-To: <20190325092234.5451-3-anup.patel@wdc.com>
On Mon, 25 Mar 2019 02:23:09 PDT (-0700), Anup.Patel@wdc.com wrote:
> Currently, the setup_bootmem() reserves memory from RAM start to the
> kernel end. This prevents us from exploring ways to use the RAM below
> (or before) the kernel start hence this patch updates setup_bootmem()
> to only reserve memory from the kernel start to the kernel end.
>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> Signed-off-by: Anup Patel <anup.patel@wdc.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/riscv/mm/init.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index 8cf9ff1f9058..3e66b7cb3a61 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -29,6 +29,8 @@ unsigned long empty_zero_page[PAGE_SIZE / sizeof(unsigned long)]
> __page_aligned_bss;
> EXPORT_SYMBOL(empty_zero_page);
>
> +extern char _start[];
> +
> static void __init zone_sizes_init(void)
> {
> unsigned long max_zone_pfns[MAX_NR_ZONES] = { 0, };
> @@ -108,23 +110,21 @@ void __init setup_bootmem(void)
> {
> struct memblock_region *reg;
> phys_addr_t mem_size = 0;
> + phys_addr_t vmlinux_end = __pa(&_end);
> + phys_addr_t vmlinux_start = __pa(&_start);
>
> /* Find the memory region containing the kernel */
> for_each_memblock(memory, reg) {
> - phys_addr_t vmlinux_end = __pa(_end);
> phys_addr_t end = reg->base + reg->size;
>
> - if (reg->base <= vmlinux_end && vmlinux_end <= end) {
> - /*
> - * Reserve from the start of the region to the end of
> - * the kernel
> - */
> - memblock_reserve(reg->base, vmlinux_end - reg->base);
> + if (reg->base <= vmlinux_end && vmlinux_end <= end)
> mem_size = min(reg->size, (phys_addr_t)-PAGE_OFFSET);
> - }
> }
> BUG_ON(mem_size == 0);
>
> + /* Reserve from the start of the kernel to the end of the kernel */
> + memblock_reserve(vmlinux_start, vmlinux_end - vmlinux_start);
> +
> set_max_mapnr(PFN_DOWN(mem_size));
> max_low_pfn = PFN_DOWN(memblock_end_of_DRAM());
>
> @@ -196,7 +196,6 @@ void __set_fixmap(enum fixed_addresses idx, phys_addr_t phys, pgprot_t prot)
> */
> asmlinkage void __init setup_vm(void)
> {
> - extern char _start;
> uintptr_t i;
> uintptr_t pa = (uintptr_t) &_start;
> pgprot_t prot = __pgprot(pgprot_val(PAGE_KERNEL) | _PAGE_EXEC);
> --
> 2.17.1
I've already merged your first patch for 5.1, but I'm going through and
collecting 5.2 patches now and it appears this has a conflict. Do you mind
re-submitting the patch set against rc6?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-04-24 21:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 9:22 [PATCH v3 0/4] Boot RISC-V kernel from any 4KB aligned address Anup Patel
2019-03-25 9:23 ` [PATCH v3 1/4] RISC-V: Add separate defconfig for 32bit systems Anup Patel
2019-03-25 9:23 ` [PATCH v3 2/4] RISC-V: Fix memory reservation in setup_bootmem() Anup Patel
2019-03-25 11:38 ` Christoph Hellwig
2019-03-25 16:13 ` Mike Rapoport
2019-04-24 21:06 ` Palmer Dabbelt [this message]
2019-03-25 9:23 ` [PATCH v3 3/4] RISC-V: Remove redundant trampoline page table Anup Patel
2019-03-25 11:38 ` Christoph Hellwig
2019-03-25 9:23 ` [PATCH v3 4/4] RISC-V: Allow booting kernel from any 4KB aligned address Anup Patel
2019-03-25 11:39 ` Christoph Hellwig
2019-03-25 12:42 ` Anup Patel
2019-03-25 14:55 ` Christoph Hellwig
2019-03-25 12:48 ` Anup Patel
2019-03-25 14:59 ` Christoph Hellwig
2019-03-25 16:16 ` Anup Patel
2019-03-25 17:35 ` Gary Guo
2019-03-26 9:43 ` Anup Patel
2019-03-27 7:54 ` Christoph Hellwig
2019-03-28 7:55 ` Mike Rapoport
2019-03-28 9:52 ` Anup Patel
2019-03-28 10:24 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-8cf03f23-1af7-48f0-8be8-60654bc09559@palmer-si-x1e \
--to=palmer@sifive.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).