* [PATCH 08/10] pwm: sifive: Consistenly name pwm_chip variables "chip"
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
@ 2023-07-14 20:56 ` Uwe Kleine-König
2023-07-20 6:48 ` [PATCH 00/10] pwm: Constistenly " Thierry Reding
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Uwe Kleine-König @ 2023-07-14 20:56 UTC (permalink / raw)
To: Thierry Reding, Palmer Dabbelt, Paul Walmsley
Cc: linux-pwm, linux-riscv, kernel
Most variables holding a pointer to a pwm_chip are called "chip" which
is also the usual name in most other pwm drivers. Rename the single
variable that have a different name to be called "chip", too, for
consistency.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/pwm/pwm-sifive.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c
index ae49d67ab2b1..25b9b7d9476a 100644
--- a/drivers/pwm/pwm-sifive.c
+++ b/drivers/pwm/pwm-sifive.c
@@ -51,9 +51,9 @@ struct pwm_sifive_ddata {
};
static inline
-struct pwm_sifive_ddata *pwm_sifive_chip_to_ddata(struct pwm_chip *c)
+struct pwm_sifive_ddata *pwm_sifive_chip_to_ddata(struct pwm_chip *chip)
{
- return container_of(c, struct pwm_sifive_ddata, chip);
+ return container_of(chip, struct pwm_sifive_ddata, chip);
}
static int pwm_sifive_request(struct pwm_chip *chip, struct pwm_device *pwm)
--
2.39.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 08/10] pwm: sifive: Consistenly " Uwe Kleine-König
@ 2023-07-20 6:48 ` Thierry Reding
2023-07-20 7:10 ` Uwe Kleine-König
2023-07-20 14:41 ` Thierry Reding
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Thierry Reding @ 2023-07-20 6:48 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
Florian Fainelli, Ray Jui, Scott Branden, Benson Leung,
Heiko Stuebner, Palmer Dabbelt, Paul Walmsley, Michael Walle,
Johan Hovold, Alex Elder, Greg Kroah-Hartman, linux-pwm, kernel,
linux-arm-kernel, Broadcom internal kernel review list,
Guenter Roeck, chrome-platform, linux-rockchip, linux-riscv,
greybus-dev, linux-staging
[-- Attachment #1.1: Type: text/plain, Size: 2682 bytes --]
On Fri, Jul 14, 2023 at 10:56:13PM +0200, Uwe Kleine-König wrote:
> while working on an extension for the pwm framework, I noticed that some
> drivers and even the core only nearly consistently named all variables
> and struct members holding a pointer to a struct pwm_chip "chip":
>
> $ git grep -Pho 'struct pwm_chip \**[a-z0-9_]+(*nla:[\(a-z0-9_])' v6.5-rc1 | sort | uniq -c | sort -n
> 1 struct pwm_chip *pwm
> 1 struct pwm_chip pwm
> 1 struct pwm_chip pwm_chip
> 2 struct pwm_chip *_chip
> 4 struct pwm_chip *c
> 8 struct pwm_chip *pc
> 57 struct pwm_chip chip
> 358 struct pwm_chip *chip
>
> With this series applied these are all called "chip" with one exception:
> The led driver drivers/leds/rgb/leds-qcom-lpg.c uses "pwm". Maybe
> "pwmchip" would be a better name, but I'm not sure that using "chip" was
> an improvement there as this isn't a pure pwm driver. I'm not touching
> that one.
>
> The first offenders I found were the core and the atmel-hlcdc driver.
> After I found these I optimistically assumed these were the only ones
> with the unusual names and send patches for these out individually
> before checking systematically.
>
> The atmel-hlcdc patch is included here unchanged, the core patch now
> also adapted the declaration of the changed functions in <linux/pwm.h>.
> I marked these two as "superseded" in patchwork already.
>
> All patches in this series are pairwise independent of each other. I
> don't know if the staging patch should better go in via the greybus tree
> or via pwm. Both is possible without needing coordination.
>
> Best regards
> Uwe
>
>
> Uwe Kleine-König (10):
> pwm: Use a consistent name for pwm_chip pointers in the core
> pwm: atmel-hlcdc: Use consistent variable naming
> pwm: bcm-kona: Consistenly name pwm_chip variables "chip"
> pwm: crc: Consistenly name pwm_chip variables "chip"
> pwm: cros-ec: Consistenly name pwm_chip variables "chip"
> pwm: lp3943: Consistenly name pwm_chip variables "chip"
> pwm: rockchip: Consistenly name pwm_chip variables "chip"
> pwm: sifive: Consistenly name pwm_chip variables "chip"
> pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
> staging: greybus: pwm: Consistenly name pwm_chip variables "chip"
This would've been much easier if it had been a single patch. Now I have
to either make you redo the whole series because you've misspelled PWM
or I have to go and update it myself in most of the above patches. Hint:
I'll do the latter.
There is really no reason to split this up into this many patches for
such a trivial change.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-20 6:48 ` [PATCH 00/10] pwm: Constistenly " Thierry Reding
@ 2023-07-20 7:10 ` Uwe Kleine-König
2023-07-20 15:03 ` Thierry Reding
0 siblings, 1 reply; 8+ messages in thread
From: Uwe Kleine-König @ 2023-07-20 7:10 UTC (permalink / raw)
To: Thierry Reding
Cc: Alexandre Belloni, Heiko Stuebner, Guenter Roeck, linux-riscv,
chrome-platform, Florian Fainelli, linux-staging, linux-rockchip,
Broadcom internal kernel review list, linux-pwm, Ray Jui,
Johan Hovold, greybus-dev, Paul Walmsley, Benson Leung,
linux-arm-kernel, Alex Elder, Scott Branden, Greg Kroah-Hartman,
Nicolas Ferre, Michael Walle, Palmer Dabbelt, kernel,
Claudiu Beznea
[-- Attachment #1.1: Type: text/plain, Size: 1933 bytes --]
Hello Thierry,
On Thu, Jul 20, 2023 at 08:48:11AM +0200, Thierry Reding wrote:
> On Fri, Jul 14, 2023 at 10:56:13PM +0200, Uwe Kleine-König wrote:
> > Uwe Kleine-König (10):
> > pwm: Use a consistent name for pwm_chip pointers in the core
> > pwm: atmel-hlcdc: Use consistent variable naming
> > pwm: bcm-kona: Consistenly name pwm_chip variables "chip"
> > pwm: crc: Consistenly name pwm_chip variables "chip"
> > pwm: cros-ec: Consistenly name pwm_chip variables "chip"
> > pwm: lp3943: Consistenly name pwm_chip variables "chip"
> > pwm: rockchip: Consistenly name pwm_chip variables "chip"
> > pwm: sifive: Consistenly name pwm_chip variables "chip"
> > pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
> > staging: greybus: pwm: Consistenly name pwm_chip variables "chip"
>
> This would've been much easier if it had been a single patch. Now I have
> to either make you redo the whole series because you've misspelled PWM
> or I have to go and update it myself in most of the above patches. Hint:
> I'll do the latter.
I guess you want to do s/pwm driver/PWM driver/? Fine for me, thanks.
> There is really no reason to split this up into this many patches for
> such a trivial change.
Well, that's a subjective view. There are reasons to prefer several
small patches over one big one, too. A small patch can be indiviually
reviewed, so the "Reviewed-by: Alex Elder ..." tag only goes to the one
change that he actually looked at and if later a fix to the sifive
driver is to be backported to stable, the stable maintainers just pick
the sifive one instead of one big patch.
Did you skip the sl28cpld patch, or squash the fixup I sent in the reply
to Michael Walle?
Best regards and thanks,
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-20 7:10 ` Uwe Kleine-König
@ 2023-07-20 15:03 ` Thierry Reding
0 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2023-07-20 15:03 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Alexandre Belloni, Heiko Stuebner, Guenter Roeck, linux-riscv,
chrome-platform, Florian Fainelli, linux-staging, linux-rockchip,
Broadcom internal kernel review list, linux-pwm, Ray Jui,
Johan Hovold, greybus-dev, Paul Walmsley, Benson Leung,
linux-arm-kernel, Alex Elder, Scott Branden, Greg Kroah-Hartman,
Nicolas Ferre, Michael Walle, Palmer Dabbelt, kernel,
Claudiu Beznea
[-- Attachment #1.1: Type: text/plain, Size: 2074 bytes --]
On Thu, Jul 20, 2023 at 09:10:33AM +0200, Uwe Kleine-König wrote:
> Hello Thierry,
>
> On Thu, Jul 20, 2023 at 08:48:11AM +0200, Thierry Reding wrote:
> > On Fri, Jul 14, 2023 at 10:56:13PM +0200, Uwe Kleine-König wrote:
> > > Uwe Kleine-König (10):
> > > pwm: Use a consistent name for pwm_chip pointers in the core
> > > pwm: atmel-hlcdc: Use consistent variable naming
> > > pwm: bcm-kona: Consistenly name pwm_chip variables "chip"
> > > pwm: crc: Consistenly name pwm_chip variables "chip"
> > > pwm: cros-ec: Consistenly name pwm_chip variables "chip"
> > > pwm: lp3943: Consistenly name pwm_chip variables "chip"
> > > pwm: rockchip: Consistenly name pwm_chip variables "chip"
> > > pwm: sifive: Consistenly name pwm_chip variables "chip"
> > > pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
> > > staging: greybus: pwm: Consistenly name pwm_chip variables "chip"
> >
> > This would've been much easier if it had been a single patch. Now I have
> > to either make you redo the whole series because you've misspelled PWM
> > or I have to go and update it myself in most of the above patches. Hint:
> > I'll do the latter.
>
> I guess you want to do s/pwm driver/PWM driver/? Fine for me, thanks.
>
> > There is really no reason to split this up into this many patches for
> > such a trivial change.
>
> Well, that's a subjective view. There are reasons to prefer several
> small patches over one big one, too. A small patch can be indiviually
> reviewed, so the "Reviewed-by: Alex Elder ..." tag only goes to the one
> change that he actually looked at and if later a fix to the sifive
> driver is to be backported to stable, the stable maintainers just pick
> the sifive one instead of one big patch.
Backports becoming more complicated would actually be a good reason not
to do this in the first place, but we've already discussed that enough
elsewhere.
> Did you skip the sl28cpld patch, or squash the fixup I sent in the reply
> to Michael Walle?
I squashed the fixup.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 08/10] pwm: sifive: Consistenly " Uwe Kleine-König
2023-07-20 6:48 ` [PATCH 00/10] pwm: Constistenly " Thierry Reding
@ 2023-07-20 14:41 ` Thierry Reding
2023-09-11 4:31 ` patchwork-bot+chrome-platform
2023-09-11 4:49 ` patchwork-bot+chrome-platform
4 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2023-07-20 14:41 UTC (permalink / raw)
To: Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
Florian Fainelli, Ray Jui, Scott Branden, Benson Leung,
Heiko Stuebner, Palmer Dabbelt, Paul Walmsley, Michael Walle,
Johan Hovold, Alex Elder, Greg Kroah-Hartman,
Uwe Kleine-König
Cc: linux-pwm, kernel, linux-arm-kernel,
Broadcom internal kernel review list, Guenter Roeck,
chrome-platform, linux-rockchip, linux-riscv, greybus-dev,
linux-staging
On Fri, 14 Jul 2023 22:56:13 +0200, Uwe Kleine-König wrote:
> while working on an extension for the pwm framework, I noticed that some
> drivers and even the core only nearly consistently named all variables
> and struct members holding a pointer to a struct pwm_chip "chip":
>
> $ git grep -Pho 'struct pwm_chip \**[a-z0-9_]+(*nla:[\(a-z0-9_])' v6.5-rc1 | sort | uniq -c | sort -n
> 1 struct pwm_chip *pwm
> 1 struct pwm_chip pwm
> 1 struct pwm_chip pwm_chip
> 2 struct pwm_chip *_chip
> 4 struct pwm_chip *c
> 8 struct pwm_chip *pc
> 57 struct pwm_chip chip
> 358 struct pwm_chip *chip
>
> [...]
Applied, thanks!
[01/10] pwm: Use a consistent name for pwm_chip pointers in the core
commit: b4f78ff746ec5274fffa92fa2a4dc531360b5016
[02/10] pwm: atmel-hlcdc: Use consistent variable naming
commit: 509143926e184762cdaffb6b67d3809fddd7f4d9
[03/10] pwm: bcm-kona: Consistenly name pwm_chip variables "chip"
commit: af87385c7ad278207d34ff3681fa325a240ae87c
[04/10] pwm: crc: Consistenly name pwm_chip variables "chip"
commit: fc30826d50d10d67628addfabb9367b5067efa42
[05/10] pwm: cros-ec: Consistenly name pwm_chip variables "chip"
commit: 6b5fdb2b655ac9abe6fbd2cbcb25c8837e3e8553
[06/10] pwm: lp3943: Consistenly name pwm_chip variables "chip"
commit: dd499b63618e523b47f30d99bf20f417de1187ff
[07/10] pwm: rockchip: Consistenly name pwm_chip variables "chip"
commit: 8c297d1fdb5d2b81d39ada6b435fb92a41be9f17
[08/10] pwm: sifive: Consistenly name pwm_chip variables "chip"
commit: cb69f40ea7cb139223901fcfc81e4e0a0a03673c
[09/10] pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
commit: e79974c5c3ddc3e8181f582117c4368557524f20
[10/10] staging: greybus: pwm: Consistenly name pwm_chip variables "chip"
commit: efd1d1ad7f525809fcdf7538638a08274b75c99f
Best regards,
--
Thierry Reding <thierry.reding@gmail.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
` (2 preceding siblings ...)
2023-07-20 14:41 ` Thierry Reding
@ 2023-09-11 4:31 ` patchwork-bot+chrome-platform
2023-09-11 4:49 ` patchwork-bot+chrome-platform
4 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-09-11 4:31 UTC (permalink / raw)
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=
Cc: thierry.reding, nicolas.ferre, alexandre.belloni, claudiu.beznea,
florian.fainelli, rjui, sbranden, bleung, heiko, palmer,
paul.walmsley, michael, johan, elder, gregkh, linux-pwm, kernel,
linux-arm-kernel, bcm-kernel-feedback-list, groeck,
chrome-platform, linux-rockchip, linux-riscv, greybus-dev,
linux-staging
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Thierry Reding <thierry.reding@gmail.com>:
On Fri, 14 Jul 2023 22:56:13 +0200 you wrote:
> while working on an extension for the pwm framework, I noticed that some
> drivers and even the core only nearly consistently named all variables
> and struct members holding a pointer to a struct pwm_chip "chip":
>
> $ git grep -Pho 'struct pwm_chip \**[a-z0-9_]+(*nla:[\(a-z0-9_])' v6.5-rc1 | sort | uniq -c | sort -n
> 1 struct pwm_chip *pwm
> 1 struct pwm_chip pwm
> 1 struct pwm_chip pwm_chip
> 2 struct pwm_chip *_chip
> 4 struct pwm_chip *c
> 8 struct pwm_chip *pc
> 57 struct pwm_chip chip
> 358 struct pwm_chip *chip
>
> [...]
Here is the summary with links:
- [05/10] pwm: cros-ec: Consistenly name pwm_chip variables "chip"
https://git.kernel.org/chrome-platform/c/5996cdf132da
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
` (3 preceding siblings ...)
2023-09-11 4:31 ` patchwork-bot+chrome-platform
@ 2023-09-11 4:49 ` patchwork-bot+chrome-platform
4 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-09-11 4:49 UTC (permalink / raw)
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=
Cc: thierry.reding, nicolas.ferre, alexandre.belloni, claudiu.beznea,
florian.fainelli, rjui, sbranden, bleung, heiko, palmer,
paul.walmsley, michael, johan, elder, gregkh, linux-pwm, kernel,
linux-arm-kernel, bcm-kernel-feedback-list, groeck,
chrome-platform, linux-rockchip, linux-riscv, greybus-dev,
linux-staging
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Thierry Reding <thierry.reding@gmail.com>:
On Fri, 14 Jul 2023 22:56:13 +0200 you wrote:
> while working on an extension for the pwm framework, I noticed that some
> drivers and even the core only nearly consistently named all variables
> and struct members holding a pointer to a struct pwm_chip "chip":
>
> $ git grep -Pho 'struct pwm_chip \**[a-z0-9_]+(*nla:[\(a-z0-9_])' v6.5-rc1 | sort | uniq -c | sort -n
> 1 struct pwm_chip *pwm
> 1 struct pwm_chip pwm
> 1 struct pwm_chip pwm_chip
> 2 struct pwm_chip *_chip
> 4 struct pwm_chip *c
> 8 struct pwm_chip *pc
> 57 struct pwm_chip chip
> 358 struct pwm_chip *chip
>
> [...]
Here is the summary with links:
- [05/10] pwm: cros-ec: Consistenly name pwm_chip variables "chip"
https://git.kernel.org/chrome-platform/c/5996cdf132da
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread