* [BUG] [BISECT] rockchip: roc-pc-rk3399: TPL misses dtb
@ 2021-02-15 14:05 Markus Reichl
2021-02-15 15:11 ` Tom Rini
0 siblings, 1 reply; 4+ messages in thread
From: Markus Reichl @ 2021-02-15 14:05 UTC (permalink / raw)
To: linux-rockchip, Levin Du, Suniel Mahesh, Jagan Teki
Cc: Markus Reichl, u-boot, Heiko Stuebner
With recent U-Boot and roc-pc-mezzanine-rk3399_defconfig
and booting from SPI flash I get:
U-Boot TPL 2021.01-00884-g0a2aaab0b6 (Feb 15 2021 - 14:36:50)
Missing DTB
### ERROR ### Please RESET the board ###
Bisecting points to:
commit 0a2aaab0b678fd1778ff2fc59d0770fc82995532
Author: Simon Glass <sjg@chromium.org>
Date: Wed Jan 13 20:29:49 2021 -0700
fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup()
This setting may be different in SPL and TPL. Update the code to check
the correct setting.
Signed-off-by: Simon Glass <sjg@chromium.org>
lib/fdtdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reverting this commit fixes booting.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] [BISECT] rockchip: roc-pc-rk3399: TPL misses dtb
2021-02-15 14:05 [BUG] [BISECT] rockchip: roc-pc-rk3399: TPL misses dtb Markus Reichl
@ 2021-02-15 15:11 ` Tom Rini
2021-02-18 4:45 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Tom Rini @ 2021-02-15 15:11 UTC (permalink / raw)
To: Markus Reichl
Cc: Heiko Stuebner, linux-rockchip, u-boot, Jagan Teki,
Suniel Mahesh, Levin Du
[-- Attachment #1.1: Type: text/plain, Size: 919 bytes --]
On Mon, Feb 15, 2021 at 03:05:20PM +0100, Markus Reichl wrote:
> With recent U-Boot and roc-pc-mezzanine-rk3399_defconfig
> and booting from SPI flash I get:
>
> U-Boot TPL 2021.01-00884-g0a2aaab0b6 (Feb 15 2021 - 14:36:50)
> Missing DTB
> ### ERROR ### Please RESET the board ###
>
> Bisecting points to:
>
> commit 0a2aaab0b678fd1778ff2fc59d0770fc82995532
> Author: Simon Glass <sjg@chromium.org>
> Date: Wed Jan 13 20:29:49 2021 -0700
>
> fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup()
> This setting may be different in SPL and TPL. Update the code to check
> the correct setting.
> Signed-off-by: Simon Glass <sjg@chromium.org>
>
> lib/fdtdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reverting this commit fixes booting.
Thanks for the report. I'm about to push a revert for this and I'll add
a Reported-by from you.
--
Tom
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] [BISECT] rockchip: roc-pc-rk3399: TPL misses dtb
2021-02-15 15:11 ` Tom Rini
@ 2021-02-18 4:45 ` Simon Glass
2021-02-18 13:05 ` Tom Rini
0 siblings, 1 reply; 4+ messages in thread
From: Simon Glass @ 2021-02-18 4:45 UTC (permalink / raw)
To: Tom Rini
Cc: Heiko Stuebner, U-Boot Mailing List, Markus Reichl,
linux-rockchip, Jagan Teki, Suniel Mahesh, Levin Du
Hi,
On Mon, 15 Feb 2021 at 08:11, Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, Feb 15, 2021 at 03:05:20PM +0100, Markus Reichl wrote:
>
> > With recent U-Boot and roc-pc-mezzanine-rk3399_defconfig
> > and booting from SPI flash I get:
> >
> > U-Boot TPL 2021.01-00884-g0a2aaab0b6 (Feb 15 2021 - 14:36:50)
> > Missing DTB
> > ### ERROR ### Please RESET the board ###
> >
> > Bisecting points to:
> >
> > commit 0a2aaab0b678fd1778ff2fc59d0770fc82995532
> > Author: Simon Glass <sjg@chromium.org>
> > Date: Wed Jan 13 20:29:49 2021 -0700
> >
> > fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup()
> > This setting may be different in SPL and TPL. Update the code to check
> > the correct setting.
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> > lib/fdtdec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reverting this commit fixes booting.
>
> Thanks for the report. I'm about to push a revert for this and I'll add
> a Reported-by from you.
I'm not sure what is going on here, but possibly we need to add
TPL_SEPARATE_BSS to the board config..
Regards,
Simon
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] [BISECT] rockchip: roc-pc-rk3399: TPL misses dtb
2021-02-18 4:45 ` Simon Glass
@ 2021-02-18 13:05 ` Tom Rini
0 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2021-02-18 13:05 UTC (permalink / raw)
To: Simon Glass
Cc: Heiko Stuebner, U-Boot Mailing List, Markus Reichl,
linux-rockchip, Jagan Teki, Suniel Mahesh, Levin Du
[-- Attachment #1.1: Type: text/plain, Size: 1402 bytes --]
On Wed, Feb 17, 2021 at 09:45:44PM -0700, Simon Glass wrote:
> Hi,
>
> On Mon, 15 Feb 2021 at 08:11, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Mon, Feb 15, 2021 at 03:05:20PM +0100, Markus Reichl wrote:
> >
> > > With recent U-Boot and roc-pc-mezzanine-rk3399_defconfig
> > > and booting from SPI flash I get:
> > >
> > > U-Boot TPL 2021.01-00884-g0a2aaab0b6 (Feb 15 2021 - 14:36:50)
> > > Missing DTB
> > > ### ERROR ### Please RESET the board ###
> > >
> > > Bisecting points to:
> > >
> > > commit 0a2aaab0b678fd1778ff2fc59d0770fc82995532
> > > Author: Simon Glass <sjg@chromium.org>
> > > Date: Wed Jan 13 20:29:49 2021 -0700
> > >
> > > fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup()
> > > This setting may be different in SPL and TPL. Update the code to check
> > > the correct setting.
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > >
> > > lib/fdtdec.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Reverting this commit fixes booting.
> >
> > Thanks for the report. I'm about to push a revert for this and I'll add
> > a Reported-by from you.
>
> I'm not sure what is going on here, but possibly we need to add
> TPL_SEPARATE_BSS to the board config..
Yes, that's the most likely case, I'm just not sure if we can
progmatically figure out what platforms are missing it.
--
Tom
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-18 13:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 14:05 [BUG] [BISECT] rockchip: roc-pc-rk3399: TPL misses dtb Markus Reichl
2021-02-15 15:11 ` Tom Rini
2021-02-18 4:45 ` Simon Glass
2021-02-18 13:05 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).