From: Martin Wilck <mwilck@suse.com>
To: Don Brace <don.brace@microchip.com>,
Kevin.Barnett@microchip.com, scott.teel@microchip.com,
Justin.Lindley@microchip.com, scott.benesh@microchip.com,
gerry.morong@microchip.com, mahesh.rajashekhara@microchip.com,
hch@infradead.org, jejb@linux.vnet.ibm.com,
joseph.szczypek@hpe.com, POSWALD@suse.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH V3 07/25] smartpqi: update AIO Sub Page 0x02 support
Date: Thu, 07 Jan 2021 17:44:55 +0100 [thread overview]
Message-ID: <d084a9fc0757a0f15e860dafe8179679ab620a5e.camel@suse.com> (raw)
In-Reply-To: <160763250110.26927.1557519699967861731.stgit@brunhilda>
On Thu, 2020-12-10 at 14:35 -0600, Don Brace wrote:
> From: Kevin Barnett <kevin.barnett@microchip.com>
>
> The specification for AIO Sub-Page (0x02) has changed slightly.
> * bring the driver into conformance with the spec.
>
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Signed-off-by: Kevin Barnett <kevin.barnett@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>
> ---
> drivers/scsi/smartpqi/smartpqi.h | 12 ++++---
> drivers/scsi/smartpqi/smartpqi_init.c | 60 +++++++++++++++++++++--
> ----------
> 2 files changed, 47 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/scsi/smartpqi/smartpqi.h
> b/drivers/scsi/smartpqi/smartpqi.h
> index 31281cddadfe..eb23c3cf59c0 100644
> --- a/drivers/scsi/smartpqi/smartpqi.h
> +++ b/drivers/scsi/smartpqi/smartpqi.h
> @@ -1028,13 +1028,13 @@ struct pqi_scsi_dev_raid_map_data {
> u8 cdb_length;
>
> /* RAID 1 specific */
> -#define NUM_RAID1_MAP_ENTRIES 3
> +#define NUM_RAID1_MAP_ENTRIES 3
> u32 num_it_nexus_entries;
> u32 it_nexus[NUM_RAID1_MAP_ENTRIES];
>
> /* RAID 5 / RAID 6 specific */
> - u32 p_parity_it_nexus; /* aio_handle */
> - u32 q_parity_it_nexus; /* aio_handle */
> + u32 p_parity_it_nexus; /* aio_handle */
> + u32 q_parity_it_nexus; /* aio_handle */
> u8 xor_mult;
> u64 row;
> u64 stripe_lba;
> @@ -1044,6 +1044,7 @@ struct pqi_scsi_dev_raid_map_data {
>
> #define RAID_CTLR_LUNID "\0\0\0\0\0\0\0\0"
>
> +
> struct pqi_scsi_dev {
> int devtype; /* as reported by INQUIRY
> commmand */
> u8 device_type; /* as reported by */
> @@ -1302,7 +1303,8 @@ struct pqi_ctrl_info {
> u32 max_transfer_encrypted_sas_sata;
> u32 max_transfer_encrypted_nvme;
> u32 max_write_raid_5_6;
> -
> + u32 max_write_raid_1_10_2drive;
> + u32 max_write_raid_1_10_3drive;
>
> struct list_head scsi_device_list;
> spinlock_t scsi_device_list_lock;
> @@ -1533,6 +1535,8 @@ struct bmic_sense_feature_io_page_aio_subpage {
> __le16 max_transfer_encrypted_sas_sata;
> __le16 max_transfer_encrypted_nvme;
> __le16 max_write_raid_5_6;
> + __le16 max_write_raid_1_10_2drive;
> + __le16 max_write_raid_1_10_3drive;
> };
>
> struct bmic_smp_request {
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
> b/drivers/scsi/smartpqi/smartpqi_init.c
> index aa21c1cd2cac..419887aa8ff3 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -696,6 +696,19 @@ static int pqi_identify_physical_device(struct
> pqi_ctrl_info *ctrl_info,
> return rc;
> }
>
> +static inline u32 pqi_aio_limit_to_bytes(__le16 *limit)
> +{
> + u32 bytes;
> +
> + bytes = get_unaligned_le16(limit);
> + if (bytes == 0)
> + bytes = ~0;
> + else
> + bytes *= 1024;
> +
> + return bytes;
> +}
Nice, but this function and it's callers belong into patch 06/25.
> +
> #pragma pack(1)
>
> struct bmic_sense_feature_buffer {
> @@ -707,11 +720,11 @@ struct bmic_sense_feature_buffer {
>
> #define MINIMUM_AIO_SUBPAGE_BUFFER_LENGTH \
> offsetofend(struct bmic_sense_feature_buffer, \
> - aio_subpage.max_write_raid_5_6)
> + aio_subpage.max_write_raid_1_10_3drive)
>
> #define MINIMUM_AIO_SUBPAGE_LENGTH \
> (offsetofend(struct bmic_sense_feature_io_page_aio_subpage, \
> - max_write_raid_5_6) - \
> + max_write_raid_1_10_3drive) - \
> sizeof_field(struct
> bmic_sense_feature_io_page_aio_subpage, header))
>
> static int pqi_get_advanced_raid_bypass_config(struct pqi_ctrl_info
> *ctrl_info)
> @@ -753,33 +766,28 @@ static int
> pqi_get_advanced_raid_bypass_config(struct pqi_ctrl_info *ctrl_info)
> BMIC_SENSE_FEATURE_IO_PAGE_AIO_SUBPAGE ||
> get_unaligned_le16(&buffer-
> >aio_subpage.header.page_length) <
> MINIMUM_AIO_SUBPAGE_LENGTH) {
> - rc = -EINVAL;
This should be changed in 06/25.
> goto error;
> }
>
Regards
Martin
next prev parent reply other threads:[~2021-01-07 16:45 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 20:34 [PATCH V3 00/25] smartpqi updates Don Brace
2020-12-10 20:34 ` [PATCH V3 01/25] smartpqi: add support for product id Don Brace
2021-01-07 16:43 ` Martin Wilck
2020-12-10 20:34 ` [PATCH V3 02/25] smartpqi: refactor aio submission code Don Brace
2021-01-07 16:43 ` Martin Wilck
2020-12-10 20:34 ` [PATCH V3 03/25] smartpqi: refactor build sg list code Don Brace
2021-01-07 16:43 ` Martin Wilck
2020-12-10 20:34 ` [PATCH V3 04/25] smartpqi: add support for raid5 and raid6 writes Don Brace
2021-01-07 16:44 ` Martin Wilck
2021-01-08 22:56 ` Don.Brace
2021-01-13 10:26 ` Martin Wilck
2020-12-10 20:34 ` [PATCH V3 05/25] smartpqi: add support for raid1 writes Don Brace
2021-01-07 16:44 ` Martin Wilck
2021-01-09 16:56 ` Don.Brace
2020-12-10 20:34 ` [PATCH V3 06/25] smartpqi: add support for BMIC sense feature cmd and feature bits Don Brace
2021-01-07 16:44 ` Martin Wilck
2021-01-11 17:22 ` Don.Brace
2021-01-22 16:45 ` Don.Brace
2021-01-22 19:04 ` Martin Wilck
2020-12-10 20:35 ` [PATCH V3 07/25] smartpqi: update AIO Sub Page 0x02 support Don Brace
2021-01-07 16:44 ` Martin Wilck [this message]
2021-01-11 20:53 ` Don.Brace
2020-12-10 20:35 ` [PATCH V3 08/25] smartpqi: add support for long firmware version Don Brace
2021-01-07 16:45 ` Martin Wilck
2021-01-11 22:25 ` Don.Brace
2021-01-22 20:01 ` Don.Brace
2020-12-10 20:35 ` [PATCH V3 09/25] smartpqi: align code with oob driver Don Brace
2021-01-08 0:13 ` Martin Wilck
2020-12-10 20:35 ` [PATCH V3 10/25] smartpqi: add stream detection Don Brace
2021-01-08 0:14 ` Martin Wilck
2021-01-15 21:58 ` Don.Brace
2020-12-10 20:35 ` [PATCH V3 11/25] smartpqi: add host level stream detection enable Don Brace
2021-01-08 0:13 ` Martin Wilck
2021-01-12 20:28 ` Don.Brace
2020-12-10 20:35 ` [PATCH V3 12/25] smartpqi: enable support for NVMe encryption Don Brace
2021-01-08 0:14 ` Martin Wilck
2020-12-10 20:35 ` [PATCH V3 13/25] smartpqi: disable write_same for nvme hba disks Don Brace
2021-01-08 0:13 ` Martin Wilck
2020-12-10 20:35 ` [PATCH V3 14/25] smartpqi: fix driver synchronization issues Don Brace
2021-01-07 23:32 ` Martin Wilck
2021-01-08 4:13 ` Martin K. Petersen
2021-01-15 21:13 ` Don.Brace
2021-01-27 23:01 ` Don.Brace
[not found] ` <c1e6b199f5ccda5ccec5223dfcbd1fba22171c86.camel@suse.com>
2021-02-01 22:47 ` Don.Brace
2020-12-10 20:35 ` [PATCH V3 15/25] smartpqi: fix host qdepth limit Don Brace
2020-12-14 17:54 ` Paul Menzel
2020-12-15 20:23 ` Don.Brace
2021-01-07 23:43 ` Martin Wilck
2021-01-15 21:17 ` Don.Brace
2021-01-19 10:33 ` John Garry
2021-01-19 14:12 ` Martin Wilck
2021-01-19 17:43 ` Paul Menzel
2021-01-20 16:42 ` Donald Buczek
2021-01-20 17:03 ` Don.Brace
2021-01-20 18:35 ` Martin Wilck
2021-02-10 15:27 ` Don.Brace
2021-02-10 15:42 ` John Garry
2021-02-10 16:29 ` Don.Brace
2021-03-29 21:15 ` Paul Menzel
2021-03-29 21:16 ` Paul Menzel
2021-03-30 14:37 ` Donald Buczek
2020-12-10 20:35 ` [PATCH V3 16/25] smartpqi: convert snprintf to scnprintf Don Brace
2021-01-07 23:51 ` Martin Wilck
2020-12-10 20:35 ` [PATCH V3 17/25] smartpqi: change timing of release of QRM memory during OFA Don Brace
2021-01-08 0:14 ` Martin Wilck
2021-01-27 17:46 ` Don.Brace
2020-12-10 20:36 ` [PATCH V3 18/25] smartpqi: return busy indication for IOCTLs when ofa is active Don Brace
2020-12-10 20:36 ` [PATCH V3 19/25] smartpqi: add phy id support for the physical drives Don Brace
2021-01-08 0:03 ` Martin Wilck
2020-12-10 20:36 ` [PATCH V3 20/25] smartpqi: update sas initiator_port_protocols and target_port_protocols Don Brace
2021-01-08 0:12 ` Martin Wilck
2020-12-10 20:36 ` [PATCH V3 21/25] smartpqi: add additional logging for LUN resets Don Brace
2021-01-08 0:27 ` Martin Wilck
2021-01-25 17:09 ` Don.Brace
2020-12-10 20:36 ` [PATCH V3 22/25] smartpqi: update enclosure identifier in sysf Don Brace
2021-01-08 0:30 ` Martin Wilck
2021-01-25 17:13 ` Don.Brace
2021-01-25 19:44 ` Martin Wilck
2021-01-25 20:36 ` Don.Brace
2020-12-10 20:36 ` [PATCH V3 23/25] smartpqi: correct system hangs when resuming from hibernation Don Brace
2021-01-08 0:34 ` Martin Wilck
2021-01-27 17:39 ` Don.Brace
2021-01-27 17:45 ` Martin Wilck
2020-12-10 20:36 ` [PATCH V3 24/25] smartpqi: add new pci ids Don Brace
2021-01-08 0:35 ` Martin Wilck
2020-12-10 20:36 ` [PATCH V3 25/25] smartpqi: update version to 2.1.6-005 Don Brace
2020-12-21 14:31 ` [PATCH V3 00/25] smartpqi updates Donald Buczek
[not found] ` <SN6PR11MB2848D8C9DF9856A2B7AA69ACE1C00@SN6PR11MB2848.namprd11.prod.outlook.com>
2020-12-22 13:13 ` Donald Buczek
2020-12-28 15:57 ` Don.Brace
2020-12-28 19:25 ` Don.Brace
2020-12-28 22:36 ` Donald Buczek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d084a9fc0757a0f15e860dafe8179679ab620a5e.camel@suse.com \
--to=mwilck@suse.com \
--cc=Justin.Lindley@microchip.com \
--cc=Kevin.Barnett@microchip.com \
--cc=POSWALD@suse.com \
--cc=don.brace@microchip.com \
--cc=gerry.morong@microchip.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=joseph.szczypek@hpe.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mahesh.rajashekhara@microchip.com \
--cc=scott.benesh@microchip.com \
--cc=scott.teel@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).