* [PATCH] soc/tegra: pmc: Add EQOS wake event for Tegra194 and Tegra234
@ 2024-04-03 11:42 Jon Hunter
2024-04-08 16:00 ` Thierry Reding
2024-04-26 15:41 ` Thierry Reding
0 siblings, 2 replies; 4+ messages in thread
From: Jon Hunter @ 2024-04-03 11:42 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-tegra, Jon Hunter
Add the wake event for the EQOS ethernet controller on Tegra194 and
Tegra234 devices, so that system can be woken up by an event from this
ethernet controller.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/soc/tegra/pmc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index d6bfcea5ee65..91d0ad6ddefc 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -4074,6 +4074,7 @@ static const char * const tegra194_reset_sources[] = {
};
static const struct tegra_wake_event tegra194_wake_events[] = {
+ TEGRA_WAKE_GPIO("eqos", 20, 0, TEGRA194_MAIN_GPIO(G, 4)),
TEGRA_WAKE_IRQ("pmu", 24, 209),
TEGRA_WAKE_GPIO("power", 29, 1, TEGRA194_AON_GPIO(EE, 4)),
TEGRA_WAKE_IRQ("rtc", 73, 10),
@@ -4210,6 +4211,7 @@ static const char * const tegra234_reset_sources[] = {
static const struct tegra_wake_event tegra234_wake_events[] = {
TEGRA_WAKE_GPIO("sd-wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),
+ TEGRA_WAKE_GPIO("eqos", 20, 0, TEGRA234_MAIN_GPIO(G, 4)),
TEGRA_WAKE_IRQ("pmu", 24, 209),
TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] soc/tegra: pmc: Add EQOS wake event for Tegra194 and Tegra234
2024-04-03 11:42 [PATCH] soc/tegra: pmc: Add EQOS wake event for Tegra194 and Tegra234 Jon Hunter
@ 2024-04-08 16:00 ` Thierry Reding
2024-04-09 7:20 ` Jon Hunter
2024-04-26 15:41 ` Thierry Reding
1 sibling, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2024-04-08 16:00 UTC (permalink / raw)
To: Jon Hunter; +Cc: linux-tegra
[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]
On Wed Apr 3, 2024 at 1:42 PM CEST, Jon Hunter wrote:
> Add the wake event for the EQOS ethernet controller on Tegra194 and
> Tegra234 devices, so that system can be woken up by an event from this
> ethernet controller.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/soc/tegra/pmc.c | 2 ++
> 1 file changed, 2 insertions(+)
I don't think we've ever tested the EQOS on Tegra234 because all of the
upstream-supported platforms only make use of the MGBE. Do we have any
platforms where we need this on Tegra234? Also, do we perhaps want to
add an wake event for MGBE?
That's not to say that I reject this, just that it doesn't currently
seem to make sense for Tegra234.
Thierry
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index d6bfcea5ee65..91d0ad6ddefc 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -4074,6 +4074,7 @@ static const char * const tegra194_reset_sources[] = {
> };
>
> static const struct tegra_wake_event tegra194_wake_events[] = {
> + TEGRA_WAKE_GPIO("eqos", 20, 0, TEGRA194_MAIN_GPIO(G, 4)),
> TEGRA_WAKE_IRQ("pmu", 24, 209),
> TEGRA_WAKE_GPIO("power", 29, 1, TEGRA194_AON_GPIO(EE, 4)),
> TEGRA_WAKE_IRQ("rtc", 73, 10),
> @@ -4210,6 +4211,7 @@ static const char * const tegra234_reset_sources[] = {
>
> static const struct tegra_wake_event tegra234_wake_events[] = {
> TEGRA_WAKE_GPIO("sd-wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),
> + TEGRA_WAKE_GPIO("eqos", 20, 0, TEGRA234_MAIN_GPIO(G, 4)),
> TEGRA_WAKE_IRQ("pmu", 24, 209),
> TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
> TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc/tegra: pmc: Add EQOS wake event for Tegra194 and Tegra234
2024-04-08 16:00 ` Thierry Reding
@ 2024-04-09 7:20 ` Jon Hunter
0 siblings, 0 replies; 4+ messages in thread
From: Jon Hunter @ 2024-04-09 7:20 UTC (permalink / raw)
To: Thierry Reding; +Cc: linux-tegra
On 08/04/2024 17:00, Thierry Reding wrote:
> On Wed Apr 3, 2024 at 1:42 PM CEST, Jon Hunter wrote:
>> Add the wake event for the EQOS ethernet controller on Tegra194 and
>> Tegra234 devices, so that system can be woken up by an event from this
>> ethernet controller.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> drivers/soc/tegra/pmc.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> I don't think we've ever tested the EQOS on Tegra234 because all of the
> upstream-supported platforms only make use of the MGBE. Do we have any
> platforms where we need this on Tegra234? Also, do we perhaps want to
> add an wake event for MGBE?
Yes, the Drive platforms [0] support EQOS for Tegra234. Although there
is no device-tree upstream for Drive, I think that it is good to include
this. Obviously we should have it for the Tegra194 platforms that are
upstream and so we may as well included Tegra234.
BTW, we already have the MGBE wake-up event upstream for Tegra234 [1]
and from what I can tell this is the only wake-up event that is
currently missing.
Jon
[0] https://developer.nvidia.com/drive/agx
[1] cc026ccdd502 ("soc/tegra: pmc: Add wake source interrupt for MGBE")
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc/tegra: pmc: Add EQOS wake event for Tegra194 and Tegra234
2024-04-03 11:42 [PATCH] soc/tegra: pmc: Add EQOS wake event for Tegra194 and Tegra234 Jon Hunter
2024-04-08 16:00 ` Thierry Reding
@ 2024-04-26 15:41 ` Thierry Reding
1 sibling, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2024-04-26 15:41 UTC (permalink / raw)
To: Thierry Reding, Jon Hunter; +Cc: linux-tegra
From: Thierry Reding <treding@nvidia.com>
On Wed, 03 Apr 2024 12:42:08 +0100, Jon Hunter wrote:
> Add the wake event for the EQOS ethernet controller on Tegra194 and
> Tegra234 devices, so that system can be woken up by an event from this
> ethernet controller.
>
>
Applied, thanks!
[1/1] soc/tegra: pmc: Add EQOS wake event for Tegra194 and Tegra234
(no commit info)
Best regards,
--
Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-26 15:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-03 11:42 [PATCH] soc/tegra: pmc: Add EQOS wake event for Tegra194 and Tegra234 Jon Hunter
2024-04-08 16:00 ` Thierry Reding
2024-04-09 7:20 ` Jon Hunter
2024-04-26 15:41 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).