From: Kevin Locke <kevin@kevinlocke.name>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH] ovl: fix NULL pointer dereference
Date: Wed, 12 Jan 2022 13:58:30 -0700 [thread overview]
Message-ID: <Yd9A9g9nsjwmbZtm@kevinlocke.name> (raw)
In-Reply-To: <c3ede9cee662964c174fdccc0039df8fa0a2be9b.camel@googlemail.com>
Hi Christoph,
On Wed, 2022-01-12 at 19:46 +0100, Christoph Fritz wrote:
> On Wed, 2022-01-12 at 19:33 +0100, Christoph Fritz wrote:
>> This patch is fixing a NULL pointer dereference to get a recently
>> introduced warning message working.
Good catch!
> With that patch applied, a lot of these are popping up now:
>
> [ 7.132514] overlayfs: failed to retrieve upper fileattr (index/#26, err=-25)
>
> [...]
>
> These have been -ENOIOCTLCMD errors but got (falsely?) converted to
> -ENOTTY by the recently introduced commit 5b0a414d06c3 ("ovl: fix filattr copy-up failure"):
Which filesystem are you using for upper (and lower) in your mount?
Presumably the upper doesn't support file attributes, if it returns
-ENOIOCTLCMD? If so, I guess the question would be what behavior
overlayfs should have when attributes can't be copied from lower to
upper, which is actually a question Miklos raised when that commit was
being worked on![^1] Perhaps your use case can help inform a good
answer.
Cheers,
Kevin
[^1]: https://lore.kernel.org/linux-unionfs/CAJfpegsRo3e-9B64W37YrmvDcjo0QB9t+coAW3mO6TSqdROz2w@mail.gmail.com/
next prev parent reply other threads:[~2022-01-12 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 18:33 [PATCH] ovl: fix NULL pointer dereference Christoph Fritz
2022-01-12 18:46 ` Christoph Fritz
2022-01-12 20:28 ` Christoph Fritz
2022-01-14 16:01 ` Miklos Szeredi
2022-01-12 20:58 ` Kevin Locke [this message]
2022-01-12 21:06 ` Christoph Fritz
2022-01-12 22:25 ` Kevin Locke
2022-01-13 23:21 ` Christoph Fritz
2022-01-14 15:59 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd9A9g9nsjwmbZtm@kevinlocke.name \
--to=kevin@kevinlocke.name \
--cc=chf.fritz@googlemail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).