From: Kevin Locke <kevin@kevinlocke.name>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH] ovl: fix NULL pointer dereference
Date: Wed, 12 Jan 2022 15:25:48 -0700 [thread overview]
Message-ID: <Yd9VbP3ruJNQbJsA@kevinlocke.name> (raw)
In-Reply-To: <61820434137bd1be48b58cb25fcd4366db26a794.camel@googlemail.com>
On Wed, 2022-01-12 at 22:06 +0100, Christoph Fritz wrote:
>>> These have been -ENOIOCTLCMD errors but got (falsely?) converted to
>>> -ENOTTY by the recently introduced commit 5b0a414d06c3 ("ovl: fix
>>> filattr copy-up failure"):
>>
>> Which filesystem are you using for upper (and lower) in your mount?
>
>
> It's tmpfs.
>
>> Presumably the upper doesn't support file attributes, if it returns
>> -ENOIOCTLCMD?
>
>
> Tmpfs does support file attributes.
Although tmpfs can support extended attributes (attr(1)/xattr(7)) with
CONFIG_TMPFS_XATTR, I'm not aware of support for traditional
attributes (chattr(1)). I'm also not able to reproduce the error
message you mentioned with extended attributes. With your patch[^1]
applied to 5.16, I ran the following:
mkdir lower upwork overlay
mount -t tmpfs - lower
mount -t tmpfs - upwork
mkdir upwork/upper upwork/work
touch lower/file.txt
setfacl -m 'u:0:rwx' lower/file.txt
mount -t overlay -o "lowerdir=$PWD/lower,upperdir=$PWD/upwork/upper,workdir=$PWD/upwork/work" - overlay
mv overlay/file.txt overlay/file2.txt
getfattr -d -m '.*' overlay/file2.txt
This copied file.txt from lower to upper with the
system.posix_acl_access extended attribute and did not print any
messages from overlayfs to the kernel log.
Could you provide a minimal, reproducible example for the log messages
you mentioned observing?
Thanks,
Kevin
[^1]: https://lore.kernel.org/linux-unionfs/10d8ed194b934c298713ad7f0958329b46573dd1.camel@googlemail.com/
next prev parent reply other threads:[~2022-01-12 22:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 18:33 [PATCH] ovl: fix NULL pointer dereference Christoph Fritz
2022-01-12 18:46 ` Christoph Fritz
2022-01-12 20:28 ` Christoph Fritz
2022-01-14 16:01 ` Miklos Szeredi
2022-01-12 20:58 ` Kevin Locke
2022-01-12 21:06 ` Christoph Fritz
2022-01-12 22:25 ` Kevin Locke [this message]
2022-01-13 23:21 ` Christoph Fritz
2022-01-14 15:59 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd9VbP3ruJNQbJsA@kevinlocke.name \
--to=kevin@kevinlocke.name \
--cc=chf.fritz@googlemail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).