From: Christoph Fritz <chf.fritz@googlemail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Kevin Locke <kevin@kevinlocke.name>, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH] ovl: fix NULL pointer dereference
Date: Wed, 12 Jan 2022 19:46:43 +0100 [thread overview]
Message-ID: <c3ede9cee662964c174fdccc0039df8fa0a2be9b.camel@googlemail.com> (raw)
In-Reply-To: <10d8ed194b934c298713ad7f0958329b46573dd1.camel@googlemail.com>
Hello Miklos
On Wed, 2022-01-12 at 19:33 +0100, Christoph Fritz wrote:
> This patch is fixing a NULL pointer dereference to get a recently
> introduced warning message working.
With that patch applied, a lot of these are popping up now:
[ 7.132514] overlayfs: failed to retrieve upper fileattr (index/#26, err=-25)
[ 7.141520] overlayfs: failed to retrieve upper fileattr (index/#27, err=-25)
[ 8.699070] overlayfs: failed to retrieve upper fileattr (index/#7, err=-25)
[ 8.715804] overlayfs: failed to retrieve upper fileattr (index/#8, err=-25)
[ 8.723218] overlayfs: failed to retrieve upper fileattr (index/#9, err=-25)
[ 8.829887] overlayfs: failed to retrieve upper fileattr (index/#43, err=-25)
[ 9.387676] overlayfs: failed to retrieve upper fileattr (index/#a, err=-25)
[ 9.667531] overlayfs: failed to retrieve upper fileattr (index/#b, err=-25)
[ 9.874005] overlayfs: failed to retrieve upper fileattr (index/#c, err=-25)
[ 9.934664] overlayfs: failed to retrieve upper fileattr (index/#58, err=-25)
[ 9.942036] overlayfs: failed to retrieve upper fileattr (index/#59, err=-25)
[ 9.949406] overlayfs: failed to retrieve upper fileattr (index/#60, err=-25)
[ 9.956738] overlayfs: failed to retrieve upper fileattr (index/#61, err=-25)
[ 10.311610] overlayfs: failed to retrieve upper fileattr (index/#d, err=-25)
[ 10.712019] overlayfs: failed to retrieve upper fileattr (index/#e, err=-25)
[ 31.901577] overlayfs: failed to retrieve upper fileattr (index/#64, err=-25)
These have been -ENOIOCTLCMD errors but got (falsely?) converted to
-ENOTTY by the recently introduced commit 5b0a414d06c3 ("ovl: fix filattr copy-up failure"):
+ if (err == -ENOIOCTLCMD)
+ err = -ENOTTY;
Any ideas?
Thanks
-- Christoph
next prev parent reply other threads:[~2022-01-12 18:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 18:33 [PATCH] ovl: fix NULL pointer dereference Christoph Fritz
2022-01-12 18:46 ` Christoph Fritz [this message]
2022-01-12 20:28 ` Christoph Fritz
2022-01-14 16:01 ` Miklos Szeredi
2022-01-12 20:58 ` Kevin Locke
2022-01-12 21:06 ` Christoph Fritz
2022-01-12 22:25 ` Kevin Locke
2022-01-13 23:21 ` Christoph Fritz
2022-01-14 15:59 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3ede9cee662964c174fdccc0039df8fa0a2be9b.camel@googlemail.com \
--to=chf.fritz@googlemail.com \
--cc=kevin@kevinlocke.name \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).