From: Doug Anderson <dianders@chromium.org> To: Minas Harutyunyan <hminas@synopsys.com>, Felipe Balbi <felipe.balbi@linux.intel.com>, heiko@sntech.de Cc: Alan Stern <stern@rowland.harvard.edu>, Artur Petrosyan <Arthur.Petrosyan@synopsys.com>, amstan@chromium.org, linux-rockchip@lists.infradead.org, William Wu <william.wu@rock-chips.com>, linux-usb@vger.kernel.org, Stefan Wahren <stefan.wahren@i2se.com>, Randy Li <ayaka@soulik.info>, zyw@rock-chips.com, mka@chromium.org, ryandcase@chromium.org, Amelie Delaunay <amelie.delaunay@st.com>, jwerner@chromium.org, dinguyen@opensource.altera.com, Elaine Zhang <zhangqing@rock-chips.com>, Douglas Anderson <dianders@chromium.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mark Rutland <mark.rutland@arm.com> Subject: [v2,3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB Date: Wed, 17 Apr 2019 17:13:54 -0700 [thread overview] Message-ID: <20190418001356.124334-4-dianders@chromium.org> (raw) Some SoCs with a dwc2 USB controller may need to keep the PHY on to support remote wakeup. Allow specifying this as a device tree property. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- For relevant prior discussion on this patch, see: https://lkml.kernel.org/r/1435017144-2971-3-git-send-email-dianders@chromium.org I didn't make any changes from the prior version since I never found out what Rob thought of my previous arguments. If folks want a change, perhaps they could choose from these options: 1. Assume that all dwc2 hosts would like to keep their PHY on for suspend if there's a USB wakeup enabled, thus we totally drop this binding. This doesn't seem super great to me since I'd bet that many devices that use dwc2 weren't designed for USB wakeup (they may not keep enough clocks or rails on) so we might be wasting power for nothing. 2. Rename this property to "snps,wakeup-from-suspend-with-phy" to make it more obvious that this property is intended both to document that wakeup from suspend is possible and that we need the PHY for said wakeup. 3. Rename this property to "snps,can-wakeup-from-suspend" and assume it's implicit that if we can wakeup from suspend that we need to keep the PHY on. If/when someone shows that a device exists using dwc2 where we can wakeup from suspend without the PHY they can add a new property. Changes in v2: None Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt index f70f3aee4bfc..1c5e29d23c51 100644 --- a/Documentation/devicetree/bindings/usb/dwc2.txt +++ b/Documentation/devicetree/bindings/usb/dwc2.txt @@ -37,6 +37,8 @@ Refer to phy/phy-bindings.txt for generic phy consumer properties - g-rx-fifo-size: size of rx fifo size in gadget mode. - g-np-tx-fifo-size: size of non-periodic tx fifo size in gadget mode. - g-tx-fifo-size: size of periodic tx fifo per endpoint (except ep0) in gadget mode. +- snps,need-phy-for-wake: If present indicates that the phy needs to be left + on for remote wakeup during suspend. - snps,reset-phy-on-wake: If present indicates that we need to reset the PHY when we detect a wakeup. This is due to a hardware errata. @@ -53,4 +55,5 @@ Example: clock-names = "otg"; phys = <&usbphy>; phy-names = "usb2-phy"; + snps,need-phy-for-wake; };
WARNING: multiple messages have this Message-ID (diff)
From: Douglas Anderson <dianders@chromium.org> To: Minas Harutyunyan <hminas@synopsys.com>, Felipe Balbi <felipe.balbi@linux.intel.com>, heiko@sntech.de Cc: Alan Stern <stern@rowland.harvard.edu>, Artur Petrosyan <Arthur.Petrosyan@synopsys.com>, amstan@chromium.org, linux-rockchip@lists.infradead.org, William Wu <william.wu@rock-chips.com>, linux-usb@vger.kernel.org, Stefan Wahren <stefan.wahren@i2se.com>, Randy Li <ayaka@soulik.info>, zyw@rock-chips.com, mka@chromium.org, ryandcase@chromium.org, Amelie Delaunay <amelie.delaunay@st.com>, jwerner@chromium.org, dinguyen@opensource.altera.com, Elaine Zhang <zhangqing@rock-chips.com>, Douglas Anderson <dianders@chromium.org>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mark Rutland <mark.rutland@arm.com> Subject: [PATCH v2 3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB Date: Wed, 17 Apr 2019 17:13:54 -0700 [thread overview] Message-ID: <20190418001356.124334-4-dianders@chromium.org> (raw) Message-ID: <20190418001354.2ZgW0wE-HkIbQKtBAEHc0CuaQ1OPE6vouTDqr8Unh0M@z> (raw) In-Reply-To: <20190418001356.124334-1-dianders@chromium.org> Some SoCs with a dwc2 USB controller may need to keep the PHY on to support remote wakeup. Allow specifying this as a device tree property. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- For relevant prior discussion on this patch, see: https://lkml.kernel.org/r/1435017144-2971-3-git-send-email-dianders@chromium.org I didn't make any changes from the prior version since I never found out what Rob thought of my previous arguments. If folks want a change, perhaps they could choose from these options: 1. Assume that all dwc2 hosts would like to keep their PHY on for suspend if there's a USB wakeup enabled, thus we totally drop this binding. This doesn't seem super great to me since I'd bet that many devices that use dwc2 weren't designed for USB wakeup (they may not keep enough clocks or rails on) so we might be wasting power for nothing. 2. Rename this property to "snps,wakeup-from-suspend-with-phy" to make it more obvious that this property is intended both to document that wakeup from suspend is possible and that we need the PHY for said wakeup. 3. Rename this property to "snps,can-wakeup-from-suspend" and assume it's implicit that if we can wakeup from suspend that we need to keep the PHY on. If/when someone shows that a device exists using dwc2 where we can wakeup from suspend without the PHY they can add a new property. Changes in v2: None Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt index f70f3aee4bfc..1c5e29d23c51 100644 --- a/Documentation/devicetree/bindings/usb/dwc2.txt +++ b/Documentation/devicetree/bindings/usb/dwc2.txt @@ -37,6 +37,8 @@ Refer to phy/phy-bindings.txt for generic phy consumer properties - g-rx-fifo-size: size of rx fifo size in gadget mode. - g-np-tx-fifo-size: size of non-periodic tx fifo size in gadget mode. - g-tx-fifo-size: size of periodic tx fifo per endpoint (except ep0) in gadget mode. +- snps,need-phy-for-wake: If present indicates that the phy needs to be left + on for remote wakeup during suspend. - snps,reset-phy-on-wake: If present indicates that we need to reset the PHY when we detect a wakeup. This is due to a hardware errata. @@ -53,4 +55,5 @@ Example: clock-names = "otg"; phys = <&usbphy>; phy-names = "usb2-phy"; + snps,need-phy-for-wake; }; -- 2.21.0.593.g511ec345e18-goog
next prev reply other threads:[~2019-04-18 0:13 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-18 0:13 [PATCH v2 0/5] USB: dwc2: Allow wakeup from suspend; enable for rk3288-veyron Douglas Anderson 2019-04-18 0:13 ` [v2,1/5] usb: dwc2: bus suspend/resume for hosts with DWC2_POWER_DOWN_PARAM_NONE Doug Anderson 2019-04-18 0:13 ` [PATCH v2 1/5] " Douglas Anderson 2019-04-29 8:43 ` [v2,1/5] " Artur Petrosyan 2019-04-29 8:43 ` [PATCH v2 1/5] " Artur Petrosyan 2019-04-29 17:33 ` [v2,1/5] " Doug Anderson 2019-04-29 17:33 ` [PATCH v2 1/5] " Doug Anderson 2019-04-30 6:05 ` [v2,1/5] " Artur Petrosyan 2019-04-30 6:05 ` [PATCH v2 1/5] " Artur Petrosyan 2019-05-01 1:51 ` [v2,1/5] " Doug Anderson 2019-05-01 1:51 ` [PATCH v2 1/5] " Doug Anderson 2019-05-03 8:20 ` [v2,1/5] " Artur Petrosyan 2019-05-03 8:20 ` [PATCH v2 1/5] " Artur Petrosyan 2019-05-03 15:03 ` [v2,1/5] " Doug Anderson 2019-05-03 15:03 ` [PATCH v2 1/5] " Doug Anderson 2019-05-07 7:26 ` Artur Petrosyan 2019-05-01 23:58 ` [v2,1/5] " Doug Anderson 2019-05-01 23:58 ` [PATCH v2 1/5] " Doug Anderson 2019-05-03 8:25 ` [v2,1/5] " Artur Petrosyan 2019-05-03 8:25 ` [PATCH v2 1/5] " Artur Petrosyan 2019-05-03 15:07 ` [v2,1/5] " Doug Anderson 2019-05-03 15:07 ` [PATCH v2 1/5] " Doug Anderson 2019-05-07 7:05 ` Artur Petrosyan 2019-04-18 0:13 ` [v2,2/5] USB: Export usb_wakeup_enabled_descendants() Doug Anderson 2019-04-18 0:13 ` [PATCH v2 2/5] " Douglas Anderson 2019-04-18 0:13 ` Doug Anderson [this message] 2019-04-18 0:13 ` [PATCH v2 3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB Douglas Anderson 2019-04-25 12:40 ` [v2,3/5] " Felipe Balbi 2019-04-25 12:40 ` [PATCH v2 3/5] " Felipe Balbi 2019-04-25 18:09 ` [v2,3/5] " Doug Anderson 2019-04-25 18:09 ` [PATCH v2 3/5] " Doug Anderson 2019-04-25 19:58 ` [v2,3/5] " Doug Anderson 2019-04-25 19:58 ` [PATCH v2 3/5] " Doug Anderson 2019-05-02 18:36 ` [v2,3/5] " Doug Anderson 2019-05-02 18:36 ` [PATCH v2 3/5] " Doug Anderson 2019-04-30 1:23 ` [v2,3/5] " Rob Herring 2019-04-30 1:23 ` [PATCH v2 3/5] " Rob Herring 2019-04-30 5:25 ` [v2,3/5] " Doug Anderson 2019-04-30 5:25 ` [PATCH v2 3/5] " Doug Anderson 2019-04-18 0:13 ` [v2,4/5] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled Doug Anderson 2019-04-18 0:13 ` [PATCH v2 4/5] " Douglas Anderson 2019-04-25 12:41 ` [v2,4/5] " Felipe Balbi 2019-04-25 12:41 ` [PATCH v2 4/5] " Felipe Balbi 2019-04-18 0:13 ` [v2,5/5] ARM: dts: rockchip: Allow wakeup from rk3288-veyron's dwc2 USB ports Doug Anderson 2019-04-18 0:13 ` [PATCH v2 5/5] " Douglas Anderson 2019-04-18 12:40 ` [PATCH v2 0/5] USB: dwc2: Allow wakeup from suspend; enable for rk3288-veyron Minas Harutyunyan 2019-04-18 15:54 ` Doug Anderson 2019-04-19 11:43 ` Artur Petrosyan 2019-04-19 16:44 ` Artur Petrosyan 2019-04-22 15:50 ` Artur Petrosyan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190418001356.124334-4-dianders@chromium.org \ --to=dianders@chromium.org \ --cc=Arthur.Petrosyan@synopsys.com \ --cc=amelie.delaunay@st.com \ --cc=amstan@chromium.org \ --cc=ayaka@soulik.info \ --cc=devicetree@vger.kernel.org \ --cc=dinguyen@opensource.altera.com \ --cc=felipe.balbi@linux.intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=heiko@sntech.de \ --cc=hminas@synopsys.com \ --cc=jwerner@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mka@chromium.org \ --cc=robh+dt@kernel.org \ --cc=ryandcase@chromium.org \ --cc=stefan.wahren@i2se.com \ --cc=stern@rowland.harvard.edu \ --cc=william.wu@rock-chips.com \ --cc=zhangqing@rock-chips.com \ --cc=zyw@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).