From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Douglas Anderson <dianders@chromium.org>,
Minas Harutyunyan <hminas@synopsys.com>,
heiko@sntech.de
Cc: Alan Stern <stern@rowland.harvard.edu>,
Artur Petrosyan <Arthur.Petrosyan@synopsys.com>,
amstan@chromium.org, linux-rockchip@lists.infradead.org,
William Wu <william.wu@rock-chips.com>,
linux-usb@vger.kernel.org, Stefan Wahren <stefan.wahren@i2se.com>,
Randy Li <ayaka@soulik.info>,
zyw@rock-chips.com, mka@chromium.org, ryandcase@chromium.org,
Amelie Delaunay <amelie.delaunay@st.com>,
jwerner@chromium.org, dinguyen@opensource.altera.com,
Elaine Zhang <zhangqing@rock-chips.com>,
Douglas Anderson <dianders@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled
Date: Thu, 25 Apr 2019 15:41:50 +0300 [thread overview]
Message-ID: <87mukes1dd.fsf@linux.intel.com> (raw)
Message-ID: <20190425124150.ft8ccG4QR6YEgy9xFS4215s5Xp4nUtQBQZpu7gd6BaY@z> (raw)
In-Reply-To: <20190418001356.124334-5-dianders@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]
Douglas Anderson <dianders@chromium.org> writes:
> If the 'snps,need-phy-for-wake' is set in the device tree then:
>
> - We know that we can wakeup, so call device_set_wakeup_capable().
> The USB core will use this knowledge to enable wakeup by default.
> - We know that we should keep the PHY on during suspend if something
> on our root hub needs remote wakeup. This requires the patch (USB:
> Export usb_wakeup_enabled_descendants()). Note that we don't keep
> the PHY on at suspend time if it's not needed because it would be a
> power draw.
>
> If we later find some users of dwc2 that can support wakeup without
> keeping the PHY on we may want to add a way to call
> device_set_wakeup_capable() without keeping the PHY on at suspend
> time.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
checking file drivers/usb/dwc2/core.h
Hunk #1 FAILED at 861.
Hunk #2 FAILED at 1049.
2 out of 2 hunks FAILED
checking file drivers/usb/dwc2/platform.c
Hunk #3 FAILED at 487.
Hunk #4 succeeded at 513 (offset -9 lines).
Hunk #5 succeeded at 543 (offset -9 lines).
Hunk #6 succeeded at 556 (offset -9 lines).
1 out of 6 hunks FAILED
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-04-25 12:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 0:13 [PATCH v2 0/5] USB: dwc2: Allow wakeup from suspend; enable for rk3288-veyron Douglas Anderson
2019-04-18 0:13 ` [v2,1/5] usb: dwc2: bus suspend/resume for hosts with DWC2_POWER_DOWN_PARAM_NONE Doug Anderson
2019-04-18 0:13 ` [PATCH v2 1/5] " Douglas Anderson
2019-04-29 8:43 ` [v2,1/5] " Artur Petrosyan
2019-04-29 8:43 ` [PATCH v2 1/5] " Artur Petrosyan
2019-04-29 17:33 ` [v2,1/5] " Doug Anderson
2019-04-29 17:33 ` [PATCH v2 1/5] " Doug Anderson
2019-04-30 6:05 ` [v2,1/5] " Artur Petrosyan
2019-04-30 6:05 ` [PATCH v2 1/5] " Artur Petrosyan
2019-05-01 1:51 ` [v2,1/5] " Doug Anderson
2019-05-01 1:51 ` [PATCH v2 1/5] " Doug Anderson
2019-05-03 8:20 ` [v2,1/5] " Artur Petrosyan
2019-05-03 8:20 ` [PATCH v2 1/5] " Artur Petrosyan
2019-05-03 15:03 ` [v2,1/5] " Doug Anderson
2019-05-03 15:03 ` [PATCH v2 1/5] " Doug Anderson
2019-05-07 7:26 ` Artur Petrosyan
2019-05-01 23:58 ` [v2,1/5] " Doug Anderson
2019-05-01 23:58 ` [PATCH v2 1/5] " Doug Anderson
2019-05-03 8:25 ` [v2,1/5] " Artur Petrosyan
2019-05-03 8:25 ` [PATCH v2 1/5] " Artur Petrosyan
2019-05-03 15:07 ` [v2,1/5] " Doug Anderson
2019-05-03 15:07 ` [PATCH v2 1/5] " Doug Anderson
2019-05-07 7:05 ` Artur Petrosyan
2019-04-18 0:13 ` [v2,2/5] USB: Export usb_wakeup_enabled_descendants() Doug Anderson
2019-04-18 0:13 ` [PATCH v2 2/5] " Douglas Anderson
2019-04-18 0:13 ` [v2,3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB Doug Anderson
2019-04-18 0:13 ` [PATCH v2 3/5] " Douglas Anderson
2019-04-25 12:40 ` [v2,3/5] " Felipe Balbi
2019-04-25 12:40 ` [PATCH v2 3/5] " Felipe Balbi
2019-04-25 18:09 ` [v2,3/5] " Doug Anderson
2019-04-25 18:09 ` [PATCH v2 3/5] " Doug Anderson
2019-04-25 19:58 ` [v2,3/5] " Doug Anderson
2019-04-25 19:58 ` [PATCH v2 3/5] " Doug Anderson
2019-05-02 18:36 ` [v2,3/5] " Doug Anderson
2019-05-02 18:36 ` [PATCH v2 3/5] " Doug Anderson
2019-04-30 1:23 ` [v2,3/5] " Rob Herring
2019-04-30 1:23 ` [PATCH v2 3/5] " Rob Herring
2019-04-30 5:25 ` [v2,3/5] " Doug Anderson
2019-04-30 5:25 ` [PATCH v2 3/5] " Doug Anderson
2019-04-18 0:13 ` [v2,4/5] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled Doug Anderson
2019-04-18 0:13 ` [PATCH v2 4/5] " Douglas Anderson
2019-04-25 12:41 ` Felipe Balbi [this message]
2019-04-25 12:41 ` Felipe Balbi
2019-04-18 0:13 ` [v2,5/5] ARM: dts: rockchip: Allow wakeup from rk3288-veyron's dwc2 USB ports Doug Anderson
2019-04-18 0:13 ` [PATCH v2 5/5] " Douglas Anderson
2019-04-18 12:40 ` [PATCH v2 0/5] USB: dwc2: Allow wakeup from suspend; enable for rk3288-veyron Minas Harutyunyan
2019-04-18 15:54 ` Doug Anderson
2019-04-19 11:43 ` Artur Petrosyan
2019-04-19 16:44 ` Artur Petrosyan
2019-04-22 15:50 ` Artur Petrosyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mukes1dd.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=Arthur.Petrosyan@synopsys.com \
--cc=amelie.delaunay@st.com \
--cc=amstan@chromium.org \
--cc=ayaka@soulik.info \
--cc=dianders@chromium.org \
--cc=dinguyen@opensource.altera.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=hminas@synopsys.com \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=ryandcase@chromium.org \
--cc=stefan.wahren@i2se.com \
--cc=stern@rowland.harvard.edu \
--cc=william.wu@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).