linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-watchdog@vger.kernel.org,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 11/46] watchdog: digicolor_wdt: drop warning after registering device
Date: Sun, 19 May 2019 10:32:01 +0200	[thread overview]
Message-ID: <20190519083201.GA1003@kunai> (raw)
In-Reply-To: <87y3332dku.fsf@tarshish>

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]


> Do you consider that not important/likely enough to be worth an error
> message in the driver?

This can be discussed as a second step IMO.

I was looking at adding more error strings to the core but then wondered
if we really need error messages for e.g. IDA failures. And if so,
shouldn't those be in the IDA core. Do all IDA users want that?

(Sidenote: to the best of my knowledge, if memory allocation fails, it
will WARN you, so no need to print something in the driver.)

So, I took a step back and saw that watchdog drivers mostly print
"registration failed", not more. Some printed the error code.

This series simplifies the current behaviour. It does not extend it. We
can do that on top of it.

Thanks for the comment!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-05-19 17:27 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-18 21:27 [PATCH 00/46] watchdog: move 'registration failed' messages into core Wolfram Sang
2019-05-18 21:27 ` [PATCH 01/46] watchdog: make watchdog_deferred_registration_add() void Wolfram Sang
2019-05-18 21:27 ` [PATCH 02/46] watchdog: let core print error message when registering device fails Wolfram Sang
2019-05-18 21:27 ` [PATCH 03/46] watchdog: aspeed_wdt: drop warning after registering device Wolfram Sang
2019-05-20  0:53   ` Andrew Jeffery
2019-05-18 21:27 ` [PATCH 04/46] watchdog: bcm2835_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 05/46] watchdog: bcm7038_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 06/46] watchdog: bcm_kona_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 07/46] watchdog: cadence_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 08/46] watchdog: da9052_wdt: " Wolfram Sang
2019-05-20  7:59   ` Steve Twiss
2019-05-18 21:27 ` [PATCH 09/46] watchdog: da9062_wdt: " Wolfram Sang
2019-05-20  7:58   ` Steve Twiss
2019-05-18 21:27 ` [PATCH 10/46] watchdog: davinci_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 11/46] watchdog: digicolor_wdt: " Wolfram Sang
2019-05-19  5:55   ` Baruch Siach
2019-05-19  8:32     ` Wolfram Sang [this message]
2019-05-27 15:50       ` Guenter Roeck
2019-05-18 21:27 ` [PATCH 12/46] watchdog: ftwdt010_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 13/46] watchdog: hpwdt: " Wolfram Sang
2019-05-20 19:44   ` Jerry Hoemann
2019-05-18 21:27 ` [PATCH 14/46] watchdog: i6300esb: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 15/46] watchdog: ie6xx_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 16/46] watchdog: imx2_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 17/46] watchdog: imx_sc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 18/46] watchdog: intel-mid_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 19/46] watchdog: jz4740_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 20/46] watchdog: loongson1_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 21/46] watchdog: max77620_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 22/46] watchdog: mei_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 23/46] watchdog: mena21_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 24/46] watchdog: menf21bmc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 25/46] watchdog: mpc8xxx_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 26/46] watchdog: ni903x_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 27/46] watchdog: nic7018_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 28/46] watchdog: npcm_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 29/46] watchdog: of_xilinx_wdt: " Wolfram Sang
2019-05-19 17:57   ` Michal Simek
2019-05-18 21:27 ` [PATCH 30/46] watchdog: pic32-dmt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 31/46] watchdog: pic32-wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 32/46] watchdog: pnx4008_wdt: " Wolfram Sang
2019-05-22 16:04   ` Sylvain Lemieux
2019-05-18 21:27 ` [PATCH 33/46] watchdog: qcom-wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 34/46] watchdog: rave-sp-wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 35/46] watchdog: s3c2410_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 36/46] watchdog: sama5d4_wdt: " Wolfram Sang
2019-05-21 20:22   ` Alexandre Belloni
2019-05-18 21:27 ` [PATCH 37/46] watchdog: sp5100_tco: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 38/46] watchdog: sp805_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 39/46] watchdog: sprd_wdt: " Wolfram Sang
2019-05-20  2:14   ` Baolin Wang
2019-05-18 21:27 ` [PATCH 40/46] watchdog: st_lpc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 41/46] watchdog: stm32_iwdg: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 42/46] watchdog: stmp3xxx_rtc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 43/46] watchdog: tegra_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 44/46] watchdog: ts4800_wdt: " Wolfram Sang
2019-05-18 21:28 ` [PATCH 45/46] watchdog: wm831x_wdt: " Wolfram Sang
2019-05-18 21:28 ` [PATCH 46/46] watchdog: xen_wdt: " Wolfram Sang
2019-06-07 12:40 ` [PATCH 00/46] watchdog: move 'registration failed' messages into core Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190519083201.GA1003@kunai \
    --to=wsa@the-dreams.de \
    --cc=baruch@tkos.co.il \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).