From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
linux-watchdog@vger.kernel.org
Cc: "Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH 03/46] watchdog: aspeed_wdt: drop warning after registering device
Date: Mon, 20 May 2019 10:23:42 +0930 [thread overview]
Message-ID: <d767a4f0-5965-4578-9d15-9c7f3dafa35b@www.fastmail.com> (raw)
In-Reply-To: <20190518212801.31010-4-wsa+renesas@sang-engineering.com>
On Sun, 19 May 2019, at 06:58, Wolfram Sang wrote:
> The core will print out details now.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> drivers/watchdog/aspeed_wdt.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c
> index 34117745c65f..3ad2558a6de0 100644
> --- a/drivers/watchdog/aspeed_wdt.c
> +++ b/drivers/watchdog/aspeed_wdt.c
> @@ -313,13 +313,7 @@ static int aspeed_wdt_probe(struct platform_device *pdev)
> if (status & WDT_TIMEOUT_STATUS_BOOT_SECONDARY)
> wdt->wdd.bootstatus = WDIOF_CARDRESET;
>
> - ret = devm_watchdog_register_device(dev, &wdt->wdd);
> - if (ret) {
> - dev_err(dev, "failed to register\n");
> - return ret;
> - }
> -
> - return 0;
> + return devm_watchdog_register_device(dev, &wdt->wdd);
> }
>
> static struct platform_driver aspeed_watchdog_driver = {
> --
> 2.19.1
>
>
next prev parent reply other threads:[~2019-05-20 0:53 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 21:27 [PATCH 00/46] watchdog: move 'registration failed' messages into core Wolfram Sang
2019-05-18 21:27 ` [PATCH 01/46] watchdog: make watchdog_deferred_registration_add() void Wolfram Sang
2019-05-18 21:27 ` [PATCH 02/46] watchdog: let core print error message when registering device fails Wolfram Sang
2019-05-18 21:27 ` [PATCH 03/46] watchdog: aspeed_wdt: drop warning after registering device Wolfram Sang
2019-05-20 0:53 ` Andrew Jeffery [this message]
2019-05-18 21:27 ` [PATCH 04/46] watchdog: bcm2835_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 05/46] watchdog: bcm7038_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 06/46] watchdog: bcm_kona_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 07/46] watchdog: cadence_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 08/46] watchdog: da9052_wdt: " Wolfram Sang
2019-05-20 7:59 ` Steve Twiss
2019-05-18 21:27 ` [PATCH 09/46] watchdog: da9062_wdt: " Wolfram Sang
2019-05-20 7:58 ` Steve Twiss
2019-05-18 21:27 ` [PATCH 10/46] watchdog: davinci_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 11/46] watchdog: digicolor_wdt: " Wolfram Sang
2019-05-19 5:55 ` Baruch Siach
2019-05-19 8:32 ` Wolfram Sang
2019-05-27 15:50 ` Guenter Roeck
2019-05-18 21:27 ` [PATCH 12/46] watchdog: ftwdt010_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 13/46] watchdog: hpwdt: " Wolfram Sang
2019-05-20 19:44 ` Jerry Hoemann
2019-05-18 21:27 ` [PATCH 14/46] watchdog: i6300esb: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 15/46] watchdog: ie6xx_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 16/46] watchdog: imx2_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 17/46] watchdog: imx_sc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 18/46] watchdog: intel-mid_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 19/46] watchdog: jz4740_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 20/46] watchdog: loongson1_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 21/46] watchdog: max77620_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 22/46] watchdog: mei_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 23/46] watchdog: mena21_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 24/46] watchdog: menf21bmc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 25/46] watchdog: mpc8xxx_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 26/46] watchdog: ni903x_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 27/46] watchdog: nic7018_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 28/46] watchdog: npcm_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 29/46] watchdog: of_xilinx_wdt: " Wolfram Sang
2019-05-19 17:57 ` Michal Simek
2019-05-18 21:27 ` [PATCH 30/46] watchdog: pic32-dmt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 31/46] watchdog: pic32-wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 32/46] watchdog: pnx4008_wdt: " Wolfram Sang
2019-05-22 16:04 ` Sylvain Lemieux
2019-05-18 21:27 ` [PATCH 33/46] watchdog: qcom-wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 34/46] watchdog: rave-sp-wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 35/46] watchdog: s3c2410_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 36/46] watchdog: sama5d4_wdt: " Wolfram Sang
2019-05-21 20:22 ` Alexandre Belloni
2019-05-18 21:27 ` [PATCH 37/46] watchdog: sp5100_tco: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 38/46] watchdog: sp805_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 39/46] watchdog: sprd_wdt: " Wolfram Sang
2019-05-20 2:14 ` Baolin Wang
2019-05-18 21:27 ` [PATCH 40/46] watchdog: st_lpc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 41/46] watchdog: stm32_iwdg: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 42/46] watchdog: stmp3xxx_rtc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 43/46] watchdog: tegra_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 44/46] watchdog: ts4800_wdt: " Wolfram Sang
2019-05-18 21:28 ` [PATCH 45/46] watchdog: wm831x_wdt: " Wolfram Sang
2019-05-18 21:28 ` [PATCH 46/46] watchdog: xen_wdt: " Wolfram Sang
2019-06-07 12:40 ` [PATCH 00/46] watchdog: move 'registration failed' messages into core Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d767a4f0-5965-4578-9d15-9c7f3dafa35b@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).