From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-watchdog@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 00/46] watchdog: move 'registration failed' messages into core
Date: Fri, 7 Jun 2019 05:40:43 -0700 [thread overview]
Message-ID: <3d68d837-ea4e-fd70-27a7-2fb72696e378@roeck-us.net> (raw)
In-Reply-To: <20190518212801.31010-1-wsa+renesas@sang-engineering.com>
On 5/18/19 2:27 PM, Wolfram Sang wrote:
> Similar to my recently merged series doing the same for
> watchdog_init_timeout(), here is a series moving all error messages
> after a failed {devm_}watchdog_register_device() into the core. Guenter
> was right, this was even more worth it. For some cases, this also
> resulted in neat code simplifications.
>
> The core changes were tested with a Renesas Lager (R-Car H2) board. The
> driver changes were created using a coccinelle script and build-tested
> by buildbot.
>
> This series is based on Linus' tree as of today which should be close
> enough to -rc1, I guess. A branch can be found here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/wdt/register_device
>
> Looking forward to comments.
>
For the series:
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Happy hacking,
>
> Wolfram
>
> Wolfram Sang (46):
> watchdog: make watchdog_deferred_registration_add() void
> watchdog: let core print error message when registering device fails
> watchdog: aspeed_wdt: drop warning after registering device
> watchdog: bcm2835_wdt: drop warning after registering device
> watchdog: bcm7038_wdt: drop warning after registering device
> watchdog: bcm_kona_wdt: drop warning after registering device
> watchdog: cadence_wdt: drop warning after registering device
> watchdog: da9052_wdt: drop warning after registering device
> watchdog: da9062_wdt: drop warning after registering device
> watchdog: davinci_wdt: drop warning after registering device
> watchdog: digicolor_wdt: drop warning after registering device
> watchdog: ftwdt010_wdt: drop warning after registering device
> watchdog: hpwdt: drop warning after registering device
> watchdog: i6300esb: drop warning after registering device
> watchdog: ie6xx_wdt: drop warning after registering device
> watchdog: imx2_wdt: drop warning after registering device
> watchdog: imx_sc_wdt: drop warning after registering device
> watchdog: intel-mid_wdt: drop warning after registering device
> watchdog: jz4740_wdt: drop warning after registering device
> watchdog: loongson1_wdt: drop warning after registering device
> watchdog: max77620_wdt: drop warning after registering device
> watchdog: mei_wdt: drop warning after registering device
> watchdog: mena21_wdt: drop warning after registering device
> watchdog: menf21bmc_wdt: drop warning after registering device
> watchdog: mpc8xxx_wdt: drop warning after registering device
> watchdog: ni903x_wdt: drop warning after registering device
> watchdog: nic7018_wdt: drop warning after registering device
> watchdog: npcm_wdt: drop warning after registering device
> watchdog: of_xilinx_wdt: drop warning after registering device
> watchdog: pic32-dmt: drop warning after registering device
> watchdog: pic32-wdt: drop warning after registering device
> watchdog: pnx4008_wdt: drop warning after registering device
> watchdog: qcom-wdt: drop warning after registering device
> watchdog: rave-sp-wdt: drop warning after registering device
> watchdog: s3c2410_wdt: drop warning after registering device
> watchdog: sama5d4_wdt: drop warning after registering device
> watchdog: sp5100_tco: drop warning after registering device
> watchdog: sp805_wdt: drop warning after registering device
> watchdog: sprd_wdt: drop warning after registering device
> watchdog: st_lpc_wdt: drop warning after registering device
> watchdog: stm32_iwdg: drop warning after registering device
> watchdog: stmp3xxx_rtc_wdt: drop warning after registering device
> watchdog: tegra_wdt: drop warning after registering device
> watchdog: ts4800_wdt: drop warning after registering device
> watchdog: wm831x_wdt: drop warning after registering device
> watchdog: xen_wdt: drop warning after registering device
>
> drivers/watchdog/aspeed_wdt.c | 8 +-------
> drivers/watchdog/bcm2835_wdt.c | 4 +---
> drivers/watchdog/bcm7038_wdt.c | 4 +---
> drivers/watchdog/bcm_kona_wdt.c | 4 +---
> drivers/watchdog/cadence_wdt.c | 4 +---
> drivers/watchdog/da9052_wdt.c | 9 +--------
> drivers/watchdog/da9062_wdt.c | 5 +----
> drivers/watchdog/davinci_wdt.c | 8 +-------
> drivers/watchdog/digicolor_wdt.c | 8 +-------
> drivers/watchdog/ftwdt010_wdt.c | 4 +---
> drivers/watchdog/hpwdt.c | 4 +---
> drivers/watchdog/i6300esb.c | 5 +----
> drivers/watchdog/ie6xx_wdt.c | 6 +-----
> drivers/watchdog/imx2_wdt.c | 4 +---
> drivers/watchdog/imx_sc_wdt.c | 8 +-------
> drivers/watchdog/intel-mid_wdt.c | 4 +---
> drivers/watchdog/jz4740_wdt.c | 6 +-----
> drivers/watchdog/loongson1_wdt.c | 4 +---
> drivers/watchdog/max77620_wdt.c | 8 +-------
> drivers/watchdog/mei_wdt.c | 4 +---
> drivers/watchdog/mena21_wdt.c | 4 +---
> drivers/watchdog/menf21bmc_wdt.c | 4 +---
> drivers/watchdog/mpc8xxx_wdt.c | 5 +----
> drivers/watchdog/ni903x_wdt.c | 4 +---
> drivers/watchdog/nic7018_wdt.c | 1 -
> drivers/watchdog/npcm_wdt.c | 4 +---
> drivers/watchdog/of_xilinx_wdt.c | 4 +---
> drivers/watchdog/pic32-dmt.c | 4 +---
> drivers/watchdog/pic32-wdt.c | 4 +---
> drivers/watchdog/pnx4008_wdt.c | 4 +---
> drivers/watchdog/qcom-wdt.c | 4 +---
> drivers/watchdog/rave-sp-wdt.c | 1 -
> drivers/watchdog/s3c2410_wdt.c | 4 +---
> drivers/watchdog/sama5d4_wdt.c | 4 +---
> drivers/watchdog/sp5100_tco.c | 4 +---
> drivers/watchdog/sp805_wdt.c | 5 +----
> drivers/watchdog/sprd_wdt.c | 1 -
> drivers/watchdog/st_lpc_wdt.c | 4 +---
> drivers/watchdog/stm32_iwdg.c | 4 +---
> drivers/watchdog/stmp3xxx_rtc_wdt.c | 4 +---
> drivers/watchdog/tegra_wdt.c | 4 +---
> drivers/watchdog/ts4800_wdt.c | 4 +---
> drivers/watchdog/watchdog_core.c | 16 ++++++++++++----
> drivers/watchdog/wm831x_wdt.c | 9 +--------
> drivers/watchdog/xen_wdt.c | 4 +---
> 45 files changed, 53 insertions(+), 168 deletions(-)
>
prev parent reply other threads:[~2019-06-07 12:40 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 21:27 [PATCH 00/46] watchdog: move 'registration failed' messages into core Wolfram Sang
2019-05-18 21:27 ` [PATCH 01/46] watchdog: make watchdog_deferred_registration_add() void Wolfram Sang
2019-05-18 21:27 ` [PATCH 02/46] watchdog: let core print error message when registering device fails Wolfram Sang
2019-05-18 21:27 ` [PATCH 03/46] watchdog: aspeed_wdt: drop warning after registering device Wolfram Sang
2019-05-20 0:53 ` Andrew Jeffery
2019-05-18 21:27 ` [PATCH 04/46] watchdog: bcm2835_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 05/46] watchdog: bcm7038_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 06/46] watchdog: bcm_kona_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 07/46] watchdog: cadence_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 08/46] watchdog: da9052_wdt: " Wolfram Sang
2019-05-20 7:59 ` Steve Twiss
2019-05-18 21:27 ` [PATCH 09/46] watchdog: da9062_wdt: " Wolfram Sang
2019-05-20 7:58 ` Steve Twiss
2019-05-18 21:27 ` [PATCH 10/46] watchdog: davinci_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 11/46] watchdog: digicolor_wdt: " Wolfram Sang
2019-05-19 5:55 ` Baruch Siach
2019-05-19 8:32 ` Wolfram Sang
2019-05-27 15:50 ` Guenter Roeck
2019-05-18 21:27 ` [PATCH 12/46] watchdog: ftwdt010_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 13/46] watchdog: hpwdt: " Wolfram Sang
2019-05-20 19:44 ` Jerry Hoemann
2019-05-18 21:27 ` [PATCH 14/46] watchdog: i6300esb: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 15/46] watchdog: ie6xx_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 16/46] watchdog: imx2_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 17/46] watchdog: imx_sc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 18/46] watchdog: intel-mid_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 19/46] watchdog: jz4740_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 20/46] watchdog: loongson1_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 21/46] watchdog: max77620_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 22/46] watchdog: mei_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 23/46] watchdog: mena21_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 24/46] watchdog: menf21bmc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 25/46] watchdog: mpc8xxx_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 26/46] watchdog: ni903x_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 27/46] watchdog: nic7018_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 28/46] watchdog: npcm_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 29/46] watchdog: of_xilinx_wdt: " Wolfram Sang
2019-05-19 17:57 ` Michal Simek
2019-05-18 21:27 ` [PATCH 30/46] watchdog: pic32-dmt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 31/46] watchdog: pic32-wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 32/46] watchdog: pnx4008_wdt: " Wolfram Sang
2019-05-22 16:04 ` Sylvain Lemieux
2019-05-18 21:27 ` [PATCH 33/46] watchdog: qcom-wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 34/46] watchdog: rave-sp-wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 35/46] watchdog: s3c2410_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 36/46] watchdog: sama5d4_wdt: " Wolfram Sang
2019-05-21 20:22 ` Alexandre Belloni
2019-05-18 21:27 ` [PATCH 37/46] watchdog: sp5100_tco: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 38/46] watchdog: sp805_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 39/46] watchdog: sprd_wdt: " Wolfram Sang
2019-05-20 2:14 ` Baolin Wang
2019-05-18 21:27 ` [PATCH 40/46] watchdog: st_lpc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 41/46] watchdog: stm32_iwdg: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 42/46] watchdog: stmp3xxx_rtc_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 43/46] watchdog: tegra_wdt: " Wolfram Sang
2019-05-18 21:27 ` [PATCH 44/46] watchdog: ts4800_wdt: " Wolfram Sang
2019-05-18 21:28 ` [PATCH 45/46] watchdog: wm831x_wdt: " Wolfram Sang
2019-05-18 21:28 ` [PATCH 46/46] watchdog: xen_wdt: " Wolfram Sang
2019-06-07 12:40 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d68d837-ea4e-fd70-27a7-2fb72696e378@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).