brcmfmac: Probing regression in Linux 5.3-rc1

brcmfmac: Probing regression in Linux 5.3-rc1

[Stefan Wahren]

Hi,

Am 24.07.19 um 10:37 schrieb Nicolas Saenz Julienne:
>>>> Does it fix the wifi issue too?
>>> Well it works as long as I revert this: 901bb98918 ("nl80211: require and
>>> validate vendor command policy"). Which has nothing to do with DMA anyways.
>>>
>>> Was this the issue you where seeing?
>>>
>>> [    4.969679] WARNING: CPU: 2 PID: 21 at net/wireless/core.c:868
>>> wiphy_register+0x8e8/0xbdc [cfg80211]
>>> [...]
>>> [    4.969974] ieee80211 phy0: brcmf_cfg80211_attach: Could not register
>>> wiphy device (-22)
>> We're seeing this on different platforms (allwinner / rockchip / amlogic)
>> with Broadcom WiFi chips. So it's unlikely to be related with anything in
>> this series.
>>
>> I believe a fix for this has already been queued up:
>>
>>
> https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=91046d6364afde646734c7ead1f649d253c386e9
>
> Thanks for pointing it out, it fixes the issue alright.
>
i cannot confirm. I still need to revert Johannes' commit "nl80211:
require and validate vendor command policy" to get brcmfmac probing on
Raspberry Pi 3B+ and 4B.

The commit "nl80211: fix VENDOR_CMD_RAW_DATA" didn't fix the probing
issue (see warning above).

Regards
Stefan

Re: brcmfmac: Probing regression in Linux 5.3-rc1

[Stefan Wahren]

Hi,

Am 27.07.19 um 17:17 schrieb Stefan Wahren:
> Hi,
>
> Am 24.07.19 um 10:37 schrieb Nicolas Saenz Julienne:
>>>>> Does it fix the wifi issue too?
>>>> Well it works as long as I revert this: 901bb98918 ("nl80211: require and
>>>> validate vendor command policy"). Which has nothing to do with DMA anyways.
>>>>
>>>> Was this the issue you where seeing?
>>>>
>>>> [    4.969679] WARNING: CPU: 2 PID: 21 at net/wireless/core.c:868
>>>> wiphy_register+0x8e8/0xbdc [cfg80211]
>>>> [...]
>>>> [    4.969974] ieee80211 phy0: brcmf_cfg80211_attach: Could not register
>>>> wiphy device (-22)
>>> We're seeing this on different platforms (allwinner / rockchip / amlogic)
>>> with Broadcom WiFi chips. So it's unlikely to be related with anything in
>>> this series.
>>>
>>> I believe a fix for this has already been queued up:
>>>
>>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=91046d6364afde646734c7ead1f649d253c386e9
>>
>> Thanks for pointing it out, it fixes the issue alright.
>>
> i cannot confirm. I still need to revert Johannes' commit "nl80211:
> require and validate vendor command policy" to get brcmfmac probing on
> Raspberry Pi 3B+ and 4B.
>
> The commit "nl80211: fix VENDOR_CMD_RAW_DATA" didn't fix the probing
> issue (see warning above).
i rebased my series on top of Linux 5.3-rc2 and issue disappeared. I
assume the commit "wireless: fix nl80211 vendor commands" is also required.

Sorry, for the noise.
>
> Regards
> Stefan
>
>