From: Michael Ellerman <mpe@ellerman.id.au>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3] powerpc: Split user/kernel definitions of struct pt_regs
Date: Mon, 15 Oct 2018 22:08:28 +1100 [thread overview]
Message-ID: <87sh17zcur.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <458fb5e1-3654-e8db-dfa7-074195decb11@linux.vnet.ibm.com>
Madhavan Srinivasan <maddy@linux.vnet.ibm.com> writes:
> On Saturday 13 October 2018 04:26 PM, Michael Ellerman wrote:
>> We use a shared definition for struct pt_regs in uapi/asm/ptrace.h.
>> That means the layout of the structure is ABI, ie. we can't change it.
>>
>> That would be fine if it was only used to describe the user-visible
>> register state of a process, but it's also the struct we use in the
>> kernel to describe the registers saved in an interrupt frame.
>>
>> We'd like more flexibility in the content (and possibly layout) of the
>> kernel version of the struct, but currently that's not possible.
>>
>> So split the definition into a user-visible definition which remains
>> unchanged, and a kernel internal one.
>>
>> At the moment they're still identical, and we check that at build
>> time. That's because we have code (in ptrace etc.) that assumes that
>> they are the same. We will fix that code in future patches, and then
>> we can break the strict symmetry between the two structs.
>
> Nice and awesome. But just trying to understand. What will
> *regs will point to in the "struct sigcontext".
Yeah that's a bit fishy.
It should always point to a user_pt_regs.
So in the kernel we want:
struct sigcontext {
...
struct user_pt_regs __user *regs;
And in userspace we want:
struct sigcontext {
...
struct pt_regs __user *regs;
I think it's not actually broken at the moment, because it's just a
pointer, and we don't do anything based on the sizeof() the type.
But still we should fix it.
I guess I'll do this:
diff --git a/arch/powerpc/include/uapi/asm/sigcontext.h b/arch/powerpc/include/uapi/asm/sigcontext.h
index 2fbe485acdb4..630aeda56d59 100644
--- a/arch/powerpc/include/uapi/asm/sigcontext.h
+++ b/arch/powerpc/include/uapi/asm/sigcontext.h
@@ -22,7 +22,11 @@ struct sigcontext {
#endif
unsigned long handler;
unsigned long oldmask;
- struct pt_regs __user *regs;
+#ifdef __KERNEL__
+ struct user_pt_regs __user *regs;
+#else
+ struct pt_regs *regs;
+#endif
#ifdef __powerpc64__
elf_gregset_t gp_regs;
elf_fpregset_t fp_regs;
Thanks for the review.
cheers
next prev parent reply other threads:[~2018-10-15 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 10:56 [PATCH 1/3] powerpc: Split user/kernel definitions of struct pt_regs Michael Ellerman
2018-10-13 10:56 ` [PATCH 2/3] powerpc/ptrace: Don't use sizeof(struct pt_regs) in ptrace code Michael Ellerman
2018-10-13 10:56 ` [PATCH 3/3] powerpc/64: Interrupts save PPR on stack rather than thread_struct Michael Ellerman
2018-10-13 12:27 ` [PATCH 1/3] powerpc: Split user/kernel definitions of struct pt_regs Nicholas Piggin
2018-10-15 12:02 ` Michael Ellerman
2018-10-14 6:36 ` Madhavan Srinivasan
2018-10-15 11:08 ` Michael Ellerman [this message]
2018-10-15 12:39 ` Madhavan Srinivasan
2018-10-16 10:50 ` Michael Ellerman
2018-10-15 4:01 ` [1/3] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh17zcur.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).