* Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter [not found] ` <1327952458-7424-6-git-send-email-danny.kukawka@bisect.de> @ 2012-01-31 10:01 ` Andy Walls 2012-01-31 10:13 ` Andy Walls 0 siblings, 1 reply; 7+ messages in thread From: Andy Walls @ 2012-01-31 10:01 UTC (permalink / raw) To: Danny Kukawka, Rusty Russell, mchehab Cc: Mauro Carvalho Chehab, ivtv-devel, linux-media, linux-kernel On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: > Fixed handling of 'radio' module parameter from module_param_array > to module_param_named to fix these compiler warnings in cx18-driver.c: NACK. "radio" is an array of tristate values (-1, 0, 1) per installed card: static int radio[CX18_MAX_CARDS] = { -1, -1, and must remain an array or you will break the driver. Calling "radio_c" a module parameter named "radio" is wrong. The correct fix is to reverse Rusty Russel's patch to the driver in commit 90ab5ee94171b3e28de6bb42ee30b527014e0be7 to change the "bool" back to an "int" as it should be in "module_param_array(radio, ...)" Regards, Andy > In function ‘__check_radio’: > 113:1: warning: return from incompatible pointer type [enabled by default] > At top level: > 113:1: warning: initialization from incompatible pointer type [enabled by default] > 113:1: warning: (near initialization for ‘__param_arr_radio.num’) [enabled by default] > > Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de> > --- > drivers/media/video/cx18/cx18-driver.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c > index 349bd9c..27b5330 100644 > --- a/drivers/media/video/cx18/cx18-driver.c > +++ b/drivers/media/video/cx18/cx18-driver.c > @@ -110,7 +110,7 @@ static int retry_mmio = 1; > int cx18_debug; > > module_param_array(tuner, int, &tuner_c, 0644); > -module_param_array(radio, bool, &radio_c, 0644); > +module_param_named(radio, radio_c, bool, 0644); > module_param_array(cardtype, int, &cardtype_c, 0644); > module_param_string(pal, pal, sizeof(pal), 0644); > module_param_string(secam, secam, sizeof(secam), 0644); ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter 2012-01-31 10:01 ` [PATCH 05/16] cx18: fix handling of 'radio' module parameter Andy Walls @ 2012-01-31 10:13 ` Andy Walls 0 siblings, 0 replies; 7+ messages in thread From: Andy Walls @ 2012-01-31 10:13 UTC (permalink / raw) To: Danny Kukawka Cc: Rusty Russell, mchehab, Mauro Carvalho Chehab, ivtv-devel, linux-media, linux-kernel On Tue, 2012-01-31 at 05:01 -0500, Andy Walls wrote: > On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: > > Fixed handling of 'radio' module parameter from module_param_array > > to module_param_named to fix these compiler warnings in cx18-driver.c: > > NACK. > > "radio" is an array of tristate values (-1, 0, 1) per installed card: > > static int radio[CX18_MAX_CARDS] = { -1, -1, > > and must remain an array or you will break the driver. > > Calling "radio_c" a module parameter named "radio" is wrong. > > The correct fix is to reverse Rusty Russel's patch to the driver in > commit 90ab5ee94171b3e28de6bb42ee30b527014e0be7 > to change the "bool" back to an "int" as it should be in ^^^^ Sorry, a typo here. Disregard the word "back". Regards, Andy > "module_param_array(radio, ...)" > > Regards, > Andy > > > In function ‘__check_radio’: > > 113:1: warning: return from incompatible pointer type [enabled by default] > > At top level: > > 113:1: warning: initialization from incompatible pointer type [enabled by default] > > 113:1: warning: (near initialization for ‘__param_arr_radio.num’) [enabled by default] > > > > Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de> > > --- > > drivers/media/video/cx18/cx18-driver.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c > > index 349bd9c..27b5330 100644 > > --- a/drivers/media/video/cx18/cx18-driver.c > > +++ b/drivers/media/video/cx18/cx18-driver.c > > @@ -110,7 +110,7 @@ static int retry_mmio = 1; > > int cx18_debug; > > > > module_param_array(tuner, int, &tuner_c, 0644); > > -module_param_array(radio, bool, &radio_c, 0644); > > +module_param_named(radio, radio_c, bool, 0644); > > module_param_array(cardtype, int, &cardtype_c, 0644); > > module_param_string(pal, pal, sizeof(pal), 0644); > > module_param_string(secam, secam, sizeof(secam), 0644); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <1327952458-7424-9-git-send-email-danny.kukawka@bisect.de>]
* Re: [PATCH v2 08/16] ivtv-driver: fix handling of 'radio' module parameter [not found] ` <1327952458-7424-9-git-send-email-danny.kukawka@bisect.de> @ 2012-01-31 10:07 ` Andy Walls 0 siblings, 0 replies; 7+ messages in thread From: Andy Walls @ 2012-01-31 10:07 UTC (permalink / raw) To: Danny Kukawka, mchehab, Rusty Russell Cc: Andy Walls, Mauro Carvalho Chehab, ivtv-devel, linux-media, linux-kernel On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: > Fixed handling of 'radio' module parameter from module_param_array > to module_param_named to fix these compiler warnings in ivtv-driver.c: > > In function ‘__check_radio’: > 113:1: warning: return from incompatible pointer type [enabled by default] > At top level: > 113:1: warning: initialization from incompatible pointer type [enabled by default] > 113:1: warning: (near initialization for ‘__param_arr_radio.num’) [enabled by default] > > Set initial state of radio_c to true instead of 1. NACK. "radio" is an array of tristate values (-1, 0, 1) per installed card: static int radio[IVTV_MAX_CARDS] = { -1, -1, and must remain an array or you will break the driver. Calling "radio_c" a module parameter named "radio" is wrong. The correct fix is to reverse Rusty Russel's patch to the driver in commit 90ab5ee94171b3e28de6bb42ee30b527014e0be7 to change the "bool" to an "int" as it should be in "module_param_array(radio, ...)" Regards, Andy > Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de> > --- > drivers/media/video/ivtv/ivtv-driver.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/video/ivtv/ivtv-driver.c b/drivers/media/video/ivtv/ivtv-driver.c > index 3949b7d..dbd78d5 100644 > --- a/drivers/media/video/ivtv/ivtv-driver.c > +++ b/drivers/media/video/ivtv/ivtv-driver.c > @@ -99,7 +99,7 @@ static int i2c_clock_period[IVTV_MAX_CARDS] = { -1, -1, -1, -1, -1, -1, -1, -1, > > static unsigned int cardtype_c = 1; > static unsigned int tuner_c = 1; > -static bool radio_c = 1; > +static bool radio_c = true; > static unsigned int i2c_clock_period_c = 1; > static char pal[] = "---"; > static char secam[] = "--"; > @@ -139,7 +139,7 @@ static int tunertype = -1; > static int newi2c = -1; > > module_param_array(tuner, int, &tuner_c, 0644); > -module_param_array(radio, bool, &radio_c, 0644); > +module_param_named(radio, radio_c, bool, 0644); > module_param_array(cardtype, int, &cardtype_c, 0644); > module_param_string(pal, pal, sizeof(pal), 0644); > module_param_string(secam, secam, sizeof(secam), 0644); ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH RESEND 00/16] some compiler warning fixes @ 2012-01-30 22:00 Danny Kukawka 2012-01-30 22:00 ` [PATCH 05/16] cx18: fix handling of 'radio' module parameter Danny Kukawka 0 siblings, 1 reply; 7+ messages in thread From: Danny Kukawka @ 2012-01-30 22:00 UTC (permalink / raw) To: linux-kernel Resend due to problems with suppressed CC list and misconfigured git-send-email. Sorry. For some of the patches I send new reworked/fixed versions (v2) with this series. Danny Kukawka (16): eicon: fix -Warray-bounds warning max2165: trival fix for some -Wuninitialized warning mmc: fix for some -Wuninitialized warning vmw_balloon: fix for a -Wuninitialized warning cx18: fix handling of 'radio' module parameter cpcihp: fix debug module parameter to be bool hdaps: trivial fix for -Wuninitialized ivtv-driver: fix handling of 'radio' module parameter [RFC] aic94xx: fix for -Wuninitialized ixj: fix Wsequence-point compiler warnings ath5k: make ath5k_modparam_no_hw_rfkill_switch real kobil_sct: fix debug module parameter to be bool riva/fbdev: fix several -Wuninitialized hamradio: fix incompatible pointer in module parameter leds-lp5521: fix compiler warning leds-lp5523: fix compiler warning drivers/isdn/hardware/eicon/capi20.h | 2 +- drivers/leds/leds-lp5521.c | 14 ++- drivers/leds/leds-lp5523.c | 17 ++- drivers/media/common/tuners/max2165.c | 9 +- drivers/media/video/cx18/cx18-driver.c | 2 +- drivers/media/video/ivtv/ivtv-driver.c | 4 +- drivers/misc/vmw_balloon.c | 14 +- drivers/mmc/card/block.c | 3 +- drivers/net/hamradio/baycom_epp.c | 2 +- drivers/net/hamradio/baycom_par.c | 2 +- drivers/net/wireless/ath/ath5k/base.c | 2 +- drivers/pci/hotplug/cpcihp_generic.c | 2 +- drivers/platform/x86/hdaps.c | 4 +- drivers/scsi/aic94xx/aic94xx_sds.c | 2 +- drivers/telephony/ixj.c | 194 ++++++++++++++++++-------------- drivers/usb/serial/kobil_sct.c | 2 +- drivers/video/riva/fbdev.c | 5 +- 17 files changed, 161 insertions(+), 119 deletions(-) -- 1.7.7.3 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 05/16] cx18: fix handling of 'radio' module parameter 2012-01-30 22:00 [PATCH RESEND 00/16] some compiler warning fixes Danny Kukawka @ 2012-01-30 22:00 ` Danny Kukawka 2012-01-31 13:45 ` Danny Kukawka 0 siblings, 1 reply; 7+ messages in thread From: Danny Kukawka @ 2012-01-30 22:00 UTC (permalink / raw) To: Andy Walls; +Cc: Mauro Carvalho Chehab, ivtv-devel, linux-media, linux-kernel Fixed handling of 'radio' module parameter from module_param_array to module_param_named to fix these compiler warnings in cx18-driver.c: In function ‘__check_radio’: 113:1: warning: return from incompatible pointer type [enabled by default] At top level: 113:1: warning: initialization from incompatible pointer type [enabled by default] 113:1: warning: (near initialization for ‘__param_arr_radio.num’) [enabled by default] Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de> --- drivers/media/video/cx18/cx18-driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c index 349bd9c..27b5330 100644 --- a/drivers/media/video/cx18/cx18-driver.c +++ b/drivers/media/video/cx18/cx18-driver.c @@ -110,7 +110,7 @@ static int retry_mmio = 1; int cx18_debug; module_param_array(tuner, int, &tuner_c, 0644); -module_param_array(radio, bool, &radio_c, 0644); +module_param_named(radio, radio_c, bool, 0644); module_param_array(cardtype, int, &cardtype_c, 0644); module_param_string(pal, pal, sizeof(pal), 0644); module_param_string(secam, secam, sizeof(secam), 0644); -- 1.7.7.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter 2012-01-30 22:00 ` [PATCH 05/16] cx18: fix handling of 'radio' module parameter Danny Kukawka @ 2012-01-31 13:45 ` Danny Kukawka 2012-01-31 14:59 ` Andy Walls 2012-02-01 2:29 ` Rusty Russell 0 siblings, 2 replies; 7+ messages in thread From: Danny Kukawka @ 2012-01-31 13:45 UTC (permalink / raw) To: Andy Walls Cc: Mauro Carvalho Chehab, ivtv-devel, linux-media, linux-kernel, Rusty Russell, mchehab On Dienstag, 31. Januar 2012, Andy Walls wrote: > On Tue, 2012-01-31 at 05:01 -0500, Andy Walls wrote: > > On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: > > > Fixed handling of 'radio' module parameter from module_param_array > > > to module_param_named to fix these compiler warnings in cx18-driver.c: > > > > NACK. > > > > "radio" is an array of tristate values (-1, 0, 1) per installed card: > > > > static int radio[CX18_MAX_CARDS] = { -1, -1, > > > > and must remain an array or you will break the driver. > > > > Calling "radio_c" a module parameter named "radio" is wrong. > > > > The correct fix is to reverse Rusty Russel's patch to the driver in > > commit 90ab5ee94171b3e28de6bb42ee30b527014e0be7 > > to change the "bool" back to an "int" as it should be in > > ^^^^ > Sorry, a typo here. Disregard the word "back". Overseen this. But wouldn't be the correct fix in this case to: a) reverse the part of 90ab5ee94171b3e28de6bb42ee30b527014e0be7 to: get: static unsigned radio_c = 1; b) change the following line: module_param_array(radio, bool, &radio_c, 0644); to: module_param_array(radio, int, &radio_c, 0644); Without b) you would get a warning from the compiler again. Danny ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter 2012-01-31 13:45 ` Danny Kukawka @ 2012-01-31 14:59 ` Andy Walls 2012-02-01 2:29 ` Rusty Russell 1 sibling, 0 replies; 7+ messages in thread From: Andy Walls @ 2012-01-31 14:59 UTC (permalink / raw) To: Danny Kukawka Cc: Mauro Carvalho Chehab, ivtv-devel, linux-media, linux-kernel, Rusty Russell, mchehab Danny Kukawka <danny.kukawka@bisect.de> wrote: >On Dienstag, 31. Januar 2012, Andy Walls wrote: >> On Tue, 2012-01-31 at 05:01 -0500, Andy Walls wrote: >> > On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: >> > > Fixed handling of 'radio' module parameter from >module_param_array >> > > to module_param_named to fix these compiler warnings in >cx18-driver.c: >> > >> > NACK. >> > >> > "radio" is an array of tristate values (-1, 0, 1) per installed >card: >> > >> > static int radio[CX18_MAX_CARDS] = { -1, -1, >> > >> > and must remain an array or you will break the driver. >> > >> > Calling "radio_c" a module parameter named "radio" is wrong. >> > >> > The correct fix is to reverse Rusty Russel's patch to the driver in >> > commit 90ab5ee94171b3e28de6bb42ee30b527014e0be7 >> > to change the "bool" back to an "int" as it should be in >> >> ^^^^ >> Sorry, a typo here. Disregard the word "back". > >Overseen this. But wouldn't be the correct fix in this case to: >a) reverse the part of 90ab5ee94171b3e28de6bb42ee30b527014e0be7 to: > get: > static unsigned radio_c = 1; > >b) change the following line: > module_param_array(radio, bool, &radio_c, 0644); > to: > module_param_array(radio, int, &radio_c, 0644); > >Without b) you would get a warning from the compiler again. > >Danny Yes, both need to happen. I mentioned b) at the end of my original email. Regards, Andy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter 2012-01-31 13:45 ` Danny Kukawka 2012-01-31 14:59 ` Andy Walls @ 2012-02-01 2:29 ` Rusty Russell 1 sibling, 0 replies; 7+ messages in thread From: Rusty Russell @ 2012-02-01 2:29 UTC (permalink / raw) To: Danny Kukawka, Andy Walls Cc: Mauro Carvalho Chehab, ivtv-devel, linux-media, linux-kernel, mchehab On Tue, 31 Jan 2012 14:45:18 +0100, Danny Kukawka <danny.kukawka@bisect.de> wrote: > On Dienstag, 31. Januar 2012, Andy Walls wrote: > Overseen this. But wouldn't be the correct fix in this case to: > a) reverse the part of 90ab5ee94171b3e28de6bb42ee30b527014e0be7 to: > get: > static unsigned radio_c = 1; > > b) change the following line: > module_param_array(radio, bool, &radio_c, 0644); > to: > module_param_array(radio, int, &radio_c, 0644); Yes, sorry, my patch was complete crap here :( If you want people to set it only to 1 or 0, you probably want "bint". Thanks, Rusty. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-02-01 3:44 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1327952458-7424-1-git-send-email-danny.kukawka@bisect.de> [not found] ` <1327952458-7424-6-git-send-email-danny.kukawka@bisect.de> 2012-01-31 10:01 ` [PATCH 05/16] cx18: fix handling of 'radio' module parameter Andy Walls 2012-01-31 10:13 ` Andy Walls [not found] ` <1327952458-7424-9-git-send-email-danny.kukawka@bisect.de> 2012-01-31 10:07 ` [PATCH v2 08/16] ivtv-driver: " Andy Walls 2012-01-30 22:00 [PATCH RESEND 00/16] some compiler warning fixes Danny Kukawka 2012-01-30 22:00 ` [PATCH 05/16] cx18: fix handling of 'radio' module parameter Danny Kukawka 2012-01-31 13:45 ` Danny Kukawka 2012-01-31 14:59 ` Andy Walls 2012-02-01 2:29 ` Rusty Russell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).