From: Sibi Sankar <sibis@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
tsoni@codeaurora.org, clew@codeaurora.org,
akdwived@codeaurora.org, Mark Rutland <mark.rutland@arm.com>,
linux-remoteproc@vger.kernel.org,
Evan Green <evgreen@chromium.org>,
Brian Norris <briannorris@chromium.org>,
linux-remoteproc-owner@vger.kernel.org
Subject: Re: [PATCH v2 3/7] dt-bindings: remoteproc: qcom: Fixup regulator dependencies
Date: Tue, 18 Dec 2018 12:20:41 +0530 [thread overview]
Message-ID: <13e6d8d6bb46dfc31b5bca927b71223f@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=XNZ5CzKXHogKEGTHgPVg_nbXxVEJR0e9F9usEY3YKEiQ@mail.gmail.com>
Hi Doug,
Thanks for the review :)
On 2018-12-18 05:30, Doug Anderson wrote:
> Hi,
>
> On Mon, Dec 17, 2018 at 2:08 AM Sibi Sankar <sibis@codeaurora.org>
> wrote:
>>
>> Fixup regulator supply dependencies for Q6V5 MSS on MSM996 SoCs.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> index 780adc043b37..98894e6ad456 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> @@ -76,7 +76,9 @@ on the Qualcomm Hexagon core.
>> Usage: required
>> Value type: <phandle>
>> Definition: reference to the regulators to be held on behalf
>> of the
>> - booting of the Hexagon core
>> + booting of the Hexagon core on MSM8916 SoCs
>> + reference to the pll-supply regulator to be held
>> on behalf
>> + of the booting of the Hexagon core on MSM8996 SoCs
>
> The prose gets in the way and doesn't add anything. I also don't
> understand what you're saying for msm8996. You're saying that
> "pll-supply" is required there but none of the others? That doesn't
> seem to be true in the code I have in front of me, but maybe I'm
> missing some patch. For me, I'd write:
>
AFAIK, only the exceptions are captured. But your
suggestion seems more simple/complete. Perhaps I'll
replace SoCs instead of compatibles? Anyway
I'll wait for Bjorn/Rob's preference.
> For the compatible strings below the following supplies are required:
> "qcom,q6v5-pil"
> "qcom,msm8916-mss-pil",
> "qcom,msm8974-mss-pil"
> - cx-supply:
> - mss-supply:
> - mx-supply:
> - pll-supply:
> Usage: required
> Value type: <phandle>
> Definition: reference to the regulators to be held on behalf of the
> booting of the Hexagon core
>
>
> ...and if msm8996 actually needs "pll-supply", you could add in...
>
> For the compatible strings below the following supplies are required:
> "qcom,msm8996-mss-pil"
> - pll-supply:
> Usage: required
> Value type: <phandle>
> Definition: reference to the regulators to be held on behalf of the
> booting of the Hexagon core
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-12-18 6:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 10:07 [PATCH v2 1/7] dt-bindings: soc: qcom: Add remote-pid binding for GLINK SMEM Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 2/7] dt-bindings: remoteproc: qcom: Add clock bindings for Q6V5 Sibi Sankar
2018-12-17 23:59 ` Doug Anderson
2018-12-18 5:52 ` Sibi Sankar
2018-12-18 16:07 ` Doug Anderson
2018-12-18 17:27 ` Rob Herring
2018-12-19 7:04 ` Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 3/7] dt-bindings: remoteproc: qcom: Fixup regulator dependencies Sibi Sankar
2018-12-18 0:00 ` Doug Anderson
2018-12-18 6:50 ` Sibi Sankar [this message]
2018-12-17 10:07 ` [PATCH v2 4/7] dt-bindings: remoteproc: qcom: Add power-domain bindings for Q6V5 Sibi Sankar
2018-12-18 0:01 ` Doug Anderson
2018-12-18 6:30 ` Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 5/7] arm64: dts: qcom: sdm845: Add Q6V5 MSS node Sibi Sankar
2018-12-18 0:02 ` Doug Anderson
2018-12-18 6:35 ` Sibi Sankar
2018-12-18 16:00 ` kbuild test robot
2018-12-17 10:07 ` [PATCH v2 6/7] arm64: dts: qcom: sdm845: Add power-domain for " Sibi Sankar
2018-12-18 0:02 ` Doug Anderson
2018-12-18 6:38 ` Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 7/7] arm64: dts: qcom: sdm845: Add shutdown-ack " Sibi Sankar
2018-12-18 0:02 ` Doug Anderson
2018-12-17 23:59 ` [PATCH v2 1/7] dt-bindings: soc: qcom: Add remote-pid binding for GLINK SMEM Doug Anderson
2018-12-18 5:16 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13e6d8d6bb46dfc31b5bca927b71223f@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=akdwived@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=briannorris@chromium.org \
--cc=clew@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc-owner@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).