From: Sibi Sankar <sibis@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: bjorn.andersson@linaro.org, andy.gross@linaro.org,
david.brown@linaro.org, dianders@chromium.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
tsoni@codeaurora.org, clew@codeaurora.org,
akdwived@codeaurora.org, mark.rutland@arm.com,
linux-remoteproc@vger.kernel.org, evgreen@chromium.org,
briannorris@chromium.org, linux-remoteproc-owner@vger.kernel.org
Subject: Re: [PATCH v2 2/7] dt-bindings: remoteproc: qcom: Add clock bindings for Q6V5
Date: Wed, 19 Dec 2018 12:34:55 +0530 [thread overview]
Message-ID: <365dfd8e7160c0c3e5a113dbaa88be68@codeaurora.org> (raw)
In-Reply-To: <20181218172709.GA19660@bogus>
Hi Rob,
Thanks for the review!
On 2018-12-18 22:57, Rob Herring wrote:
> On Mon, Dec 17, 2018 at 03:37:19PM +0530, Sibi Sankar wrote:
>> Add missing clock bindings for Q6V5 MSS on SDM845 SoCs.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 10
>> +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> index 9ff5b0309417..780adc043b37 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> @@ -39,13 +39,17 @@ on the Qualcomm Hexagon core.
>> - clocks:
>> Usage: required
>> Value type: <phandle>
>> - Definition: reference to the iface, bus and mem clocks to be held on
>> - behalf of the booting of the Hexagon core
>> + Definition: reference to the list of 4 clocks for the modem
>> sub-system
>> + reference to the list of 8 clocks for the modem sub-system
>> + on SDM845 SoCs
>>
>> - clock-names:
>> Usage: required
>> Value type: <stringlist>
>> - Definition: must be "iface", "bus", "mem"
>> + Definition: must be "iface", "bus", "mem", "xo" for the modem
>> sub-system
>> + must be "iface", "bus", "mem", "gpll0_mss", "snoc_axi",
>> + "mnoc_axi", "prng", "xo" for the modem sub-system on SDM845
>> + SoCs
>
> This seems to me a list of all clocks you need enabled, not what clocks
> actually go to the modem. Specifically, shouldn't the *noc_axi clocks
> be
> managed by the interconnect driver?
clocks = ...,
<&gcc GCC_MSS_SNOC_AXI_CLK>,
<&gcc GCC_MSS_MFAB_AXIS_CLK>,
...;
clock-names = ..., "snoc_axi", "mnoc_axi",...;
snoc_axi and mnoc_axi maps to above GCC clks and
both of them fall under the MSS functional group
>
> Rob
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-12-19 7:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 10:07 [PATCH v2 1/7] dt-bindings: soc: qcom: Add remote-pid binding for GLINK SMEM Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 2/7] dt-bindings: remoteproc: qcom: Add clock bindings for Q6V5 Sibi Sankar
2018-12-17 23:59 ` Doug Anderson
2018-12-18 5:52 ` Sibi Sankar
2018-12-18 16:07 ` Doug Anderson
2018-12-18 17:27 ` Rob Herring
2018-12-19 7:04 ` Sibi Sankar [this message]
2018-12-17 10:07 ` [PATCH v2 3/7] dt-bindings: remoteproc: qcom: Fixup regulator dependencies Sibi Sankar
2018-12-18 0:00 ` Doug Anderson
2018-12-18 6:50 ` Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 4/7] dt-bindings: remoteproc: qcom: Add power-domain bindings for Q6V5 Sibi Sankar
2018-12-18 0:01 ` Doug Anderson
2018-12-18 6:30 ` Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 5/7] arm64: dts: qcom: sdm845: Add Q6V5 MSS node Sibi Sankar
2018-12-18 0:02 ` Doug Anderson
2018-12-18 6:35 ` Sibi Sankar
2018-12-18 16:00 ` kbuild test robot
2018-12-17 10:07 ` [PATCH v2 6/7] arm64: dts: qcom: sdm845: Add power-domain for " Sibi Sankar
2018-12-18 0:02 ` Doug Anderson
2018-12-18 6:38 ` Sibi Sankar
2018-12-17 10:07 ` [PATCH v2 7/7] arm64: dts: qcom: sdm845: Add shutdown-ack " Sibi Sankar
2018-12-18 0:02 ` Doug Anderson
2018-12-17 23:59 ` [PATCH v2 1/7] dt-bindings: soc: qcom: Add remote-pid binding for GLINK SMEM Doug Anderson
2018-12-18 5:16 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=365dfd8e7160c0c3e5a113dbaa88be68@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=akdwived@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=briannorris@chromium.org \
--cc=clew@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc-owner@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).