* [PATCH] cpufreq: intel_pstate: fix intel_pstate_use_acpi_profile helper
@ 2016-11-14 16:41 Arnd Bergmann
2016-11-14 17:14 ` Srinivas Pandruvada
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-11-14 16:41 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Arnd Bergmann, Srinivas Pandruvada, Len Brown, Viresh Kumar,
Philippe Longepe, Stephane Gasparini, linux-pm, linux-kernel
The newly added function uses two different prototypes depending
on configuration, and one of them does not match the caller:
drivers/cpufreq/intel_pstate.c: In function ‘copy_cpu_funcs’:
drivers/cpufreq/intel_pstate.c:1798:2: error: too few arguments to function ‘intel_pstate_use_acpi_profile’
This changes it to look like the other one.
Fixes: 3bea6a285476 ("cpufreq: intel_pstate: Use cpu load based algorithm for mobile class devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/cpufreq/intel_pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 65832f8eacdc..7153cf2d8e11 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -1779,7 +1779,7 @@ static void intel_pstate_use_acpi_profile(void)
get_target_pstate_use_cpu_load;
}
#else
-static inline void intel_pstate_use_acpi_profile(struct pstate_funcs *funcs)
+static inline void intel_pstate_use_acpi_profile(void)
{
}
#endif
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: intel_pstate: fix intel_pstate_use_acpi_profile helper
2016-11-14 16:41 [PATCH] cpufreq: intel_pstate: fix intel_pstate_use_acpi_profile helper Arnd Bergmann
@ 2016-11-14 17:14 ` Srinivas Pandruvada
2016-11-14 17:53 ` Pandruvada, Srinivas
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas Pandruvada @ 2016-11-14 17:14 UTC (permalink / raw)
To: Arnd Bergmann, Rafael J. Wysocki
Cc: Len Brown, Viresh Kumar, Philippe Longepe, Stephane Gasparini,
linux-pm, linux-kernel
On Mon, 2016-11-14 at 17:41 +0100, Arnd Bergmann wrote:
> The newly added function uses two different prototypes depending
> on configuration, and one of them does not match the caller:
>
> drivers/cpufreq/intel_pstate.c: In function ‘copy_cpu_funcs’:
> drivers/cpufreq/intel_pstate.c:1798:2: error: too few arguments to
> function ‘intel_pstate_use_acpi_profile’
>
> This changes it to look like the other one.
Sorry about that.
>
> Fixes: 3bea6a285476 ("cpufreq: intel_pstate: Use cpu load based
> algorithm for mobile class devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c
> b/drivers/cpufreq/intel_pstate.c
> index 65832f8eacdc..7153cf2d8e11 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1779,7 +1779,7 @@ static void intel_pstate_use_acpi_profile(void)
> get_target_pstate_use_cpu_load;
> }
> #else
> -static inline void intel_pstate_use_acpi_profile(struct pstate_funcs
> *funcs)
> +static inline void intel_pstate_use_acpi_profile(void)
> {
> }
> #endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: intel_pstate: fix intel_pstate_use_acpi_profile helper
2016-11-14 17:14 ` Srinivas Pandruvada
@ 2016-11-14 17:53 ` Pandruvada, Srinivas
0 siblings, 0 replies; 3+ messages in thread
From: Pandruvada, Srinivas @ 2016-11-14 17:53 UTC (permalink / raw)
To: arnd, rjw
Cc: lenb, viresh.kumar, Gasparini, Stephane, philippe.longepe,
linux-pm, linux-kernel
On Mon, 2016-11-14 at 09:14 -0800, Srinivas Pandruvada wrote:
> On Mon, 2016-11-14 at 17:41 +0100, Arnd Bergmann wrote:
> >
> > The newly added function uses two different prototypes depending
> > on configuration, and one of them does not match the caller:
> >
> > drivers/cpufreq/intel_pstate.c: In function ‘copy_cpu_funcs’:
> > drivers/cpufreq/intel_pstate.c:1798:2: error: too few arguments to
> > function ‘intel_pstate_use_acpi_profile’
> >
> > This changes it to look like the other one.
> Sorry about that.
Since this is a compile issue for x86 non ACPI systems, which will be a
problem for git bisect, it is better to resubmit my patch with the fix.
Thanks,
Srinivas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-14 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-14 16:41 [PATCH] cpufreq: intel_pstate: fix intel_pstate_use_acpi_profile helper Arnd Bergmann
2016-11-14 17:14 ` Srinivas Pandruvada
2016-11-14 17:53 ` Pandruvada, Srinivas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).