linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Claudiu Beznea <claudiu.beznea@microchip.com>,
	alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com,
	mturquette@baylibre.com, nicolas.ferre@microchip.com
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: Re: [PATCH v4 02/17] clk: at91: pmc: execute suspend/resume only for backup mode
Date: Thu, 07 Oct 2021 20:51:36 -0700	[thread overview]
Message-ID: <163366509609.2041162.16407625879723979586@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210923132046.1860549-3-claudiu.beznea@microchip.com>

Quoting Claudiu Beznea (2021-09-23 06:20:31)
> Before going to backup mode architecture specific PM code sets the first
> word in securam (file arch/arm/mach-at91/pm.c, function at91_pm_begin()).
> Thus take this into account when suspending/resuming clocks. This will
> avoid executing unnecessary instructions when suspending to non backup
> modes. Also this commit changed the postcore_initcall() with
> subsys_initcall() to be able to execute of_find_compatible_node() since
> this was not available at the moment of postcore_initcall(). This should
> not alter the tcb_clksrc since the changes are related to clocks
> suspend/resume procedure that will be executed at the user space request,
> thus long ago after subsys_initcall().

Is the comment still relevant though?

> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
> index b2806946a77a..58e9c088cb22 100644
> --- a/drivers/clk/at91/pmc.c
> +++ b/drivers/clk/at91/pmc.c
> @@ -110,13 +112,35 @@ struct pmc_data *pmc_data_allocate(unsigned int ncore, unsigned int nsystem,
>  }
>  
>  #ifdef CONFIG_PM
> +
> +/* Address in SECURAM that say if we suspend to backup mode. */
> +static void __iomem *at91_pmc_backup_suspend;
> +
>  static int at91_pmc_suspend(void)
>  {
> +       unsigned int backup;
> +
> +       if (!at91_pmc_backup_suspend)
> +               return 0;
> +
> +       backup = *(unsigned int *)at91_pmc_backup_suspend;

This will fail sparse. Why are we reading iomem without using iomem
reading wrapper?

> +       if (!backup)

  reply	other threads:[~2021-10-08  3:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 13:20 [PATCH v4 00/17] clk: at91: updates for power management and dvfs Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 01/17] clk: at91: re-factor clocks suspend/resume Claudiu Beznea
2021-09-23 13:23   ` Claudiu.Beznea
2021-09-23 13:20 ` [PATCH v4 02/17] clk: at91: pmc: execute suspend/resume only for backup mode Claudiu Beznea
2021-10-08  3:51   ` Stephen Boyd [this message]
2021-10-08  6:47     ` Claudiu.Beznea
2021-10-08 22:05       ` Stephen Boyd
2021-09-23 13:20 ` [PATCH v4 03/17] clk: at91: sama7g5: add securam's peripheral clock Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 04/17] clk: at91: clk-master: add register definition for sama7g5's master clock Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 05/17] clk: at91: clk-master: improve readability by using local variables Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 06/17] clk: at91: pmc: add sama7g5 to the list of available pmcs Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 07/17] clk: at91: sam9x60-pll: use DIV_ROUND_CLOSEST_ULL Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 08/17] clk: at91: clk-master: check if div or pres is zero Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 09/17] clk: at91: clk-master: mask mckr against layout->mask Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 10/17] clk: at91: clk-master: fix prescaler logic Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 11/17] clk: at91: clk-sam9x60-pll: add notifier for div part of PLL Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 12/17] clk: at91: clk-master: add notifier for divider Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 13/17] clk: at91: sama7g5: remove prescaler part of master clock Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 14/17] clk: at91: sama7g5: set low limit for mck0 at 32KHz Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 15/17] clk: use clk_core_get_rate_recalc() in clk_rate_get() Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 16/17] clk: remove extra empty line Claudiu Beznea
2021-10-08  3:54   ` Stephen Boyd
2021-09-23 13:20 ` [PATCH v4 17/17] clk: do not initialize ret Claudiu Beznea
2021-10-08  3:55   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163366509609.2041162.16407625879723979586@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=mturquette@baylibre.com \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).