linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Claudiu Beznea <claudiu.beznea@microchip.com>
To: <mturquette@baylibre.com>, <sboyd@kernel.org>,
	<nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>
Cc: <linux-clk@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: [PATCH v4 07/17] clk: at91: sam9x60-pll: use DIV_ROUND_CLOSEST_ULL
Date: Thu, 23 Sep 2021 16:20:36 +0300	[thread overview]
Message-ID: <20210923132046.1860549-8-claudiu.beznea@microchip.com> (raw)
In-Reply-To: <20210923132046.1860549-1-claudiu.beznea@microchip.com>

Use DIV_ROUND_CLOSEST_ULL() to avoid any inconsistency b/w the rate
computed in sam9x60_frac_pll_recalc_rate() and the one computed in
sam9x60_frac_pll_compute_mul_frac().

Fixes: 43b1bb4a9b3e1 ("clk: at91: clk-sam9x60-pll: re-factor to support plls with multiple outputs")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 drivers/clk/at91/clk-sam9x60-pll.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/at91/clk-sam9x60-pll.c b/drivers/clk/at91/clk-sam9x60-pll.c
index 7020d3bf6e13..a73d7c96ce1d 100644
--- a/drivers/clk/at91/clk-sam9x60-pll.c
+++ b/drivers/clk/at91/clk-sam9x60-pll.c
@@ -73,8 +73,8 @@ static unsigned long sam9x60_frac_pll_recalc_rate(struct clk_hw *hw,
 	struct sam9x60_pll_core *core = to_sam9x60_pll_core(hw);
 	struct sam9x60_frac *frac = to_sam9x60_frac(core);
 
-	return (parent_rate * (frac->mul + 1) +
-		((u64)parent_rate * frac->frac >> 22));
+	return parent_rate * (frac->mul + 1) +
+		DIV_ROUND_CLOSEST_ULL((u64)parent_rate * frac->frac, (1 << 22));
 }
 
 static int sam9x60_frac_pll_set(struct sam9x60_pll_core *core)
-- 
2.25.1


  parent reply	other threads:[~2021-09-23 13:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 13:20 [PATCH v4 00/17] clk: at91: updates for power management and dvfs Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 01/17] clk: at91: re-factor clocks suspend/resume Claudiu Beznea
2021-09-23 13:23   ` Claudiu.Beznea
2021-09-23 13:20 ` [PATCH v4 02/17] clk: at91: pmc: execute suspend/resume only for backup mode Claudiu Beznea
2021-10-08  3:51   ` Stephen Boyd
2021-10-08  6:47     ` Claudiu.Beznea
2021-10-08 22:05       ` Stephen Boyd
2021-09-23 13:20 ` [PATCH v4 03/17] clk: at91: sama7g5: add securam's peripheral clock Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 04/17] clk: at91: clk-master: add register definition for sama7g5's master clock Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 05/17] clk: at91: clk-master: improve readability by using local variables Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 06/17] clk: at91: pmc: add sama7g5 to the list of available pmcs Claudiu Beznea
2021-09-23 13:20 ` Claudiu Beznea [this message]
2021-09-23 13:20 ` [PATCH v4 08/17] clk: at91: clk-master: check if div or pres is zero Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 09/17] clk: at91: clk-master: mask mckr against layout->mask Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 10/17] clk: at91: clk-master: fix prescaler logic Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 11/17] clk: at91: clk-sam9x60-pll: add notifier for div part of PLL Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 12/17] clk: at91: clk-master: add notifier for divider Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 13/17] clk: at91: sama7g5: remove prescaler part of master clock Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 14/17] clk: at91: sama7g5: set low limit for mck0 at 32KHz Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 15/17] clk: use clk_core_get_rate_recalc() in clk_rate_get() Claudiu Beznea
2021-09-23 13:20 ` [PATCH v4 16/17] clk: remove extra empty line Claudiu Beznea
2021-10-08  3:54   ` Stephen Boyd
2021-09-23 13:20 ` [PATCH v4 17/17] clk: do not initialize ret Claudiu Beznea
2021-10-08  3:55   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210923132046.1860549-8-claudiu.beznea@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=mturquette@baylibre.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).