From: Jens Axboe <axboe@suse.de>
To: Andrew Morton <akpm@zip.com.au>
Cc: Mike Fedyk <mfedyk@matchmail.com>,
lkml <linux-kernel@vger.kernel.org>,
ext2-devel@lists.sourceforge.net
Subject: Re: [Ext2-devel] disk throughput
Date: Mon, 5 Nov 2001 08:18:36 +0100 [thread overview]
Message-ID: <20011105081836.F2580@suse.de> (raw)
In-Reply-To: <3BE5F5BF.7A249BDF@zip.com.au>, <3BE5F5BF.7A249BDF@zip.com.au> <20011104193232.A16679@mikef-linux.matchmail.com> <3BE60B51.968458D3@zip.com.au> <20011105080635.D2580@suse.de>
In-Reply-To: <20011105080635.D2580@suse.de>
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
On Mon, Nov 05 2001, Jens Axboe wrote:
> Interesting, the 2.5 design prevents this since it doesn't account
> merges as a penalty (like a seek). I can do something like that for 2.4
> too, I'll do a patch for you to test.
Ok here it is. It's not as efficient as the 2.5 version since it
proceeds to scan the entire queue for a merge, but it should suffice for
your testing.
--
Jens Axboe
[-- Attachment #2: elv-merge-account-1 --]
[-- Type: text/plain, Size: 1711 bytes --]
--- drivers/block/ll_rw_blk.c~ Mon Nov 5 08:15:25 2001
+++ drivers/block/ll_rw_blk.c Mon Nov 5 08:15:51 2001
@@ -696,7 +696,9 @@
case ELEVATOR_BACK_MERGE:
if (!q->back_merge_fn(q, req, bh, max_segments))
break;
+#if 0
elevator->elevator_merge_cleanup_fn(q, req, count);
+#endif
req->bhtail->b_reqnext = bh;
req->bhtail = bh;
req->nr_sectors = req->hard_nr_sectors += count;
@@ -708,7 +710,9 @@
case ELEVATOR_FRONT_MERGE:
if (!q->front_merge_fn(q, req, bh, max_segments))
break;
+#if 0
elevator->elevator_merge_cleanup_fn(q, req, count);
+#endif
bh->b_reqnext = req->bh;
req->bh = bh;
req->buffer = bh->b_data;
--- drivers/block/elevator.c~ Mon Nov 5 08:13:19 2001
+++ drivers/block/elevator.c Mon Nov 5 08:18:04 2001
@@ -81,8 +81,9 @@
int max_sectors)
{
struct list_head *entry = &q->queue_head;
- unsigned int count = bh->b_size >> 9, ret = ELEVATOR_NO_MERGE;
+ unsigned int count = bh->b_size >> 9, ret = ELEVATOR_NO_MERGE, queue;
+ queue = 1;
while ((entry = entry->prev) != head) {
struct request *__rq = blkdev_entry_to_request(entry);
@@ -90,13 +91,13 @@
* simply "aging" of requests in queue
*/
if (__rq->elevator_sequence-- <= 0)
- break;
+ queue = 0;
if (__rq->waiting)
continue;
if (__rq->rq_dev != bh->b_rdev)
continue;
- if (!*req && bh_rq_in_between(bh, __rq, &q->queue_head))
+ if (queue && !*req && bh_rq_in_between(bh, __rq,&q->queue_head))
*req = __rq;
if (__rq->cmd != rw)
continue;
@@ -110,7 +111,6 @@
break;
} else if (__rq->sector - count == bh->b_rsector) {
ret = ELEVATOR_FRONT_MERGE;
- __rq->elevator_sequence -= count;
*req = __rq;
break;
}
next prev parent reply other threads:[~2001-11-05 7:19 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-05 2:13 disk throughput Andrew Morton
2001-11-05 3:20 ` Mohammad A. Haque
2001-11-05 3:31 ` Andrew Morton
2001-11-05 3:32 ` [Ext2-devel] " Mike Fedyk
2001-11-05 3:45 ` Andrew Morton
2001-11-05 4:39 ` Mike Fedyk
2001-11-05 7:06 ` Jens Axboe
2001-11-05 7:14 ` Andrew Morton
2001-11-05 7:26 ` Jens Axboe
2001-11-05 7:14 ` Mike Fedyk
2001-11-05 7:18 ` Jens Axboe
2001-11-05 7:18 ` Jens Axboe [this message]
2001-11-05 9:14 ` Mike Fedyk
2001-11-05 9:20 ` Jens Axboe
2001-11-05 5:54 ` Albert D. Cahalan
2001-11-05 8:04 ` Andrew Morton
2001-11-05 12:28 ` Matthias Andree
2001-11-05 14:23 ` Alexander Viro
2001-11-05 22:22 ` Andrew Morton
2001-11-05 22:41 ` Andreas Dilger
2001-11-05 22:53 ` Andrew Morton
2001-11-08 15:28 ` Constantin Loizides
2001-11-05 23:14 ` Dan Hollis
2001-11-06 10:52 ` Daniel Phillips
2001-11-06 16:17 ` Jeremy Fitzhardinge
2001-11-08 15:24 ` Constantin Loizides
2001-11-08 16:46 ` Jeremy Fitzhardinge
2001-11-09 6:08 ` Andrew Morton
2001-11-09 8:49 ` Jeremy Fitzhardinge
2001-11-06 21:45 ` Stephen Tweedie
2001-11-05 20:16 ` Andreas Dilger
2001-11-05 20:28 ` m
2001-11-05 21:39 ` Andrew Morton
2001-11-05 22:59 ` Linus Torvalds
2001-11-05 23:36 ` Alexander Viro
2001-11-05 23:50 ` Linus Torvalds
2001-11-06 0:03 ` Linus Torvalds
2001-11-06 1:33 ` Alexander Viro
2001-11-06 2:10 ` Linus Torvalds
2001-11-06 3:02 ` Alexander Viro
2001-11-06 8:39 ` Alan Cox
2001-11-06 8:37 ` Alexander Viro
2001-11-06 8:48 ` Andrew Morton
2001-11-06 3:49 ` Alexander Viro
2001-11-06 4:01 ` Linus Torvalds
2001-11-06 4:21 ` Alexander Viro
2001-11-06 5:01 ` Linus Torvalds
2001-11-06 5:31 ` Andrew Morton
2001-11-06 5:48 ` Linus Torvalds
2001-11-06 7:34 ` Mike Castle
2001-11-06 7:10 ` Kai Henningsen
2001-11-09 22:35 ` Riley Williams
2001-11-06 1:28 ` Alexander Viro
2001-11-06 9:16 ` Wojtek Pilorz
2001-11-06 9:58 ` Alexander Viro
2001-11-08 12:51 ` Pavel Machek
2001-11-06 21:48 ` Stephen Tweedie
2001-11-06 23:17 ` ext2/ialloc.c cleanup Alexander Viro
2001-11-07 19:34 ` [Ext2-devel] " Andreas Dilger
2001-11-07 20:02 ` Alexander Viro
2001-11-08 2:06 ` Andrew Morton
2001-11-08 20:45 ` Andrew Morton
2001-11-08 22:16 ` Alexander Viro
2001-11-08 22:43 ` Andreas Dilger
2001-11-08 23:08 ` Alexander Viro
2001-11-09 6:15 ` Andrew Morton
2001-11-09 6:56 ` Andreas Dilger
2001-11-09 7:09 ` Andrew Morton
2001-11-09 7:12 ` Alexander Viro
2001-11-09 7:18 ` Andrew Morton
2001-11-05 9:45 ` [Ext2-devel] disk throughput Alex Bligh - linux-kernel
2001-11-05 9:58 ` Alex Bligh - linux-kernel
2001-11-05 8:47 ` Jan Kara
2001-11-05 8:50 ` [Ext2-devel] " Mike Fedyk
2001-11-05 9:01 ` Jan Kara
2001-11-05 12:23 ` Matthias Andree
2001-11-05 22:39 ` Andrew Morton
2001-11-05 23:41 ` Matthias Andree
2001-11-12 6:04 [Ext2-devel] " Yan, Noah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011105081836.F2580@suse.de \
--to=axboe@suse.de \
--cc=akpm@zip.com.au \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mfedyk@matchmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).